From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Andrey Skvortsov <andrej.skvortzov@gmail.com>,
Alessandro Zummo <a.zummo@towertech.it>,
linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rtc: tps65910: allow using RTC without alarm interrupt
Date: Thu, 14 Nov 2019 20:59:41 +0100 [thread overview]
Message-ID: <20191114195941.GL3572@piout.net> (raw)
In-Reply-To: <20191113230805.GH13629@skv.local>
On 14/11/2019 02:08:05+0300, Andrey Skvortsov wrote:
> > > static int tps65910_rtc_probe(struct platform_device *pdev)
> > > {
> > > struct tps65910 *tps65910 = NULL;
> > > @@ -415,13 +422,17 @@ static int tps65910_rtc_probe(struct platform_device *pdev)
> > > tps65910_rtc_interrupt, IRQF_TRIGGER_LOW,
> > > dev_name(&pdev->dev), &pdev->dev);
> > > if (ret < 0) {
> > > - dev_err(&pdev->dev, "IRQ is not free.\n");
> > > - return ret;
> > > + dev_err(&pdev->dev, "request IRQ:%d failed, err = %d\n",
> > > + irq, ret);
> >
> > Do we actually need an error message here?
>
> You are right. This is definitely not an error anymore.
> What about
> dev_warn(&pdev->dev, "unable to request IRQ, alarms disabled\n");
> like some other drivers do?
>
Yes, or that can be left out completely as userspace will be able to
know whether alarms are supported without this message.
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2019-11-14 19:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-09 15:46 [PATCH] rtc: tps65910: allow using RTC without alarm interrupt Andrey Skvortsov
2019-11-11 17:19 ` Alexandre Belloni
2019-11-13 23:08 ` Andrey Skvortsov
2019-11-14 19:59 ` Alexandre Belloni [this message]
2019-11-16 20:37 ` [PATCHv2] " Andrey Skvortsov
2019-11-18 14:19 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191114195941.GL3572@piout.net \
--to=alexandre.belloni@bootlin.com \
--cc=a.zummo@towertech.it \
--cc=andrej.skvortzov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).