Linux-RTC Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH -next] rtc: mt6397: drop free_irq of devm_xx allocated irq
@ 2019-12-04  2:02 Mao Wenan
  2019-12-04  6:35 ` Dan Carpenter
  0 siblings, 1 reply; 5+ messages in thread
From: Mao Wenan @ 2019-12-04  2:02 UTC (permalink / raw)
  To: eddie.huang, sean.wang, a.zummo, alexandre.belloni, matthias.bgg
  Cc: linux-arm-kernel, linux-mediatek, linux-rtc, linux-kernel,
	kernel-janitors, Mao Wenan, Hulk Robot

rtc->irq is requested by devm_request_threaded_irq,
and request_threaded_irq. IRQs requested with this
function will be automatically freed on driver detach.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Mao Wenan <maowenan@huawei.com>
---
 drivers/rtc/rtc-mt6397.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/rtc/rtc-mt6397.c b/drivers/rtc/rtc-mt6397.c
index 5249fc99fd5f..d6a10111137a 100644
--- a/drivers/rtc/rtc-mt6397.c
+++ b/drivers/rtc/rtc-mt6397.c
@@ -293,7 +293,6 @@ static int mtk_rtc_probe(struct platform_device *pdev)
 	return 0;
 
 out_free_irq:
-	free_irq(rtc->irq, rtc);
 	return ret;
 }
 
-- 
2.20.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, back to index

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-04  2:02 [PATCH -next] rtc: mt6397: drop free_irq of devm_xx allocated irq Mao Wenan
2019-12-04  6:35 ` Dan Carpenter
2019-12-04  7:28   ` [PATCH v2 " Mao Wenan
2019-12-04  8:40     ` Alexandre Belloni
2019-12-04  8:42       ` Alexandre Belloni

Linux-RTC Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-rtc/0 linux-rtc/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-rtc linux-rtc/ https://lore.kernel.org/linux-rtc \
		linux-rtc@vger.kernel.org
	public-inbox-index linux-rtc

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-rtc


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git