Linux-RTC Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] rtc: i2c/spi: Avoid inclusion of REGMAP support when not needed
@ 2020-01-12 17:13 Geert Uytterhoeven
  2020-01-12 21:45 ` kbuild test robot
                   ` (3 more replies)
  0 siblings, 4 replies; 13+ messages in thread
From: Geert Uytterhoeven @ 2020-01-12 17:13 UTC (permalink / raw)
  To: Alessandro Zummo, Alexandre Belloni, Akinobu Mita, Joe Perches
  Cc: linux-rtc, linux-kernel, Geert Uytterhoeven

Merely enabling I2C and RTC selects REGMAP_I2C and REGMAP_SPI, even when
no driver needs it.  While the former can be moduler, the latter cannot,
and thus becomes built-in.

Fix this by moving the select statements for REGMAP_I2C and REGMAP_SPI
from the RTC_I2C_AND_SPI helper to the individual drivers that depend on
it.

Note that the comment for RTC_I2C_AND_SPI refers to SND_SOC_I2C_AND_SPI
for more information, but the latter does not select REGMAP_{I2C,SPI}
itself, and defers that to the individual drivers, too.

Fixes: 080481f54ef62121 ("rtc: merge ds3232 and ds3234")
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
Joe: When merging addresses, scripts/get_maintainer.pl replaces
     Alexandre's authoritative email address from MAINTAINERS by the
     obsolete address in the SoB-line of the commit referred to by the
     Fixes-line.

 drivers/rtc/Kconfig | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig
index d77515d8382c7a72..738fa071884094d1 100644
--- a/drivers/rtc/Kconfig
+++ b/drivers/rtc/Kconfig
@@ -848,14 +848,14 @@ config RTC_I2C_AND_SPI
 	default m if I2C=m
 	default y if I2C=y
 	default y if SPI_MASTER=y
-	select REGMAP_I2C if I2C
-	select REGMAP_SPI if SPI_MASTER
 
 comment "SPI and I2C RTC drivers"
 
 config RTC_DRV_DS3232
 	tristate "Dallas/Maxim DS3232/DS3234"
 	depends on RTC_I2C_AND_SPI
+	select REGMAP_I2C if I2C
+	select REGMAP_SPI if SPI_MASTER
 	help
 	  If you say yes here you get support for Dallas Semiconductor
 	  DS3232 and DS3234 real-time clock chips. If an interrupt is associated
@@ -875,6 +875,8 @@ config RTC_DRV_DS3232_HWMON
 config RTC_DRV_PCF2127
 	tristate "NXP PCF2127"
 	depends on RTC_I2C_AND_SPI
+	select REGMAP_I2C if I2C
+	select REGMAP_SPI if SPI_MASTER
 	select WATCHDOG_CORE if WATCHDOG
 	help
 	  If you say yes here you get support for the NXP PCF2127/29 RTC
@@ -891,6 +893,8 @@ config RTC_DRV_PCF2127
 config RTC_DRV_RV3029C2
 	tristate "Micro Crystal RV3029/3049"
 	depends on RTC_I2C_AND_SPI
+	select REGMAP_I2C if I2C
+	select REGMAP_SPI if SPI_MASTER
 	help
 	  If you say yes here you get support for the Micro Crystal
 	  RV3029 and RV3049 RTC chips.
-- 
2.17.1


^ permalink raw reply	[flat|nested] 13+ messages in thread

end of thread, back to index

Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-12 17:13 [PATCH] rtc: i2c/spi: Avoid inclusion of REGMAP support when not needed Geert Uytterhoeven
2020-01-12 21:45 ` kbuild test robot
2020-01-13  1:29 ` kbuild test robot
2020-01-13  6:36 ` Joe Perches
2020-01-13  7:25   ` Geert Uytterhoeven
2020-01-13  7:40     ` Joe Perches
2020-01-13  7:57       ` Geert Uytterhoeven
2020-01-13  8:12         ` Joe Perches
2020-01-14 10:13           ` Geert Uytterhoeven
2020-01-27 22:45 ` Alexandre Belloni
2020-01-28  8:33   ` Geert Uytterhoeven
2020-01-28  8:50     ` Alexandre Belloni
2020-01-28  8:59       ` Geert Uytterhoeven

Linux-RTC Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-rtc/0 linux-rtc/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-rtc linux-rtc/ https://lore.kernel.org/linux-rtc \
		linux-rtc@vger.kernel.org
	public-inbox-index linux-rtc

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-rtc


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git