From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F78EC33CB6 for ; Thu, 16 Jan 2020 16:52:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CD92624673 for ; Thu, 16 Jan 2020 16:52:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579193577; bh=hbT6v7cr6oMupzlSl+t+L1ONOraWXap3+5L6jpEi5M8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=WTo57E6M2qsRDL0Ytrw0WrAqKZzpYIvflYDp8G3Cq5tod0Oc9jx/M/yOknGO+ob1l 43ZYzSiVXtK88JaXVqy2hIpxPl2EYR8eYFJNz5PW4khMeC/ABh5OhN1LX/+/hJepva 7EZjLfI3GVeGk9qFvcP0JCXR8f78lJ2CphQxscug= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730550AbgAPQw5 (ORCPT ); Thu, 16 Jan 2020 11:52:57 -0500 Received: from mail.kernel.org ([198.145.29.99]:36310 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730542AbgAPQwz (ORCPT ); Thu, 16 Jan 2020 11:52:55 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8171C21582; Thu, 16 Jan 2020 16:52:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579193575; bh=hbT6v7cr6oMupzlSl+t+L1ONOraWXap3+5L6jpEi5M8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=SZpozFLzEsqmphizm8AGUiAY+d2DK6IejoVbRVY27ltkvFYQ+9kWiScdIajj4rK6h pMl2A0YabniOfSbqgDvBYsoIOX8vBY3IRXEEkyA7nXRIFgfdZxA9IrKdKKYN/OCt4X 0ZsY2bcoKnc9o2y6BVp0Ytlgqq7RyvB1eU2Q2vu4= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Chuhong Yuan , Florian Fainelli , Alexandre Belloni , Sasha Levin , linux-rtc@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH AUTOSEL 5.4 118/205] rtc: brcmstb-waketimer: add missed clk_disable_unprepare Date: Thu, 16 Jan 2020 11:41:33 -0500 Message-Id: <20200116164300.6705-118-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200116164300.6705-1-sashal@kernel.org> References: <20200116164300.6705-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-rtc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rtc@vger.kernel.org From: Chuhong Yuan [ Upstream commit 94303f8930ed78aea0f189b703c9d79fff9555d7 ] This driver forgets to disable and unprepare clock when remove. Add a call to clk_disable_unprepare to fix it. Fixes: c4f07ecee22e ("rtc: brcmstb-waketimer: Add Broadcom STB wake-timer") Signed-off-by: Chuhong Yuan Acked-by: Florian Fainelli Link: https://lore.kernel.org/r/20191105160043.20018-1-hslester96@gmail.com Signed-off-by: Alexandre Belloni Signed-off-by: Sasha Levin --- drivers/rtc/rtc-brcmstb-waketimer.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/rtc/rtc-brcmstb-waketimer.c b/drivers/rtc/rtc-brcmstb-waketimer.c index 3e9800f9878a..82d2ab0b3e9c 100644 --- a/drivers/rtc/rtc-brcmstb-waketimer.c +++ b/drivers/rtc/rtc-brcmstb-waketimer.c @@ -277,6 +277,7 @@ static int brcmstb_waketmr_remove(struct platform_device *pdev) struct brcmstb_waketmr *timer = dev_get_drvdata(&pdev->dev); unregister_reboot_notifier(&timer->reboot_notifier); + clk_disable_unprepare(timer->clk); return 0; } -- 2.20.1