From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F7D6C33CB6 for ; Fri, 17 Jan 2020 10:21:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 071A2214AF for ; Fri, 17 Jan 2020 10:21:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="uWT/LKHF" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727691AbgAQKVm (ORCPT ); Fri, 17 Jan 2020 05:21:42 -0500 Received: from mail-wm1-f67.google.com ([209.85.128.67]:56292 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727162AbgAQKVm (ORCPT ); Fri, 17 Jan 2020 05:21:42 -0500 Received: by mail-wm1-f67.google.com with SMTP id q9so6851079wmj.5 for ; Fri, 17 Jan 2020 02:21:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=oIMnoa3sbVn/rSlDZkNhieTQX0bAIPs2g8BvjBAAJYw=; b=uWT/LKHFB9KJAzcvqgQA2YPyMRp+0vG3uJZJyC3ZOr8OoMycE8q+vQ3sCqK9hRMWk8 CfPK8HfmmypEvmovpHkBAuOmFommCtZrSL3YGxaKtIy3C3wGjROaOrRNZRZF/IbwZ6/N uFv0OCYryACBEzIU3GMggHYVxRB8XhctMuMY3RQ8xEyZFJ+Gu+v8KtV0SrU0pAbLQKw9 aBK0/A/HOC8i4J4FHvzXI7LIUlYeWICcyQgPkVOMFQpN/HRBb9n7nDdCMeaD06aXcIHA pbdfSXj7+3zrtJ7O9sTCzn6iP4wsSNRAQDeSozArMrOTT3pTX/KgJkrI/TVLv78bVqaz +I9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=oIMnoa3sbVn/rSlDZkNhieTQX0bAIPs2g8BvjBAAJYw=; b=Gsqsf9tpE12Weo+rms9Ct28UUZKxMDcv3dHMXv17K1jpwtNcz5wJHAcWVl6Uw9HnJO 9VC5Lq3xwrpmYLtxJybLABdkeOWnu6boBS3tNXoAlLkJl7TlSGLMB44dqzZvbasfQy+m 5i6YzbH7kd86vz+ic9KBw9DV7I3EEaDugGADHqFvCIJrfer17a33vGiHbbrH+N4AmS4F U4OJKh9dSBy50+LRXaNDLh7h66ZrBK3vcBwA0Fx07UrEFWkoRIjWXbm94s1Ie40eCNrw ncpkyaq3HSb9h/n1bOOt9a6rP3ZyGEU4ahU8EdwrLr2aLbAytRvA9cxqbePfyGsxQLl9 37Zg== X-Gm-Message-State: APjAAAXnby93sBq9szg+IQsvUqUz8xWfwJ920M28S8PKlTUY/Zc+PpRF PTTt7YZocmLXrKqiav0wci3kHA== X-Google-Smtp-Source: APXvYqyjoao5W4ukyHmbDLvlRKQ3NULe0P7hwKt2aT/kXMKOsmfbWd9tvncJKeQZdv+1I5pJSDFudA== X-Received: by 2002:a05:600c:2c50:: with SMTP id r16mr3747778wmg.74.1579256500001; Fri, 17 Jan 2020 02:21:40 -0800 (PST) Received: from dell ([2.27.35.221]) by smtp.gmail.com with ESMTPSA id h66sm9780563wme.41.2020.01.17.02.21.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jan 2020 02:21:39 -0800 (PST) Date: Fri, 17 Jan 2020 10:21:57 +0000 From: Lee Jones To: Matti Vaittinen Cc: mazziesaccount@gmail.com, Jacek Anaszewski , Pavel Machek , Dan Murphy , Rob Herring , Mark Rutland , Michael Turquette , Stephen Boyd , Linus Walleij , Bartosz Golaszewski , Liam Girdwood , Mark Brown , Alessandro Zummo , Alexandre Belloni , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-rtc@vger.kernel.org Subject: Re: [PATCH v10 09/13] mfd: bd70528: Fix hour register mask Message-ID: <20200117102157.GE15507@dell> References: <8609d42822a6ce3755e2166b8c1246b3b04eeb78.1579249511.git.matti.vaittinen@fi.rohmeurope.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <8609d42822a6ce3755e2166b8c1246b3b04eeb78.1579249511.git.matti.vaittinen@fi.rohmeurope.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-rtc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rtc@vger.kernel.org On Fri, 17 Jan 2020, Matti Vaittinen wrote: > When RTC is used in 24H mode (and it is by this driver) the maximum > hour value is 24 in BCD. This occupies bits [5:0] - which means > correct mask for HOUR register is 0x3f not 0x1f. Fix the mask > > Fixes: 32a4a4ebf768 ("rtc: bd70528: Initial support for ROHM bd70528 RTC") > > Signed-off-by: Matti Vaittinen > Acked-by: Alexandre Belloni > --- > Changes: Splitted this fix into separate patch which can be applied to > 5.4 too > > include/linux/mfd/rohm-bd70528.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) For my own reference: Acked-for-MFD-by: Lee Jones -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog