From: Pavel Machek <pavel@denx.de>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Alessandro Zummo <a.zummo@towertech.it>,
Sylvain Chouleur <sylvain.chouleur@intel.com>,
Patrick McDermott <patrick.mcdermott@libiquity.com>,
linux-rtc@vger.kernel.org, Eric Wong <e@80x24.org>,
Sasha Levin <sashal@kernel.org>
Subject: Re: [PATCH 4.19 143/639] rtc: cmos: ignore bogus century byte
Date: Sat, 25 Jan 2020 13:04:59 +0100 [thread overview]
Message-ID: <20200125120458.GB14064@duo.ucw.cz> (raw)
In-Reply-To: <20200124093105.163756275@linuxfoundation.org>
[-- Attachment #1: Type: text/plain, Size: 669 bytes --]
Hi!
> From: Eric Wong <e@80x24.org>
>
> [ Upstream commit 2a4daadd4d3e507138f8937926e6a4df49c6bfdc ]
>
> Older versions of Libreboot and Coreboot had an invalid value
> (`3' in my case) in the century byte affecting the GM45 in
> the Thinkpad X200. Not everybody's updated their firmwares,
> and Linux <= 4.2 was able to read the RTC without problems,
> so workaround this by ignoring invalid values.
Should it print a warning so that wrong BIOSes are eventually fixed?
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
prev parent reply other threads:[~2020-01-25 12:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200124093047.008739095@linuxfoundation.org>
2020-01-24 9:25 ` [PATCH 4.19 143/639] rtc: cmos: ignore bogus century byte Greg Kroah-Hartman
2020-01-25 12:04 ` Pavel Machek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200125120458.GB14064@duo.ucw.cz \
--to=pavel@denx.de \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=e@80x24.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=patrick.mcdermott@libiquity.com \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
--cc=sylvain.chouleur@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).