* [PATCH v2 14/17] rtc: cros-ec: Use cros_ec_cmd() [not found] <20200205190028.183069-1-pmalani@chromium.org> @ 2020-02-05 19:00 ` Prashant Malani 2020-02-05 20:04 ` Alexandre Belloni 0 siblings, 1 reply; 2+ messages in thread From: Prashant Malani @ 2020-02-05 19:00 UTC (permalink / raw) To: linux-kernel Cc: Prashant Malani, Alessandro Zummo, Alexandre Belloni, Benson Leung, Enric Balletbo i Serra, Guenter Roeck, open list:REAL TIME CLOCK (RTC) SUBSYSTEM Replace cros_ec_cmd_xfer_status() with cros_ec_cmd() which does the message buffer setup and cleanup. Signed-off-by: Prashant Malani <pmalani@chromium.org> --- Changes in v2: - Updated to use new function name and parameter list. drivers/rtc/rtc-cros-ec.c | 27 ++++++++------------------- 1 file changed, 8 insertions(+), 19 deletions(-) diff --git a/drivers/rtc/rtc-cros-ec.c b/drivers/rtc/rtc-cros-ec.c index f7343c289cab73..6886100ad0b8b7 100644 --- a/drivers/rtc/rtc-cros-ec.c +++ b/drivers/rtc/rtc-cros-ec.c @@ -33,16 +33,11 @@ static int cros_ec_rtc_get(struct cros_ec_device *cros_ec, u32 command, u32 *response) { int ret; - struct { - struct cros_ec_command msg; - struct ec_response_rtc data; - } __packed msg; - memset(&msg, 0, sizeof(msg)); - msg.msg.command = command; - msg.msg.insize = sizeof(msg.data); + struct ec_response_rtc data = {0}; - ret = cros_ec_cmd_xfer_status(cros_ec, &msg.msg); + ret = cros_ec_cmd(cros_ec, 0, command, NULL, 0, &data, sizeof(data), + NULL); if (ret < 0) { dev_err(cros_ec->dev, "error getting %s from EC: %d\n", @@ -51,7 +46,7 @@ static int cros_ec_rtc_get(struct cros_ec_device *cros_ec, u32 command, return ret; } - *response = msg.data.time; + *response = data.time; return 0; } @@ -60,17 +55,11 @@ static int cros_ec_rtc_set(struct cros_ec_device *cros_ec, u32 command, u32 param) { int ret = 0; - struct { - struct cros_ec_command msg; - struct ec_response_rtc data; - } __packed msg; + struct ec_response_rtc data; - memset(&msg, 0, sizeof(msg)); - msg.msg.command = command; - msg.msg.outsize = sizeof(msg.data); - msg.data.time = param; - - ret = cros_ec_cmd_xfer_status(cros_ec, &msg.msg); + data.time = param; + ret = cros_ec_cmd(cros_ec, 0, command, &data, sizeof(data), NULL, 0, + NULL); if (ret < 0) { dev_err(cros_ec->dev, "error setting %s on EC: %d\n", command == EC_CMD_RTC_SET_VALUE ? "time" : "alarm", -- 2.25.0.341.g760bfbb309-goog ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2 14/17] rtc: cros-ec: Use cros_ec_cmd() 2020-02-05 19:00 ` [PATCH v2 14/17] rtc: cros-ec: Use cros_ec_cmd() Prashant Malani @ 2020-02-05 20:04 ` Alexandre Belloni 0 siblings, 0 replies; 2+ messages in thread From: Alexandre Belloni @ 2020-02-05 20:04 UTC (permalink / raw) To: Prashant Malani Cc: linux-kernel, Alessandro Zummo, Benson Leung, Enric Balletbo i Serra, Guenter Roeck, open list:REAL TIME CLOCK (RTC) SUBSYSTEM On 05/02/2020 11:00:22-0800, Prashant Malani wrote: > Replace cros_ec_cmd_xfer_status() with cros_ec_cmd() which does the > message buffer setup and cleanup. > > Signed-off-by: Prashant Malani <pmalani@chromium.org> Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com> > --- > > Changes in v2: > - Updated to use new function name and parameter list. > > drivers/rtc/rtc-cros-ec.c | 27 ++++++++------------------- > 1 file changed, 8 insertions(+), 19 deletions(-) > > diff --git a/drivers/rtc/rtc-cros-ec.c b/drivers/rtc/rtc-cros-ec.c > index f7343c289cab73..6886100ad0b8b7 100644 > --- a/drivers/rtc/rtc-cros-ec.c > +++ b/drivers/rtc/rtc-cros-ec.c > @@ -33,16 +33,11 @@ static int cros_ec_rtc_get(struct cros_ec_device *cros_ec, u32 command, > u32 *response) > { > int ret; > - struct { > - struct cros_ec_command msg; > - struct ec_response_rtc data; > - } __packed msg; > > - memset(&msg, 0, sizeof(msg)); > - msg.msg.command = command; > - msg.msg.insize = sizeof(msg.data); > + struct ec_response_rtc data = {0}; > > - ret = cros_ec_cmd_xfer_status(cros_ec, &msg.msg); > + ret = cros_ec_cmd(cros_ec, 0, command, NULL, 0, &data, sizeof(data), > + NULL); > if (ret < 0) { > dev_err(cros_ec->dev, > "error getting %s from EC: %d\n", > @@ -51,7 +46,7 @@ static int cros_ec_rtc_get(struct cros_ec_device *cros_ec, u32 command, > return ret; > } > > - *response = msg.data.time; > + *response = data.time; > > return 0; > } > @@ -60,17 +55,11 @@ static int cros_ec_rtc_set(struct cros_ec_device *cros_ec, u32 command, > u32 param) > { > int ret = 0; > - struct { > - struct cros_ec_command msg; > - struct ec_response_rtc data; > - } __packed msg; > + struct ec_response_rtc data; > > - memset(&msg, 0, sizeof(msg)); > - msg.msg.command = command; > - msg.msg.outsize = sizeof(msg.data); > - msg.data.time = param; > - > - ret = cros_ec_cmd_xfer_status(cros_ec, &msg.msg); > + data.time = param; > + ret = cros_ec_cmd(cros_ec, 0, command, &data, sizeof(data), NULL, 0, > + NULL); > if (ret < 0) { > dev_err(cros_ec->dev, "error setting %s on EC: %d\n", > command == EC_CMD_RTC_SET_VALUE ? "time" : "alarm", > -- > 2.25.0.341.g760bfbb309-goog > -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-02-05 20:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20200205190028.183069-1-pmalani@chromium.org>
2020-02-05 19:00 ` [PATCH v2 14/17] rtc: cros-ec: Use cros_ec_cmd() Prashant Malani
2020-02-05 20:04 ` Alexandre Belloni
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).