From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Jernej Skrabec <jernej.skrabec@siol.net>
Cc: mripard@kernel.org, wens@csie.org, robh+dt@kernel.org,
a.zummo@towertech.it, linux-arm-kernel@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-rtc@vger.kernel.org
Subject: Re: [PATCH v2 1/2] rtc: sun6i: Make external 32k oscillator optional
Date: Fri, 13 Mar 2020 00:20:46 +0100 [thread overview]
Message-ID: <20200312232046.GB3384@piout.net> (raw)
In-Reply-To: <20200308135849.106333-2-jernej.skrabec@siol.net>
On 08/03/2020 14:58:48+0100, Jernej Skrabec wrote:
> Some boards, like OrangePi PC2 (H5), OrangePi Plus 2E (H3) and Tanix TX6
> (H6) don't have external 32kHz oscillator. Till H6, it didn't really
> matter if external oscillator was enabled because HW detected error and
> fall back to internal one. H6 has same functionality but it's the first
> SoC which have "auto switch bypass" bit documented and always enabled in
> driver. This prevents RTC to work correctly if external crystal is not
> present on board. There are other side effects - all peripherals which
> depends on this clock also don't work (HDMI CEC for example).
>
> Make clocks property optional. If it is present, select external
> oscillator. If not, stay on internal.
>
> Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net>
> ---
> drivers/rtc/rtc-sun6i.c | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
Applied, thanks.
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2020-03-12 23:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-08 13:58 [PATCH v2 0/2] rtc: sun6i: Make external oscillator optional Jernej Skrabec
2020-03-08 13:58 ` [PATCH v2 1/2] rtc: sun6i: Make external 32k " Jernej Skrabec
2020-03-09 15:17 ` Maxime Ripard
2020-03-12 23:20 ` Alexandre Belloni [this message]
2020-03-08 13:58 ` [PATCH v2 2/2] arm64: dts: allwinner: h6: Move ext. oscillator to board DTs Jernej Skrabec
2020-03-09 15:18 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200312232046.GB3384@piout.net \
--to=alexandre.belloni@bootlin.com \
--cc=a.zummo@towertech.it \
--cc=devicetree@vger.kernel.org \
--cc=jernej.skrabec@siol.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=mripard@kernel.org \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).