From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BB8BC0044D for ; Mon, 16 Mar 2020 10:06:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 092462051A for ; Mon, 16 Mar 2020 10:06:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730531AbgCPKF6 (ORCPT ); Mon, 16 Mar 2020 06:05:58 -0400 Received: from relay10.mail.gandi.net ([217.70.178.230]:37275 "EHLO relay10.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730491AbgCPKF5 (ORCPT ); Mon, 16 Mar 2020 06:05:57 -0400 Received: from localhost (lfbn-lyo-1-9-35.w86-202.abo.wanadoo.fr [86.202.105.35]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay10.mail.gandi.net (Postfix) with ESMTPSA id 34E39240037; Mon, 16 Mar 2020 10:00:17 +0000 (UTC) Date: Mon, 16 Mar 2020 11:00:17 +0100 From: Alexandre Belloni To: Anson Huang Cc: Shawn Guo , Peng Fan , "s.hauer@pengutronix.de" , "kernel@pengutronix.de" , "festevam@gmail.com" , "dmitry.torokhov@gmail.com" , "a.zummo@towertech.it" , "rui.zhang@intel.com" , "daniel.lezcano@linaro.org" , "amit.kucheria@verdurent.com" , "wim@linux-watchdog.org" , "linux@roeck-us.net" , Daniel Baluta , "gregkh@linuxfoundation.org" , "linux@rempel-privat.de" , "tglx@linutronix.de" , "m.felsch@pengutronix.de" , "andriy.shevchenko@linux.intel.com" , "arnd@arndb.de" , "ronald@innovation.ch" , "krzk@kernel.org" , "robh@kernel.org" , Leonard Crestez , Aisheng Dong , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-input@vger.kernel.org" , "linux-rtc@vger.kernel.org" , "linux-pm@vger.kernel.org" , "linux-watchdog@vger.kernel.org" , dl-linux-imx Subject: Re: [PATCH V3 1/7] firmware: imx: Add stubs for !CONFIG_IMX_SCU case Message-ID: <20200316100017.GM4518@piout.net> References: <20200316030744.GC17221@dragon> <20200316033447.GE17221@dragon> <20200316084056.GG4518@piout.net> <20200316090053.GH4518@piout.net> <20200316091541.GI4518@piout.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-rtc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rtc@vger.kernel.org On 16/03/2020 09:40:52+0000, Anson Huang wrote: > > Why is that an issue? If they don't have IMX_SCU selected, then the other > > SCU driver are not selected either, having stubs doesn't change that you will > > have to select at least one option. Please explain what is the issue that is not > > solved here. > > OK, what I thought is even without IMX_SCU selected, other SCU drivers still can be > selected for build test after adding "COMPILE_TEST" to the kconfig, like below, if > without IMX_SCU API stubs, the "COMPILE_TEST" can NOT be added to SCU drivers > to enable build test, so I think the IMX_SCU API stubs should be added? > No they shouldn't because there is not point adding COMPILE_TEST to the SCU drivers. We don't add COMPILE_TEST to all the drivers and add stubs to all the subsystems. E.g there is no point trying to compile an I2C driver if the I2C core is not enabled. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com