From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02B8BC2BB1D for ; Tue, 17 Mar 2020 19:09:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D9FFE2075E for ; Tue, 17 Mar 2020 19:09:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726730AbgCQTJV (ORCPT ); Tue, 17 Mar 2020 15:09:21 -0400 Received: from mail.v3.sk ([167.172.186.51]:46710 "EHLO shell.v3.sk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726388AbgCQTJV (ORCPT ); Tue, 17 Mar 2020 15:09:21 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by zimbra.v3.sk (Postfix) with ESMTP id 2340FE021B; Tue, 17 Mar 2020 19:09:38 +0000 (UTC) Received: from shell.v3.sk ([127.0.0.1]) by localhost (zimbra.v3.sk [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id DLLls_Mq1N8K; Tue, 17 Mar 2020 19:09:36 +0000 (UTC) Received: from localhost (localhost.localdomain [127.0.0.1]) by zimbra.v3.sk (Postfix) with ESMTP id 44473E0116; Tue, 17 Mar 2020 19:09:36 +0000 (UTC) X-Virus-Scanned: amavisd-new at zimbra.v3.sk Received: from shell.v3.sk ([127.0.0.1]) by localhost (zimbra.v3.sk [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id vjvflx8zMQmd; Tue, 17 Mar 2020 19:09:36 +0000 (UTC) Received: from localhost (unknown [109.183.109.54]) by zimbra.v3.sk (Postfix) with ESMTPSA id C22C4DFFBE; Tue, 17 Mar 2020 19:09:35 +0000 (UTC) Date: Tue, 17 Mar 2020 20:09:13 +0100 From: Lubomir Rintel To: Andrew Lunn Cc: Rob Herring , Linus Walleij , Bartosz Golaszewski , Thomas Gleixner , Jason Cooper , Marc Zyngier , Mauro Carvalho Chehab , Ulf Hansson , Kishon Vijay Abraham I , Alessandro Zummo , Alexandre Belloni , Greg Kroah-Hartman , Mark Brown , Daniel Lezcano , Gregory Clement , Daniel Mack , Haojian Zhuang , Robert Jarzmik , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-i2c@vger.kernel.org, linux-media@vger.kernel.org, linux-mmc@vger.kernel.org, linux-rtc@vger.kernel.org, linux-serial@vger.kernel.org, linux-spi@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [PATCH 13/28] dt-bindings: serial: move Marvell compatible string to 8250 binding doc Message-ID: <20200317190913.GA24359@furthur.local> References: <20200317093922.20785-1-lkundrak@v3.sk> <20200317093922.20785-14-lkundrak@v3.sk> <20200317134805.GO24270@lunn.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200317134805.GO24270@lunn.ch> Sender: linux-rtc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rtc@vger.kernel.org On Tue, Mar 17, 2020 at 02:48:05PM +0100, Andrew Lunn wrote: > On Tue, Mar 17, 2020 at 10:39:07AM +0100, Lubomir Rintel wrote: > > These ports are compatible with NS8250 and handled by the same driver. > > Get rid of the extra document that fails to document the properties that > > are actually supported. > > Hi Lubmir > > This is needs a bit closer examination. By the PXA maintainers. It > appears there are two serial drivers, the 8250 and a PXA specific > driver. Well, for "mrvl,mmp-uart", there are three: SERIAL_OF_PLATFORM, SERIAL_8250_PXA and SERIAL_PXA: drivers/tty/serial/8250/8250_of.c: { .compatible = "mrvl,mmp-uart", drivers/tty/serial/8250/8250_pxa.c: { .compatible = "mrvl,mmp-uart", }, drivers/tty/serial/pxa.c: { .compatible = "mrvl,mmp-uart", }, For that matter, the hardware is also compatible with intel,xscale-uart and the mrvl,mmp-uart compatible string is perhaps entirely unnecessary. I guess the story is somewhat similar for mrvl,pxa-uart; I can not verify though. I suppose SERIAL_PXA is not really needed at this point and if support for mrvl,pxa-uart was added to SERIAL_OF_PLATFORM, then SERIAL_8250_PXA would only be useful for platforms that don't use DT and the DT bits could be stripped from it eventually. That is -- if PXA maintainers agree, of course. > Andrew Regards Lubo