From: Andreas Kemnade <andreas@kemnade.info>
To: Lee Jones <lee.jones@linaro.org>
Cc: robh+dt@kernel.org, mark.rutland@arm.com, a.zummo@towertech.it,
alexandre.belloni@bootlin.com, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org,
stefan@agner.ch, b.galvani@gmail.com, phh@phh.me,
letux-kernel@openphoenux.org, knaack.h@gmx.de, lars@metafoo.de,
pmeerw@pmeerw.net, linux-iio@vger.kernel.org, jic23@kernel.org
Subject: Re: [PATCH RESEND v6 2/7] mfd: rn5t618: add IRQ support
Date: Thu, 19 Mar 2020 18:22:46 +0100 [thread overview]
Message-ID: <20200319182246.27d4809b@kemnade.info> (raw)
In-Reply-To: <20200319161149.GB5477@dell>
[-- Attachment #1: Type: text/plain, Size: 842 bytes --]
On Thu, 19 Mar 2020 16:11:49 +0000
Lee Jones <lee.jones@linaro.org> wrote:
> On Fri, 13 Mar 2020, Andreas Kemnade wrote:
[...]
I agree to the other comments.
> > + if (priv->irq > 0) {
>
> There are already have checks in rn5t618_irq_init().
>
> Just call it regardless.
>
> > + if (rn5t618_irq_init(priv))
>
> If this returns an error, you should return that error from .probe().
>
Hmm, that would be a regression. Current users do not specify an interrupt
in the devicetree yet, so the MFD driver would stop working on these devices
completely.
Therefore I think we should keep the existing functionality if there is no
IRQ specified in the devicetree and ignore the error. The new subdevices
are checking the IRQ availability and give error messages and have
reduced functionality.
Regards,
Andreas
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-03-19 17:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-13 6:45 [PATCH RESEND v6 0/7] mfd: rn5t618: Add RTC/ADC support Andreas Kemnade
2020-03-13 6:45 ` [PATCH RESEND v6 1/7] dt-bindings: mfd: rn5t618: Document optional property interrupts Andreas Kemnade
2020-03-13 6:45 ` [PATCH RESEND v6 2/7] mfd: rn5t618: add IRQ support Andreas Kemnade
2020-03-19 16:11 ` Lee Jones
2020-03-19 17:22 ` Andreas Kemnade [this message]
2020-03-19 22:40 ` Andreas Kemnade
2020-03-13 6:45 ` [PATCH RESEND v6 3/7] mfd: rn5t618: add RTC related registers Andreas Kemnade
2020-03-13 6:45 ` [PATCH RESEND v6 4/7] mfd: rn5t618: add more subdevices Andreas Kemnade
2020-03-13 6:45 ` [PATCH RESEND v6 5/7] rtc: rc5t619: add Ricoh RC5T619 RTC driver Andreas Kemnade
2020-03-13 6:45 ` [PATCH RESEND v6 6/7] iio: adc: rn5t618: Add ADC driver for RN5T618/RC5T619 Andreas Kemnade
2020-03-13 6:45 ` [PATCH RESEND v6 7/7] mfd: rn5t618: cleanup i2c_device_id Andreas Kemnade
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200319182246.27d4809b@kemnade.info \
--to=andreas@kemnade.info \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=b.galvani@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=lee.jones@linaro.org \
--cc=letux-kernel@openphoenux.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=phh@phh.me \
--cc=pmeerw@pmeerw.net \
--cc=robh+dt@kernel.org \
--cc=stefan@agner.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).