From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32ADEC1975A for ; Sun, 22 Mar 2020 21:11:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0A9FD206F8 for ; Sun, 22 Mar 2020 21:11:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726765AbgCVVLl (ORCPT ); Sun, 22 Mar 2020 17:11:41 -0400 Received: from relay2-d.mail.gandi.net ([217.70.183.194]:65089 "EHLO relay2-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726741AbgCVVLl (ORCPT ); Sun, 22 Mar 2020 17:11:41 -0400 X-Originating-IP: 86.202.105.35 Received: from localhost (lfbn-lyo-1-9-35.w86-202.abo.wanadoo.fr [86.202.105.35]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 78CFA40002; Sun, 22 Mar 2020 21:11:39 +0000 (UTC) Date: Sun, 22 Mar 2020 22:11:39 +0100 From: Alexandre Belloni To: Anson Huang Cc: a.zummo@towertech.it, linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org, Linux-imx@nxp.com Subject: Re: [PATCH] rtc: mxc: Use devm_add_action_or_reset() for calls to clk_disable_unprepare() Message-ID: <20200322211139.GC221863@piout.net> References: <1584349785-27042-1-git-send-email-Anson.Huang@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1584349785-27042-1-git-send-email-Anson.Huang@nxp.com> Sender: linux-rtc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rtc@vger.kernel.org On 16/03/2020 17:09:45+0800, Anson Huang wrote: > Use devm_add_action_or_reset() for calls to clk_disable_unprepare(), > which can simplify the error handling, and .remove callback can be dropped. > > Signed-off-by: Anson Huang > --- > drivers/rtc/rtc-mxc.c | 46 +++++++++++++++++++--------------------------- > 1 file changed, 19 insertions(+), 27 deletions(-) > Applied, thanks. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com