* [PATCH -next] rtc: fsl-ftm-alarm: remove set but not used variable 'np'
@ 2020-03-24 7:03 YueHaibing
2020-03-25 1:50 ` Peng Ma
0 siblings, 1 reply; 2+ messages in thread
From: YueHaibing @ 2020-03-24 7:03 UTC (permalink / raw)
To: a.zummo, alexandre.belloni; +Cc: linux-rtc, linux-kernel, peng.ma, YueHaibing
drivers/rtc/rtc-fsl-ftm-alarm.c: In function 'ftm_rtc_probe':
drivers/rtc/rtc-fsl-ftm-alarm.c:246:22: warning: unused variable 'np' [-Wunused-variable]
struct device_node *np = pdev->dev.of_node;
^~
commit cd49b579e705 ("rtc: fsl-ftm-alarm: enable acpi support")
left behind this, remove it.
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/rtc/rtc-fsl-ftm-alarm.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/rtc/rtc-fsl-ftm-alarm.c b/drivers/rtc/rtc-fsl-ftm-alarm.c
index c572044ff06e..0f4142b35f38 100644
--- a/drivers/rtc/rtc-fsl-ftm-alarm.c
+++ b/drivers/rtc/rtc-fsl-ftm-alarm.c
@@ -243,7 +243,6 @@ static const struct rtc_class_ops ftm_rtc_ops = {
static int ftm_rtc_probe(struct platform_device *pdev)
{
- struct device_node *np = pdev->dev.of_node;
int irq;
int ret;
struct ftm_rtc *rtc;
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* RE: [PATCH -next] rtc: fsl-ftm-alarm: remove set but not used variable 'np'
2020-03-24 7:03 [PATCH -next] rtc: fsl-ftm-alarm: remove set but not used variable 'np' YueHaibing
@ 2020-03-25 1:50 ` Peng Ma
0 siblings, 0 replies; 2+ messages in thread
From: Peng Ma @ 2020-03-25 1:50 UTC (permalink / raw)
To: YueHaibing, a.zummo, alexandre.belloni; +Cc: linux-rtc, linux-kernel
>-----Original Message-----
>From: YueHaibing <yuehaibing@huawei.com>
>Sent: 2020年3月24日 15:04
>To: a.zummo@towertech.it; alexandre.belloni@bootlin.com
>Cc: linux-rtc@vger.kernel.org; linux-kernel@vger.kernel.org; Peng Ma
><peng.ma@nxp.com>; YueHaibing <yuehaibing@huawei.com>
>Subject: [PATCH -next] rtc: fsl-ftm-alarm: remove set but not used variable 'np'
>
>drivers/rtc/rtc-fsl-ftm-alarm.c: In function 'ftm_rtc_probe':
>drivers/rtc/rtc-fsl-ftm-alarm.c:246:22: warning: unused variable 'np'
>[-Wunused-variable]
> struct device_node *np = pdev->dev.of_node;
> ^~
>commit cd49b579e705 ("rtc: fsl-ftm-alarm: enable acpi support") left behind
>this, remove it.
>
>Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>---
> drivers/rtc/rtc-fsl-ftm-alarm.c | 1 -
> 1 file changed, 1 deletion(-)
>
>diff --git a/drivers/rtc/rtc-fsl-ftm-alarm.c b/drivers/rtc/rtc-fsl-ftm-alarm.c index
>c572044ff06e..0f4142b35f38 100644
>--- a/drivers/rtc/rtc-fsl-ftm-alarm.c
>+++ b/drivers/rtc/rtc-fsl-ftm-alarm.c
>@@ -243,7 +243,6 @@ static const struct rtc_class_ops ftm_rtc_ops = {
>
> static int ftm_rtc_probe(struct platform_device *pdev) {
>- struct device_node *np = pdev->dev.of_node;
[Peng Ma] Hi, HaiBing,
Thanks for your patch, this patch has already in upstream(https://lore.kernel.org/patchwork/patch/1214014/)
Best Regards,
Peng
> int irq;
> int ret;
> struct ftm_rtc *rtc;
>--
>2.17.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-03-25 1:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-24 7:03 [PATCH -next] rtc: fsl-ftm-alarm: remove set but not used variable 'np' YueHaibing
2020-03-25 1:50 ` Peng Ma
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).