From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9A54C54EEB for ; Tue, 24 Mar 2020 18:07:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D069E20719 for ; Tue, 24 Mar 2020 18:07:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727665AbgCXSHO (ORCPT ); Tue, 24 Mar 2020 14:07:14 -0400 Received: from relay6-d.mail.gandi.net ([217.70.183.198]:33159 "EHLO relay6-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727611AbgCXSHO (ORCPT ); Tue, 24 Mar 2020 14:07:14 -0400 X-Originating-IP: 86.202.105.35 Received: from localhost (lfbn-lyo-1-9-35.w86-202.abo.wanadoo.fr [86.202.105.35]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id 77F59C000B; Tue, 24 Mar 2020 18:07:09 +0000 (UTC) Date: Tue, 24 Mar 2020 19:07:09 +0100 From: Alexandre Belloni To: Sergey.Semin@baikalelectronics.ru Cc: Alessandro Zummo , Rob Herring , Mark Rutland , Serge Semin , Alexey Malahov , Thomas Bogendoerfer , Paul Burton , Ralf Baechle , Daniel Lezcano , Thomas Gleixner , Arnd Bergmann , Andy Shevchenko , devicetree@vger.kernel.org, linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/6] dt-bindings: rtc: Convert snps,dw-apb-timer to DT schema Message-ID: <20200324180709.GO5504@piout.net> References: <20200306125622.839ED80307C4@mail.baikalelectronics.ru> <20200324174325.14213-1-Sergey.Semin@baikalelectronics.ru> <20200324174325.14213-2-Sergey.Semin@baikalelectronics.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200324174325.14213-2-Sergey.Semin@baikalelectronics.ru> Sender: linux-rtc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rtc@vger.kernel.org Hi, On 24/03/2020 20:43:20+0300, Sergey.Semin@baikalelectronics.ru wrote: > From: Serge Semin > > Modern device tree bindings are supposed to be created as YAML-files > in accordance with DT schema. This commit replaces Synopsys DW Timer > legacy bare text binding with YAML file. As before the binding file > states that the corresponding dts node is supposed to be compatible > with generic DW APB Timer indicated by the "snps,dw-apb-timer" > compatible string and to provide a mandatory registers memory range, > one timer interrupt, either reference clock source or a fixed clock > rate value. It may also have an optional APB bus reference clock > phandle specified. > > Signed-off-by: Serge Semin > Cc: Alexey Malahov > Cc: Thomas Bogendoerfer > Cc: Paul Burton > Cc: Ralf Baechle > Cc: Alessandro Zummo > Cc: Alexandre Belloni > Cc: Daniel Lezcano > Cc: Thomas Gleixner > Cc: Arnd Bergmann > Cc: Andy Shevchenko > Cc: Rob Herring > Cc: Mark Rutland > Cc: devicetree@vger.kernel.org > Cc: linux-rtc@vger.kernel.org > > --- > > I have doubts that this binding file belongs to the bindings/rtc > directory seeing it's a pure timer with no rtc facilities like > days/months/years counting and alarms. What about moving it to the > "Documentation/devicetree/bindings/timer/" directory? > Exactly my reaction when seeing the patch, please move it out of bindings/rtc/ -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com