From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 199E3C2BAEE for ; Tue, 24 Mar 2020 18:20:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id ECA4A2076E for ; Tue, 24 Mar 2020 18:20:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="g9/9A+Oy" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728088AbgCXSUx (ORCPT ); Tue, 24 Mar 2020 14:20:53 -0400 Received: from mail-lf1-f65.google.com ([209.85.167.65]:46613 "EHLO mail-lf1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728047AbgCXSUw (ORCPT ); Tue, 24 Mar 2020 14:20:52 -0400 Received: by mail-lf1-f65.google.com with SMTP id q5so2203146lfb.13; Tue, 24 Mar 2020 11:20:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=vZ2grX9EdtsDCTdMZUk+KGs8dumK5Lsw3WmRUPsPmLQ=; b=g9/9A+OyX8xJITb28HO9MKB6+cdg+n52KnynJT9xR6eCDDU3Xgg0ucNRZ6fgDnzsSf LjC5k/hBDKSg6GWsUm+VdneNJMaVgFNOaGB/xKBKIVcQAmEB/xjZ/3M8YEkJeCUjmB9M GzHm4Ctk5/9bkQt7bpe1K3Qdtn/ut2kVeTk48xb7qKCqo27MV7thqXYBmvDkm4KKHvcO gC5L4Uq2D3dyC59Moj++lKKAHRqfj6o3WliVPfJ+jSG16H+L0SWaIqzGKlaBYeKcAI80 y8BGym5dGtclGStfcNoFa39gvxtFXj/Bks7ZG8EhJEZphRbld5Mf07Dy7Vz9+I35cMNF nysw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=vZ2grX9EdtsDCTdMZUk+KGs8dumK5Lsw3WmRUPsPmLQ=; b=pehOLrjkfV53m51U+DQOZoYNoMeKeReKgJEjaB3t9jGoNxW3qZ8XP1Drm5VbhEXlhZ rl7htfsT5RFtb4mrcCWWKoY6opCk5OEDW4Z1TSuV8fOqBG0ZAbTrwHPkQOOdyW+vz0ay OcP6wg66DtzNbKDPjL4hpd+qtp19iWVWishhOOY7YyN/GAp02TTmwpeCjwmLfwJR33+g rQ5gP4QvGdNbq9IpBiYEKgFVNMknlkZ+3YXHV3FkM4/6l7vqGpFk0e6BYHb8k2Ok/LUH JN3cgaPjy9mvYlGN4Db91iFvH4Ci6Z5BOBKoCQbLIy/nossX/IyS1i63avvaLwLnM4xi dPzg== X-Gm-Message-State: ANhLgQ0gHruR62C9u5uXnrbixVMW5HOAEKQ6jMI6CMBMbi+sof3M/wu3 DQIYwQ1i7hu9gn7VQyllpls= X-Google-Smtp-Source: ADFU+vtFvpq0POhOnkLU430bk6n5oSPRbp8Bisgt5nf1Ld/HAQp/Rad6pPPa6Xb4zIivCVN1cWWmVg== X-Received: by 2002:a19:6f07:: with SMTP id k7mr13886435lfc.79.1585074050889; Tue, 24 Mar 2020 11:20:50 -0700 (PDT) Received: from mobilestation ([95.79.136.110]) by smtp.gmail.com with ESMTPSA id h10sm10603614ljg.38.2020.03.24.11.20.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Mar 2020 11:20:50 -0700 (PDT) Date: Tue, 24 Mar 2020 21:20:47 +0300 From: Serge Semin To: Alexandre Belloni Cc: Sergey.Semin@baikalelectronics.ru, Alessandro Zummo , Rob Herring , Mark Rutland , Alexey Malahov , Thomas Bogendoerfer , Paul Burton , Ralf Baechle , Daniel Lezcano , Thomas Gleixner , Arnd Bergmann , Andy Shevchenko , devicetree@vger.kernel.org, linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/6] dt-bindings: rtc: Convert snps,dw-apb-timer to DT schema Message-ID: <20200324182047.iziujb7n7slqtzck@mobilestation> References: <20200306125622.839ED80307C4@mail.baikalelectronics.ru> <20200324174325.14213-1-Sergey.Semin@baikalelectronics.ru> <20200324174325.14213-2-Sergey.Semin@baikalelectronics.ru> <20200324180709.GO5504@piout.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200324180709.GO5504@piout.net> Sender: linux-rtc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rtc@vger.kernel.org Hello Alexandre On Tue, Mar 24, 2020 at 07:07:09PM +0100, Alexandre Belloni wrote: > Hi, > > On 24/03/2020 20:43:20+0300, Sergey.Semin@baikalelectronics.ru wrote: > > From: Serge Semin > > > > Modern device tree bindings are supposed to be created as YAML-files > > in accordance with DT schema. This commit replaces Synopsys DW Timer > > legacy bare text binding with YAML file. As before the binding file > > states that the corresponding dts node is supposed to be compatible > > with generic DW APB Timer indicated by the "snps,dw-apb-timer" > > compatible string and to provide a mandatory registers memory range, > > one timer interrupt, either reference clock source or a fixed clock > > rate value. It may also have an optional APB bus reference clock > > phandle specified. > > > > Signed-off-by: Serge Semin > > Cc: Alexey Malahov > > Cc: Thomas Bogendoerfer > > Cc: Paul Burton > > Cc: Ralf Baechle > > Cc: Alessandro Zummo > > Cc: Alexandre Belloni > > Cc: Daniel Lezcano > > Cc: Thomas Gleixner > > Cc: Arnd Bergmann > > Cc: Andy Shevchenko > > Cc: Rob Herring > > Cc: Mark Rutland > > Cc: devicetree@vger.kernel.org > > Cc: linux-rtc@vger.kernel.org > > > > --- > > > > I have doubts that this binding file belongs to the bindings/rtc > > directory seeing it's a pure timer with no rtc facilities like > > days/months/years counting and alarms. What about moving it to the > > "Documentation/devicetree/bindings/timer/" directory? > > > > Exactly my reaction when seeing the patch, please move it out of > bindings/rtc/ > Agreed. I am pretty sure Rob find something to be fixed and the main part of the patchset still hasn't been reviewed. So v3 will be necessary for sure. I'll move this binding out of rtc in a dedicated patch then. -Sergey P.S. For some reason your email still hasn't been delivered to my corporate email, so responding from the private one. > > -- > Alexandre Belloni, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com