From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B095CC2D0E8 for ; Fri, 27 Mar 2020 19:46:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8C02F206F1 for ; Fri, 27 Mar 2020 19:46:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585338405; bh=iJwhgOjPRNRA/IfvAQ+x6mXNFgfrtqa7SXQeCJDmlRI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=um+ThNFsjQCCHMLMAEScv47p4U358vDBC/8cD3HMyst8mcQ/XOufh8qGOIuRR9F1k Epj3JULVbssMI+1p7H+qtLrVoUt22xInfojH/+ydnFnIQgTb4bCHKDJpeGkdXwiAQH FBHjKjLf3gMgBMzJ2fuu5BSMMTGoGnvx6C1yU7IA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727611AbgC0Tql (ORCPT ); Fri, 27 Mar 2020 15:46:41 -0400 Received: from mail-io1-f65.google.com ([209.85.166.65]:36094 "EHLO mail-io1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726959AbgC0Tql (ORCPT ); Fri, 27 Mar 2020 15:46:41 -0400 Received: by mail-io1-f65.google.com with SMTP id d15so11111487iog.3; Fri, 27 Mar 2020 12:46:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=DMZEgg/zEanfnErzXv8eRtaC03idBo6feUMxPRNa2CI=; b=Ji6NlmXaRiGbcAoGWKS8DxgqY9IdVbG8EyJY8ZZ2h+33LMLkkSqa+6hlzTbqroKKTq WnNXDXzyW6YozBAT5gArw7UUHScv8IMCfSuwmZ2+iMJy1dnfMLC/tR0q+0syzSMjgAjl IFb0BUgP0mri5f9640hFkl2jdgxmaLB5xE5X0+y/953n01ELhdVbMQyps5pUY9JncNEX VcyNOcSZLFXrx3sYuVwXjemGO0KTmnsTOWQ7YdOhqfmlKos70dTCQD4F2qWW/ztcPyEJ FU41Ai+ceX8pNDKRBGh4plVuKHS70CDIbDWc+hT9XRMgho6EB+3DTFIiBhB/RF1H85nO t+lw== X-Gm-Message-State: ANhLgQ2cm6fbrWnn6OXnS1P/QFS31VoxVMBqGThhHXtnT5FWiYwAffGi LMplCopmTzL8w4hp2IH6Vw== X-Google-Smtp-Source: ADFU+vsMs7PILXWuXR0LCIYKPob3h38oQFLxMnBZAWweTfKeLxAcwIsLCG4v8a/NeEu4ifwcJ/Tomg== X-Received: by 2002:a6b:b78d:: with SMTP id h135mr286038iof.84.1585338399714; Fri, 27 Mar 2020 12:46:39 -0700 (PDT) Received: from rob-hp-laptop ([64.188.179.250]) by smtp.gmail.com with ESMTPSA id x13sm578014ilh.66.2020.03.27.12.46.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Mar 2020 12:46:39 -0700 (PDT) Received: (nullmailer pid 24552 invoked by uid 1000); Fri, 27 Mar 2020 19:46:37 -0000 Date: Fri, 27 Mar 2020 13:46:37 -0600 From: Rob Herring To: Lubomir Rintel Cc: Linus Walleij , Bartosz Golaszewski , Thomas Gleixner , Jason Cooper , Marc Zyngier , Mauro Carvalho Chehab , Ulf Hansson , Kishon Vijay Abraham I , Alessandro Zummo , Alexandre Belloni , Greg Kroah-Hartman , Mark Brown , Daniel Lezcano , Andrew Lunn , Gregory Clement , Daniel Mack , Haojian Zhuang , Robert Jarzmik , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-i2c@vger.kernel.org, linux-media@vger.kernel.org, linux-mmc@vger.kernel.org, linux-rtc@vger.kernel.org, linux-serial@vger.kernel.org, linux-spi@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [PATCH 24/28] dt-bindings: media: Convert marvell,mmp2-ccic to json-schema Message-ID: <20200327194637.GA18803@bogus> References: <20200317093922.20785-1-lkundrak@v3.sk> <20200317093922.20785-25-lkundrak@v3.sk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200317093922.20785-25-lkundrak@v3.sk> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-rtc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rtc@vger.kernel.org On Tue, Mar 17, 2020 at 10:39:18AM +0100, Lubomir Rintel wrote: > Convert the marvell,mmp2-ccic binding to DT schema format using > json-schema. > > Signed-off-by: Lubomir Rintel > --- > .../bindings/media/marvell,mmp2-ccic.txt | 50 --------- > .../bindings/media/marvell,mmp2-ccic.yaml | 102 ++++++++++++++++++ > 2 files changed, 102 insertions(+), 50 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/media/marvell,mmp2-ccic.txt > create mode 100644 Documentation/devicetree/bindings/media/marvell,mmp2-ccic.yaml > > diff --git a/Documentation/devicetree/bindings/media/marvell,mmp2-ccic.txt b/Documentation/devicetree/bindings/media/marvell,mmp2-ccic.txt > deleted file mode 100644 > index 7ec2c8c8a3b98..0000000000000 > --- a/Documentation/devicetree/bindings/media/marvell,mmp2-ccic.txt > +++ /dev/null > @@ -1,50 +0,0 @@ > -Marvell MMP2 camera host interface > - > -Required properties: > - - compatible: Should be "marvell,mmp2-ccic". > - - reg: Register base and size. > - - interrupts: The interrupt number. > - - #clock-cells: Must be 0. > - > -Optional properties: > - - clocks: Reference to the input clock as specified by > - Documentation/devicetree/bindings/clock/clock-bindings.txt. > - - clock-names: Names of the clocks used; "axi" for the AXI bus interface, > - "func" for the peripheral clock and "phy" for the parallel > - video bus interface. > - - clock-output-names: Optional clock source for sensors. Shall be "mclk". > - > -Required subnodes: > - - port: The parallel bus interface port with a single endpoint linked to > - the sensor's endpoint as described in > - Documentation/devicetree/bindings/media/video-interfaces.txt. > - > -Required endpoint properties: > - - bus-type: data bus type, <5> or <6> for Parallel or Bt.656 respectively > - - pclk-sample: pixel clock polarity > - - hsync-active: horizontal synchronization polarity (only required for > - parallel bus) > - - vsync-active: vertical synchronization polarity (only required for > - parallel bus) > - > -Example: > - > - camera0: camera@d420a000 { > - compatible = "marvell,mmp2-ccic"; > - reg = <0xd420a000 0x800>; > - interrupts = <42>; > - clocks = <&soc_clocks MMP2_CLK_CCIC0>; > - clock-names = "axi"; > - #clock-cells = <0>; > - clock-output-names = "mclk"; > - > - port { > - camera0_0: endpoint { > - remote-endpoint = <&ov7670_0>; > - bus-type = <5>; /* Parallel */ > - hsync-active = <1>; /* Active high */ > - vsync-active = <1>; /* Active high */ > - pclk-sample = <0>; /* Falling */ > - }; > - }; > - }; > diff --git a/Documentation/devicetree/bindings/media/marvell,mmp2-ccic.yaml b/Documentation/devicetree/bindings/media/marvell,mmp2-ccic.yaml > new file mode 100644 > index 0000000000000..890a3f9d0302f > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/marvell,mmp2-ccic.yaml > @@ -0,0 +1,102 @@ > +# SPDX-License-Identifier: (GPL-2.0-or-later OR BSD-2-Clause) GPL-2.0-only please. Dual license only if you have rights on the old file to do so. > +# Copyright 2019,2020 Lubomir Rintel > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/media/marvell,mmp2-ccic.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Marvell MMP2 camera host interface bindings > + > +maintainers: > + - Lubomir Rintel > + > +properties: > + $nodename: > + pattern: '^camera@[a-f0-9]+$' > + > + compatible: > + const: marvell,mmp2-ccic > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + port: > + type: object > + additionalProperties: false > + > + properties: > + endpoint: Wrong indentaion. > + type: object > + additionalProperties: false > + > + # Properties described in > + # Documentation/devicetree/bindings/media/video-interfaces.txt > + properties: > + remote-endpoint: true > + hsync-active: true > + vsync-active: true > + pclk-sample: true > + bus-type: true > + > + required: > + - remote-endpoint > + > + required: > + - endpoint > + > + clocks: > + minItems: 1 > + maxItems: 3 Shouldn't really be variable for a single compatible. > + items: > + - description: AXI bus interface clock > + - description: Peripheral clock > + - description: Parallel video bus interface clock > + > + clock-names: > + minItems: 1 > + maxItems: 3 > + items: > + - const: axi > + - const: func > + - const: phy > + > + '#clock-cells': > + const: 0 > + > + clock-output-names: > + const: mclk > + > +required: > + - compatible > + - reg > + - interrupts > + - port > + > +examples: > + - | > + #include > + > + camera@d420a000 { > + compatible = "marvell,mmp2-ccic"; > + reg = <0xd420a000 0x800>; > + interrupts = <42>; > + clocks = <&soc_clocks MMP2_CLK_CCIC0>; > + clock-names = "axi"; > + #clock-cells = <0>; > + clock-output-names = "mclk"; > + > + port { > + camera0_0: endpoint { > + remote-endpoint = <&ov7670_0>; > + bus-type = <5>; /* Parallel */ > + hsync-active = <1>; /* Active high */ > + vsync-active = <1>; /* Active high */ > + pclk-sample = <0>; /* Falling */ > + }; > + }; > + }; > + > +... > -- > 2.25.1 >