From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F1F1C43331 for ; Mon, 30 Mar 2020 18:39:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1EBF82072E for ; Mon, 30 Mar 2020 18:39:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728031AbgC3SjV (ORCPT ); Mon, 30 Mar 2020 14:39:21 -0400 Received: from relay12.mail.gandi.net ([217.70.178.232]:35533 "EHLO relay12.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726017AbgC3SjV (ORCPT ); Mon, 30 Mar 2020 14:39:21 -0400 Received: from localhost (lfbn-lyo-1-9-35.w86-202.abo.wanadoo.fr [86.202.105.35]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay12.mail.gandi.net (Postfix) with ESMTPSA id 49809200002; Mon, 30 Mar 2020 18:39:17 +0000 (UTC) Date: Mon, 30 Mar 2020 20:39:17 +0200 From: Alexandre Belloni To: Chris Packham Cc: a.zummo@towertech.it, wim@linux-watchdog.org, linux@roeck-us.net, linux-rtc@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] rtc: ds1307: add support for watchdog timer on ds1388 Message-ID: <20200330183917.GG846876@piout.net> References: <20200330025500.6991-1-chris.packham@alliedtelesis.co.nz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200330025500.6991-1-chris.packham@alliedtelesis.co.nz> Sender: linux-rtc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rtc@vger.kernel.org On 30/03/2020 15:55:00+1300, Chris Packham wrote: > The DS1388 variant has watchdog timer capabilities. When using a DS1388 > and having enabled CONFIG_WATCHDOG_CORE register a watchdog device for > the DS1388. > > Signed-off-by: Chris Packham > --- > Changes in v3: > - Address review comments from Guenter. Add select WATCHDOG_CORE, remove > unnecessary wdt member, add set_timeout op, use devm_watchdog_register > Changes in v2: > - Address review comments from Alexandre, the only functional change is setting > the hundredths of seconds to 0 instead of 99. > > drivers/rtc/Kconfig | 1 + > drivers/rtc/rtc-ds1307.c | 115 +++++++++++++++++++++++++++++++++++++++ > 2 files changed, 116 insertions(+) > Applied, thanks. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com