From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Samuel Zou <zou_wei@huawei.com>
Cc: a.zummo@towertech.it, linux-rtc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] rtc: pcf8523: Use PTR_ERR_OR_ZERO() to simplify code
Date: Wed, 6 May 2020 11:34:41 +0200 [thread overview]
Message-ID: <20200506093441.GB34497@piout.net> (raw)
In-Reply-To: <1588757640-39044-1-git-send-email-zou_wei@huawei.com>
Hi,
On 06/05/2020 17:34:00+0800, Samuel Zou wrote:
> Fixes coccicheck warning:
>
> drivers/rtc/rtc-pcf8523.c:361:1-3: WARNING: PTR_ERR_OR_ZERO can be used
>
I'm not taking this change because it is useless and will have to be
revert as soon as the probe function changes (and it will).
Does it really simplifies the code? I very much doubt so.
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Samuel Zou <zou_wei@huawei.com>
> ---
> drivers/rtc/rtc-pcf8523.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/rtc/rtc-pcf8523.c b/drivers/rtc/rtc-pcf8523.c
> index 47e0f41..da8889a 100644
> --- a/drivers/rtc/rtc-pcf8523.c
> +++ b/drivers/rtc/rtc-pcf8523.c
> @@ -358,10 +358,8 @@ static int pcf8523_probe(struct i2c_client *client,
>
> rtc = devm_rtc_device_register(&client->dev, DRIVER_NAME,
> &pcf8523_rtc_ops, THIS_MODULE);
> - if (IS_ERR(rtc))
> - return PTR_ERR(rtc);
>
> - return 0;
> + return PTR_ERR_OR_ZERO(rtc);
> }
>
> static const struct i2c_device_id pcf8523_id[] = {
> --
> 2.6.2
>
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2020-05-06 9:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-06 9:34 [PATCH -next] rtc: pcf8523: Use PTR_ERR_OR_ZERO() to simplify code Samuel Zou
2020-05-06 9:34 ` Alexandre Belloni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200506093441.GB34497@piout.net \
--to=alexandre.belloni@bootlin.com \
--cc=a.zummo@towertech.it \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=zou_wei@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).