Linux-RTC Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH 1/2] rtc: goldfish: Fix return value of goldfish_rtc_probe()
@ 2020-05-23  9:56 Tiezhu Yang
  2020-05-23  9:56 ` [PATCH 2/2] rtc: mpc5121: Fix return value of mpc5121_rtc_probe() Tiezhu Yang
  2020-05-23 19:50 ` [PATCH 1/2] rtc: goldfish: Fix return value of goldfish_rtc_probe() Alexandre Belloni
  0 siblings, 2 replies; 5+ messages in thread
From: Tiezhu Yang @ 2020-05-23  9:56 UTC (permalink / raw)
  To: Alessandro Zummo, Alexandre Belloni
  Cc: linux-rtc, linux-kernel, Xuefeng Li, Tiezhu Yang

When call function devm_platform_ioremap_resource(), we should use IS_ERR()
to check the return value and return PTR_ERR() if failed.

Fixes: 89576bebbc17 ("rtc: Use devm_platform_ioremap_resource()")
Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
---
 drivers/rtc/rtc-goldfish.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/rtc/rtc-goldfish.c b/drivers/rtc/rtc-goldfish.c
index cb6b0ad..2779715 100644
--- a/drivers/rtc/rtc-goldfish.c
+++ b/drivers/rtc/rtc-goldfish.c
@@ -174,7 +174,7 @@ static int goldfish_rtc_probe(struct platform_device *pdev)
 	platform_set_drvdata(pdev, rtcdrv);
 	rtcdrv->base = devm_platform_ioremap_resource(pdev, 0);
 	if (IS_ERR(rtcdrv->base))
-		return -ENODEV;
+		return PTR_ERR(rtcdrv->base);
 
 	rtcdrv->irq = platform_get_irq(pdev, 0);
 	if (rtcdrv->irq < 0)
-- 
2.1.0


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH 2/2] rtc: mpc5121: Fix return value of mpc5121_rtc_probe()
  2020-05-23  9:56 [PATCH 1/2] rtc: goldfish: Fix return value of goldfish_rtc_probe() Tiezhu Yang
@ 2020-05-23  9:56 ` Tiezhu Yang
  2020-05-23 19:51   ` Alexandre Belloni
  2020-05-23 19:50 ` [PATCH 1/2] rtc: goldfish: Fix return value of goldfish_rtc_probe() Alexandre Belloni
  1 sibling, 1 reply; 5+ messages in thread
From: Tiezhu Yang @ 2020-05-23  9:56 UTC (permalink / raw)
  To: Alessandro Zummo, Alexandre Belloni
  Cc: linux-rtc, linux-kernel, Xuefeng Li, Tiezhu Yang

When call function devm_platform_ioremap_resource(), we should use IS_ERR()
to check the return value and return PTR_ERR() if failed.

Fixes: d53d4ae981d0 ("rtc: mpc5121: simplify probe")
Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
---
 drivers/rtc/rtc-mpc5121.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/rtc/rtc-mpc5121.c b/drivers/rtc/rtc-mpc5121.c
index 3040844..5c2ce71 100644
--- a/drivers/rtc/rtc-mpc5121.c
+++ b/drivers/rtc/rtc-mpc5121.c
@@ -316,7 +316,7 @@ static int mpc5121_rtc_probe(struct platform_device *op)
 	rtc->regs = devm_platform_ioremap_resource(op, 0);
 	if (IS_ERR(rtc->regs)) {
 		dev_err(&op->dev, "%s: couldn't map io space\n", __func__);
-		return -ENOSYS;
+		return PTR_ERR(rtc->regs);
 	}
 
 	device_init_wakeup(&op->dev, 1);
-- 
2.1.0


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/2] rtc: goldfish: Fix return value of goldfish_rtc_probe()
  2020-05-23  9:56 [PATCH 1/2] rtc: goldfish: Fix return value of goldfish_rtc_probe() Tiezhu Yang
  2020-05-23  9:56 ` [PATCH 2/2] rtc: mpc5121: Fix return value of mpc5121_rtc_probe() Tiezhu Yang
@ 2020-05-23 19:50 ` Alexandre Belloni
  2020-05-25  1:27   ` Tiezhu Yang
  1 sibling, 1 reply; 5+ messages in thread
From: Alexandre Belloni @ 2020-05-23 19:50 UTC (permalink / raw)
  To: Tiezhu Yang; +Cc: Alessandro Zummo, linux-rtc, linux-kernel, Xuefeng Li

Hi,

On 23/05/2020 17:56:21+0800, Tiezhu Yang wrote:
> When call function devm_platform_ioremap_resource(), we should use IS_ERR()
> to check the return value and return PTR_ERR() if failed.
> 
> Fixes: 89576bebbc17 ("rtc: Use devm_platform_ioremap_resource()")

This doesn't fix an issue and it was anyway not introduced by that
commit. Please correct your commit message and subject.

> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
> ---
>  drivers/rtc/rtc-goldfish.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/rtc/rtc-goldfish.c b/drivers/rtc/rtc-goldfish.c
> index cb6b0ad..2779715 100644
> --- a/drivers/rtc/rtc-goldfish.c
> +++ b/drivers/rtc/rtc-goldfish.c
> @@ -174,7 +174,7 @@ static int goldfish_rtc_probe(struct platform_device *pdev)
>  	platform_set_drvdata(pdev, rtcdrv);
>  	rtcdrv->base = devm_platform_ioremap_resource(pdev, 0);
>  	if (IS_ERR(rtcdrv->base))
> -		return -ENODEV;
> +		return PTR_ERR(rtcdrv->base);
>  
>  	rtcdrv->irq = platform_get_irq(pdev, 0);
>  	if (rtcdrv->irq < 0)
> -- 
> 2.1.0
> 

-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 2/2] rtc: mpc5121: Fix return value of mpc5121_rtc_probe()
  2020-05-23  9:56 ` [PATCH 2/2] rtc: mpc5121: Fix return value of mpc5121_rtc_probe() Tiezhu Yang
@ 2020-05-23 19:51   ` Alexandre Belloni
  0 siblings, 0 replies; 5+ messages in thread
From: Alexandre Belloni @ 2020-05-23 19:51 UTC (permalink / raw)
  To: Tiezhu Yang; +Cc: Alessandro Zummo, linux-rtc, linux-kernel, Xuefeng Li

On 23/05/2020 17:56:22+0800, Tiezhu Yang wrote:
> When call function devm_platform_ioremap_resource(), we should use IS_ERR()
> to check the return value and return PTR_ERR() if failed.
> 

Same comment here.

> Fixes: d53d4ae981d0 ("rtc: mpc5121: simplify probe")
> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
> ---
>  drivers/rtc/rtc-mpc5121.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/rtc/rtc-mpc5121.c b/drivers/rtc/rtc-mpc5121.c
> index 3040844..5c2ce71 100644
> --- a/drivers/rtc/rtc-mpc5121.c
> +++ b/drivers/rtc/rtc-mpc5121.c
> @@ -316,7 +316,7 @@ static int mpc5121_rtc_probe(struct platform_device *op)
>  	rtc->regs = devm_platform_ioremap_resource(op, 0);
>  	if (IS_ERR(rtc->regs)) {
>  		dev_err(&op->dev, "%s: couldn't map io space\n", __func__);
> -		return -ENOSYS;
> +		return PTR_ERR(rtc->regs);
>  	}
>  
>  	device_init_wakeup(&op->dev, 1);
> -- 
> 2.1.0
> 

-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/2] rtc: goldfish: Fix return value of goldfish_rtc_probe()
  2020-05-23 19:50 ` [PATCH 1/2] rtc: goldfish: Fix return value of goldfish_rtc_probe() Alexandre Belloni
@ 2020-05-25  1:27   ` Tiezhu Yang
  0 siblings, 0 replies; 5+ messages in thread
From: Tiezhu Yang @ 2020-05-25  1:27 UTC (permalink / raw)
  To: Alexandre Belloni; +Cc: Alessandro Zummo, linux-rtc, linux-kernel, Xuefeng Li

On 05/24/2020 03:50 AM, Alexandre Belloni wrote:
> Hi,
>
> On 23/05/2020 17:56:21+0800, Tiezhu Yang wrote:
>> When call function devm_platform_ioremap_resource(), we should use IS_ERR()
>> to check the return value and return PTR_ERR() if failed.
>>
>> Fixes: 89576bebbc17 ("rtc: Use devm_platform_ioremap_resource()")
> This doesn't fix an issue and it was anyway not introduced by that
> commit. Please correct your commit message and subject.

OK, thanks for your reply.

I will remove the fixes tag and use the following patch subjects:
"rtc: goldfish: Use correct return value for goldfish_rtc_probe()"
"rtc: mpc5121: Use correct return value for mpc5121_rtc_probe()"

Thanks,
Tiezhu Yang

>
>> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
>> ---
>>   drivers/rtc/rtc-goldfish.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/rtc/rtc-goldfish.c b/drivers/rtc/rtc-goldfish.c
>> index cb6b0ad..2779715 100644
>> --- a/drivers/rtc/rtc-goldfish.c
>> +++ b/drivers/rtc/rtc-goldfish.c
>> @@ -174,7 +174,7 @@ static int goldfish_rtc_probe(struct platform_device *pdev)
>>   	platform_set_drvdata(pdev, rtcdrv);
>>   	rtcdrv->base = devm_platform_ioremap_resource(pdev, 0);
>>   	if (IS_ERR(rtcdrv->base))
>> -		return -ENODEV;
>> +		return PTR_ERR(rtcdrv->base);
>>   
>>   	rtcdrv->irq = platform_get_irq(pdev, 0);
>>   	if (rtcdrv->irq < 0)
>> -- 
>> 2.1.0
>>


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, back to index

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-23  9:56 [PATCH 1/2] rtc: goldfish: Fix return value of goldfish_rtc_probe() Tiezhu Yang
2020-05-23  9:56 ` [PATCH 2/2] rtc: mpc5121: Fix return value of mpc5121_rtc_probe() Tiezhu Yang
2020-05-23 19:51   ` Alexandre Belloni
2020-05-23 19:50 ` [PATCH 1/2] rtc: goldfish: Fix return value of goldfish_rtc_probe() Alexandre Belloni
2020-05-25  1:27   ` Tiezhu Yang

Linux-RTC Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-rtc/0 linux-rtc/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-rtc linux-rtc/ https://lore.kernel.org/linux-rtc \
		linux-rtc@vger.kernel.org
	public-inbox-index linux-rtc

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-rtc


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git