* [PATCH] rtc: cleanup obsolete comment about struct rtc_class_ops
@ 2020-07-10 8:00 Misono Tomohiro
2020-07-16 11:35 ` Alexandre Belloni
0 siblings, 1 reply; 2+ messages in thread
From: Misono Tomohiro @ 2020-07-10 8:00 UTC (permalink / raw)
To: linux-rtc; +Cc: a.zummo, alexandre.belloni, misono.tomohiro
Commit ea369ea6d828 ("rtc: remove .open() and .release()") removes
open/release callback from struct rtc_class_ops.
Also commit 80d4bb515b78 ("RTC: Cleanup rtc_class_ops->irq_set_state")
and commit 696160fec162 ("RTC: Cleanup rtc_class_ops->irq_set_freq()")
removes irq callbacks.
So, just remove related comments so that readers will not be confused.
Signed-off-by: Misono Tomohiro <misono.tomohiro@jp.fujitsu.com>
---
include/linux/rtc.h | 4 ----
1 file changed, 4 deletions(-)
diff --git a/include/linux/rtc.h b/include/linux/rtc.h
index bba3db3f7efa..22d1575e4991 100644
--- a/include/linux/rtc.h
+++ b/include/linux/rtc.h
@@ -55,10 +55,6 @@ extern struct class *rtc_class;
*
* The (current) exceptions are mostly filesystem hooks:
* - the proc() hook for procfs
- * - non-ioctl() chardev hooks: open(), release()
- *
- * REVISIT those periodic irq calls *do* have ops_lock when they're
- * issued through ioctl() ...
*/
struct rtc_class_ops {
int (*ioctl)(struct device *, unsigned int, unsigned long);
--
2.21.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] rtc: cleanup obsolete comment about struct rtc_class_ops
2020-07-10 8:00 [PATCH] rtc: cleanup obsolete comment about struct rtc_class_ops Misono Tomohiro
@ 2020-07-16 11:35 ` Alexandre Belloni
0 siblings, 0 replies; 2+ messages in thread
From: Alexandre Belloni @ 2020-07-16 11:35 UTC (permalink / raw)
To: Misono Tomohiro, linux-rtc; +Cc: Alexandre Belloni, a.zummo
On Fri, 10 Jul 2020 17:00:03 +0900, Misono Tomohiro wrote:
> Commit ea369ea6d828 ("rtc: remove .open() and .release()") removes
> open/release callback from struct rtc_class_ops.
>
> Also commit 80d4bb515b78 ("RTC: Cleanup rtc_class_ops->irq_set_state")
> and commit 696160fec162 ("RTC: Cleanup rtc_class_ops->irq_set_freq()")
> removes irq callbacks.
>
> [...]
Applied, thanks!
[1/1] rtc: cleanup obsolete comment about struct rtc_class_ops
commit: a5e6f964bb2c613933de58a35ddfa306128ba004
Best regards,
--
Alexandre Belloni <alexandre.belloni@bootlin.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-07-16 11:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-10 8:00 [PATCH] rtc: cleanup obsolete comment about struct rtc_class_ops Misono Tomohiro
2020-07-16 11:35 ` Alexandre Belloni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).