linux-rtc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: "Kevin P. Fleming" <kevin+linux@km6g.us>
Cc: linux-rtc@vger.kernel.org, devicetree@vger.kernel.org,
	Alessandro Zummo <a.zummo@towertech.it>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>
Subject: Re: [PATCH 1/3 v3] dt-bindings: abx80x: Add autocal-filter property
Date: Mon, 13 Jul 2020 12:39:06 -0600	[thread overview]
Message-ID: <20200713183906.GA510880@bogus> (raw)
In-Reply-To: <20200615105113.57770-1-kevin+linux@km6g.us>

On Mon, Jun 15, 2020 at 06:51:11AM -0400, Kevin P. Fleming wrote:
> Add a property to allow control of the autocalibration filter
> capacitor.
> 
> Signed-off-by: Kevin P. Fleming <kevin+linux@km6g.us>
> Cc: Alessandro Zummo <a.zummo@towertech.it>
> Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>
> Cc: Rob Herring <robh+dt@kernel.org>
> To: linux-rtc@vger.kernel.org
> To: devicetree@vger.kernel.org
> ---
> v3: corrected whitespace
>  Documentation/devicetree/bindings/rtc/abracon,abx80x.txt | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/rtc/abracon,abx80x.txt b/Documentation/devicetree/bindings/rtc/abracon,abx80x.txt
> index 2405e35a1bc0f..1b606e33d1a83 100644
> --- a/Documentation/devicetree/bindings/rtc/abracon,abx80x.txt
> +++ b/Documentation/devicetree/bindings/rtc/abracon,abx80x.txt
> @@ -29,3 +29,11 @@ and valid to enable charging:
>   - "abracon,tc-diode": should be "standard" (0.6V) or "schottky" (0.3V)
>   - "abracon,tc-resistor": should be <0>, <3>, <6> or <11>. 0 disables the output
>                            resistor, the other values are in kOhm.
> +
> +All of the devices can have a 47pf capacitor attached to increase the
> +autocalibration accuracy of their RC oscillators. To enable or disable usage
> +of the capacitor the following property can be defined:
> +
> + - "abracon,autocal-filter": should be <0> or <1>. 0 indicates that there
> +                             is no capacitor attached, 1 indicates that there
> +                             is a capacitor attached.

What does not present mean? If you don't have a defined meaning (such 
as maintain the default/bootloader initialized setting), then make this 
boolean.

Rob

  parent reply	other threads:[~2020-07-13 18:39 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-15 10:51 [PATCH 1/3 v3] dt-bindings: abx80x: Add autocal-filter property Kevin P. Fleming
2020-06-15 10:51 ` [PATCH 2/3] rtc: abx80x: Add utility function for writing configuration key Kevin P. Fleming
2020-06-15 10:51 ` [PATCH 3/3 v3] rtc: abx80x: Add support for autocalibration filter capacitor Kevin P. Fleming
2020-07-13 18:39 ` Rob Herring [this message]
2020-07-13 22:05   ` [PATCH 1/3 v3] dt-bindings: abx80x: Add autocal-filter property Kevin P. Fleming
2020-09-15 16:16     ` Alexandre Belloni
2020-07-26 19:40   ` Alexandre Belloni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200713183906.GA510880@bogus \
    --to=robh@kernel.org \
    --cc=a.zummo@towertech.it \
    --cc=alexandre.belloni@bootlin.com \
    --cc=devicetree@vger.kernel.org \
    --cc=kevin+linux@km6g.us \
    --cc=linux-rtc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).