Linux-RTC Archive on lore.kernel.org
 help / color / Atom feed
From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Grant Feng <von81@163.com>
Cc: a.zummo@towertech.it, linux-rtc@vger.kernel.org
Subject: Re: [PATCH] rtc: interface^ 1969-12-31T23:59:59 is set as rtc_time if rtc_time is invalid in __rtc_read_time
Date: Sun, 2 Aug 2020 15:04:39 +0200
Message-ID: <20200802130439.GF3679@piout.net> (raw)
In-Reply-To: <a83510fa-54be-8dc1-8ec1-b2957346e402@163.com>

On 02/08/2020 14:51:41+0800, Grant Feng wrote:
> On 2020-08-01 21:28, Alexandre Belloni wrote:
> > On 01/08/2020 19:20:07+0800, Grant Feng wrote:
> > > 1969-12-31T23:59:59 is an error more clear than Invalid argument
> > Definitively not, 1969-12-31T23:59:59 is a valid date and should not be
> > returned when it is known the current date is not set in the RTC.
> 'rtc_valid_tm' is used to check rtc_time and 1969-12-31T23:59:59 is invalid.
> when the RTC clock is not set, some rtc devices always return '0' or almost
> random data, and different rtc devices may give different return data.
> so, I think, it's usful to return a default date when the current date is
> not set in the RTC.

You are not solving the issue you mention here. If the RTC doesn't know
whether the date/time is invalid and the core think it is valid, then
your code will not run.

> > > For example, when the RTC clock is not set, it will print a kernel
> > > error log every time someone tries to read the clock:
> > >          ~ # hwclock -r
> > >          hwclock: RTC_RD_TIME: Invalid argument
> > > 
> > > It's clear and easy to understand what happened if print
> > > 1969-12-31T23:59:59 in this situation:
> > >          ~ # hwclock -r
> > >          Wed Dec 31 23:59:59 1969  0.000000 seconds
> > > 
> > How do you know this is an error an not what is actually set on the RTC?
> 'rtc_valid_tm' will check rtc_time when someone set the RTC, the time
> should not be earlier than 1970-1-1T00:00:00. so 1969-12-31T23:59:59
> can not be actually set on the RTC.
>     When someone get
> ~ # hwclock -r
> Wed Dec 31 23:59:59 1969  0.000000 seconds
>     he knows: the RTC time doesn't match my watch, change it now.
> but still lots of people don't know what happened if they see
> ~ # hwclock -r
> hwclock: RTC_RD_TIME: Invalid argument
> 

This makes userspace checking for errors way worse. Think about it, first
userspace will need to check for an error when calling the ioctl then it
will have to check the time and consider a vlid date invalid. Seriously,
if hwclock doesn't do what you want, you can either patch it or use
another tool.

-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  reply index

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-01 11:20 [PATCH] rtc: interface:: " Grant Feng
2020-08-01 13:28 ` Alexandre Belloni
2020-08-02  6:51   ` [PATCH] rtc: interface^ " Grant Feng
2020-08-02 13:04     ` Alexandre Belloni [this message]
2020-08-02 13:35       ` Grant Feng
2020-08-03  3:07       ` Grant Feng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200802130439.GF3679@piout.net \
    --to=alexandre.belloni@bootlin.com \
    --cc=a.zummo@towertech.it \
    --cc=linux-rtc@vger.kernel.org \
    --cc=von81@163.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-RTC Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-rtc/0 linux-rtc/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-rtc linux-rtc/ https://lore.kernel.org/linux-rtc \
		linux-rtc@vger.kernel.org
	public-inbox-index linux-rtc

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-rtc


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git