From: "Jonathan Neuschäfer" <j.neuschaefer@gmx.net>
To: Andreas Kemnade <andreas@kemnade.info>
Cc: "Jonathan Neuschäfer" <j.neuschaefer@gmx.net>,
linux-kernel@vger.kernel.org, "Lee Jones" <lee.jones@linaro.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Alessandro Zummo" <a.zummo@towertech.it>,
"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
"Shawn Guo" <shawnguo@kernel.org>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
"Fabio Estevam" <festevam@gmail.com>,
"NXP Linux Team" <linux-imx@nxp.com>,
"Sam Ravnborg" <sam@ravnborg.org>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Heiko Stuebner" <heiko.stuebner@theobroma-systems.com>,
"Stephan Gerhold" <stephan@gerhold.net>,
"Lubomir Rintel" <lkundrak@v3.sk>,
"Mark Brown" <broonie@kernel.org>, allen <allen.chen@ite.com.tw>,
"Mauro Carvalho Chehab" <mchehab+huawei@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
devicetree@vger.kernel.org, linux-pwm@vger.kernel.org,
linux-rtc@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
"Heiko Stuebner" <heiko@sntech.de>,
"Josua Mayer" <josua.mayer@jm0.eu>
Subject: Re: [RFC PATCH 05/10] dt-bindings: pwm: Add bindings for PWM function in Netronix EC
Date: Mon, 24 Aug 2020 00:42:36 +0200 [thread overview]
Message-ID: <20200823224236.GD103070@latitude> (raw)
In-Reply-To: <20200621204123.6c761d98@aktux>
[-- Attachment #1: Type: text/plain, Size: 1918 bytes --]
On Sun, Jun 21, 2020 at 08:41:23PM +0200, Andreas Kemnade wrote:
> On Sun, 21 Jun 2020 00:42:16 +0200
> Jonathan Neuschäfer <j.neuschaefer@gmx.net> wrote:
>
> > The Netronix embedded controller as found in Kobo Aura and Tolino Shine
> > supports one PWM channel, which is used to control the frontlight
> > brightness on these devices.
> >
> > Known problems:
> > - `make dt_binding_check` shows the following warnings:
> > Documentation/devicetree/bindings/mfd/netronix,ntxec.example.dts:49.17-42:
> > Warning (pwms_property): /example-0/backlight:pwms: cell 2 is not a
> > phandle reference
> > Documentation/devicetree/bindings/mfd/netronix,ntxec.example.dts:49.17-42:
> > Warning (pwms_property): /example-0/backlight:pwms: Could not get
> > phandle node for (cell 2)
> >
> In the tolino sources in ./drivers/misc/ntx-misc.c I find this line
>
> if(4==gptHWCFG->m_val.bFL_PWM) {
>
> No idea what it does but I would expect to have a kind of translation to
> a dt property?
As far as I understand it, FL_PWM=4 means that there is a second PWM
channel, in order to provide different backlight colors.
I think it should be possible to simply extend the binding to list
another available PWM channel, once we add support for such hardware.
> > + ec_pwm: pwm {
> > + compatible = "netronix,ntxec-pwm";
> > + #pwm-cells = <1>;
> shouldn't that be 2?
> > + };
> > };
> > };
> > +
> > + backlight {
> > + compatible = "pwm-backlight";
> > + pwms = <&ec_pwm 0 50000>;
> since you have 2 values after the &ec_pwm
[...]
> > +properties:
> > + compatible:
> > + const: netronix,ntxec-pwm
> > +
> > + "#pwm-cells":
> > + const: 1
>
> shouln't that be 2?
Right, I'll fix that.
Thanks,
Jonathan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-08-23 22:43 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-20 22:42 [RFC PATCH 02/10] dt-bindings: Add vendor prefix for Netronix, Inc Jonathan Neuschäfer
2020-06-20 22:42 ` [RFC PATCH 03/10] dt-bindings: mfd: Add binding for Netronix's embedded controller Jonathan Neuschäfer
2020-06-20 22:42 ` [RFC PATCH 04/10] mfd: Add base driver for Netronix " Jonathan Neuschäfer
2020-06-22 10:55 ` Lee Jones
2020-06-28 8:11 ` Jonathan Neuschäfer
2020-06-27 8:17 ` Andreas Kemnade
2020-06-28 8:29 ` Jonathan Neuschäfer
2020-06-20 22:42 ` [RFC PATCH 05/10] dt-bindings: pwm: Add bindings for PWM function in Netronix EC Jonathan Neuschäfer
2020-06-21 18:41 ` Andreas Kemnade
2020-08-23 22:42 ` Jonathan Neuschäfer [this message]
2020-06-20 22:42 ` [RFC PATCH 06/10] pwm: ntxec: Add driver " Jonathan Neuschäfer
2020-06-22 8:18 ` Uwe Kleine-König
2020-07-03 16:15 ` Jonathan Neuschäfer
2020-06-20 22:42 ` [RFC PATCH 07/10] dt-bindings: rtc: Add bindings for Netronix embedded controller RTC Jonathan Neuschäfer
2020-06-21 0:02 ` Alexandre Belloni
2020-06-26 21:55 ` Andreas Kemnade
2020-07-03 17:04 ` Jonathan Neuschäfer
2020-06-20 22:42 ` [RFC PATCH 08/10] rtc: New driver for RTC in Netronix embedded controller Jonathan Neuschäfer
2020-06-21 0:11 ` Alexandre Belloni
2020-07-04 19:23 ` Jonathan Neuschäfer
2020-06-20 22:42 ` [RFC PATCH 09/10] MAINTAINERS: Add entry for " Jonathan Neuschäfer
2020-06-20 22:42 ` [RFC PATCH 10/10] ARM: dts: imx50-kobo-aura: Add " Jonathan Neuschäfer
2020-06-20 22:46 ` [RFC PATCH 02/10] dt-bindings: Add vendor prefix for Netronix, Inc Jonathan Neuschäfer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200823224236.GD103070@latitude \
--to=j.neuschaefer@gmx.net \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=allen.chen@ite.com.tw \
--cc=andreas@kemnade.info \
--cc=broonie@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=heiko.stuebner@theobroma-systems.com \
--cc=heiko@sntech.de \
--cc=josua.mayer@jm0.eu \
--cc=kernel@pengutronix.de \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=lkundrak@v3.sk \
--cc=mchehab+huawei@kernel.org \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=sam@ravnborg.org \
--cc=shawnguo@kernel.org \
--cc=stephan@gerhold.net \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).