From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Bastian Krause <bst@pengutronix.de>
Cc: linux-rtc@vger.kernel.org,
Alessandro Zummo <a.zummo@towertech.it>,
Marek Vasut <marex@denx.de>,
devicetree@vger.kernel.org, Arnaud Ebalard <arno@natisbad.org>,
Rob Herring <robh+dt@kernel.org>,
kernel@pengutronix.de
Subject: Re: [PATCH 2/3] dt-bindings: rtc: add chargeable flag for rx8130
Date: Wed, 2 Sep 2020 21:18:36 +0200 [thread overview]
Message-ID: <20200902191836.GP3204668@piout.net> (raw)
In-Reply-To: <98fa7181-3ebe-d7c3-cfac-fee841c81e15@pengutronix.de>
On 26/08/2020 10:13:04+0200, Bastian Krause wrote:
> >> Are you okay with that?
> >>
> >
> > I agree boolean should be avoided in RTC drivers because we need a way
> > to express "don't change this value".
>
> Alright.
>
> >> Some more context:
> >>
> >> I originally tried to add a chargeable flag for rx8130. Prior to this
> >> patch, there was no need to set "trickle-diode-disable" for this,
> >> because the driver did not pass the chargeable flag to the RTC. With the
> >> patch the default would have been to charge as long as
> >> "trickle-diode-disable" is not there. So there's a change in behavior.
> >>
> >
> > Yes, IIRC, my point was simply to move the documentation for
> > aux-voltage-chargeable to the generice rtc binding documentation,
> > Documentation/devicetree/bindings/rtc/rtc.yaml
> >
> > For now, you sould keep support for trickle-diode-disable but it has to be
> > superseded by aux-voltage-chargeable if present. Is that more clear?
>
> Yes, thanks for the clarification.
>
> Should I set the deprecated flag for trickle-diode-disable in the
> dt-binding yaml?
>
That's a good idea, yes.
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2020-09-02 19:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-15 16:36 [RESEND PATCH v2 1/3] rtc: ds1307: Enable battery backup on RX8130 Bastian Krause
2020-04-15 16:37 ` [PATCH 2/3] dt-bindings: rtc: add chargeable flag for rx8130 Bastian Krause
2020-04-15 16:44 ` Uwe Kleine-König
2020-04-15 18:56 ` Alexandre Belloni
2020-08-24 11:31 ` Bastian Krause
2020-08-24 13:32 ` Bastian Krause
2020-08-25 15:32 ` Alexandre Belloni
2020-08-26 8:13 ` Bastian Krause
2020-09-02 19:18 ` Alexandre Belloni [this message]
2020-04-15 16:37 ` [PATCH 3/3] rtc: ds1307: make backup battery chargeable optionally Bastian Krause
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200902191836.GP3204668@piout.net \
--to=alexandre.belloni@bootlin.com \
--cc=a.zummo@towertech.it \
--cc=arno@natisbad.org \
--cc=bst@pengutronix.de \
--cc=devicetree@vger.kernel.org \
--cc=kernel@pengutronix.de \
--cc=linux-rtc@vger.kernel.org \
--cc=marex@denx.de \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).