From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Hsin-Hsiung Wang <hsin-hsiung.wang@mediatek.com>
Cc: Lee Jones <lee.jones@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Fei Shao <fshao@chromium.org>,
Alessandro Zummo <a.zummo@towertech.it>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Eddie Huang <eddie.huang@mediatek.com>,
Sean Wang <sean.wang@mediatek.com>,
Yuchen Huang <yuchen.huang@mediatek.com>,
Ran Bi <ran.bi@mediatek.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-rtc@vger.kernel.org, srv_heupstream@mediatek.com
Subject: Re: [PATCH v4 2/9] rtc: mt6397: refine RTC_TC_MTH
Date: Wed, 16 Dec 2020 22:49:59 +0100 [thread overview]
Message-ID: <20201216214959.GT2814589@piout.net> (raw)
In-Reply-To: <1608104827-7937-3-git-send-email-hsin-hsiung.wang@mediatek.com>
On 16/12/2020 15:47:00+0800, Hsin-Hsiung Wang wrote:
> This patch adds RTC_TC_MTH_MASK to support new chips.
>
> Signed-off-by: Yuchen Huang <yuchen.huang@mediatek.com>
> Signed-off-by: Hsin-Hsiung Wang <hsin-hsiung.wang@mediatek.com>
Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
> ---
> drivers/rtc/rtc-mt6397.c | 2 +-
> include/linux/mfd/mt6397/rtc.h | 1 +
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/rtc/rtc-mt6397.c b/drivers/rtc/rtc-mt6397.c
> index 1894aded4c85..ea6da7476a5e 100644
> --- a/drivers/rtc/rtc-mt6397.c
> +++ b/drivers/rtc/rtc-mt6397.c
> @@ -75,7 +75,7 @@ static int __mtk_rtc_read_time(struct mt6397_rtc *rtc,
> tm->tm_min = data[RTC_OFFSET_MIN];
> tm->tm_hour = data[RTC_OFFSET_HOUR];
> tm->tm_mday = data[RTC_OFFSET_DOM];
> - tm->tm_mon = data[RTC_OFFSET_MTH];
> + tm->tm_mon = data[RTC_OFFSET_MTH] & RTC_TC_MTH_MASK;
> tm->tm_year = data[RTC_OFFSET_YEAR];
>
> ret = regmap_read(rtc->regmap, rtc->addr_base + RTC_TC_SEC, sec);
> diff --git a/include/linux/mfd/mt6397/rtc.h b/include/linux/mfd/mt6397/rtc.h
> index c3748b53bf7d..068ae1c0f0e8 100644
> --- a/include/linux/mfd/mt6397/rtc.h
> +++ b/include/linux/mfd/mt6397/rtc.h
> @@ -36,6 +36,7 @@
> #define RTC_AL_MASK_DOW BIT(4)
>
> #define RTC_TC_SEC 0x000a
> +#define RTC_TC_MTH_MASK 0x000f
> /* Min, Hour, Dom... register offset to RTC_TC_SEC */
> #define RTC_OFFSET_SEC 0
> #define RTC_OFFSET_MIN 1
> --
> 2.18.0
>
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2020-12-16 21:51 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-16 7:46 [PATCH v4 0/9] Add Support for MediaTek PMIC MT6359 Hsin-Hsiung Wang
2020-12-16 7:46 ` [PATCH v4 1/9] mfd: mt6358: refine interrupt code Hsin-Hsiung Wang
2020-12-16 7:47 ` [PATCH v4 2/9] rtc: mt6397: refine RTC_TC_MTH Hsin-Hsiung Wang
2020-12-16 21:49 ` Alexandre Belloni [this message]
2020-12-16 7:47 ` [PATCH v4 3/9] dt-bindings: mfd: Add compatible for the MediaTek MT6359 PMIC Hsin-Hsiung Wang
2020-12-17 19:28 ` Rob Herring
2020-12-18 2:04 ` Hsin-hsiung Wang
2020-12-16 7:47 ` [PATCH v4 4/9] dt-bindings: regulator: Add document for MT6359 regulator Hsin-Hsiung Wang
2020-12-16 14:03 ` Rob Herring
2020-12-16 7:47 ` [PATCH v4 5/9] mfd: Add support for the MediaTek MT6359 PMIC Hsin-Hsiung Wang
2021-01-20 19:42 ` Matthias Brugger
2020-12-16 7:47 ` [PATCH v4 6/9] regulator: mt6359: Add support for MT6359 regulator Hsin-Hsiung Wang
2020-12-16 7:47 ` [PATCH v4 7/9] regulator: mt6359: Set the enable time for LDOs Hsin-Hsiung Wang
2021-01-18 13:14 ` Mark Brown
2020-12-16 7:47 ` [PATCH v4 8/9] regulator: mt6359: Add support for MT6359P regulator Hsin-Hsiung Wang
2020-12-16 7:47 ` [PATCH v4 9/9] arm64: dts: mt6359: add PMIC MT6359 related nodes Hsin-Hsiung Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201216214959.GT2814589@piout.net \
--to=alexandre.belloni@bootlin.com \
--cc=a.zummo@towertech.it \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=eddie.huang@mediatek.com \
--cc=fshao@chromium.org \
--cc=hsin-hsiung.wang@mediatek.com \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-rtc@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=ran.bi@mediatek.com \
--cc=robh+dt@kernel.org \
--cc=sean.wang@mediatek.com \
--cc=srv_heupstream@mediatek.com \
--cc=yuchen.huang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).