From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: "Jonathan Neuschäfer" <j.neuschaefer@gmx.net>
Cc: linux-kernel@vger.kernel.org,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Heiko Stuebner <heiko@sntech.de>,
linux-pwm@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>,
Thierry Reding <thierry.reding@gmail.com>,
Fabio Estevam <festevam@gmail.com>,
linux-rtc@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
Sam Ravnborg <sam@ravnborg.org>, Daniel Palmer <daniel@0x0f.com>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Andreas Kemnade <andreas@kemnade.info>,
NXP Linux Team <linux-imx@nxp.com>,
devicetree@vger.kernel.org, Stephan Gerhold <stephan@gerhold.net>,
allen <allen.chen@ite.com.tw>,
Sascha Hauer <s.hauer@pengutronix.de>,
Lubomir Rintel <lkundrak@v3.sk>, Rob Herring <robh+dt@kernel.org>,
Lee Jones <lee.jones@linaro.org>,
linux-arm-kernel@lists.infradead.org,
Alessandro Zummo <a.zummo@towertech.it>,
Mark Brown <broonie@kernel.org>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Heiko Stuebner <heiko.stuebner@theobroma-systems.com>,
Josua Mayer <josua.mayer@jm0.eu>, Shawn Guo <shawnguo@kernel.org>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH v7 4/7] pwm: ntxec: Add driver for PWM function in Netronix EC
Date: Mon, 11 Jan 2021 10:13:10 +0100 [thread overview]
Message-ID: <20210111091310.ok47s7yvk5ngs4q7@pengutronix.de> (raw)
In-Reply-To: <20210109180220.121511-5-j.neuschaefer@gmx.net>
[-- Attachment #1: Type: text/plain, Size: 711 bytes --]
Hello,
On Sat, Jan 09, 2021 at 07:02:17PM +0100, Jonathan Neuschäfer wrote:
> The Netronix EC provides a PWM output which is used for the backlight
> on some ebook readers. This patches adds a driver for the PWM output.
>
> The .get_state callback is not implemented, because the PWM state can't
> be read back from the hardware.
There is only very little I would have done differently (only indention
which is too minor to make a fuss), so:
Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Thanks for your work
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-01-11 9:14 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-09 18:02 [PATCH v7 0/7] Netronix embedded controller driver for Kobo and Tolino ebook readers Jonathan Neuschäfer
2021-01-09 18:02 ` [PATCH v7 1/7] dt-bindings: Add vendor prefix for Netronix, Inc Jonathan Neuschäfer
2021-01-09 18:02 ` [PATCH v7 2/7] dt-bindings: mfd: Add binding for Netronix embedded controller Jonathan Neuschäfer
2021-01-09 18:02 ` [PATCH v7 3/7] mfd: Add base driver " Jonathan Neuschäfer
2021-01-12 19:36 ` Andreas Kemnade
2021-01-13 8:03 ` Lee Jones
2021-01-14 18:56 ` Jonathan Neuschäfer
2021-01-09 18:02 ` [PATCH v7 4/7] pwm: ntxec: Add driver for PWM function in Netronix EC Jonathan Neuschäfer
2021-01-11 9:13 ` Uwe Kleine-König [this message]
2021-01-11 12:53 ` Thierry Reding
2021-01-11 16:42 ` Lee Jones
2021-01-12 19:39 ` Andreas Kemnade
2021-01-13 22:46 ` Andreas Kemnade
2021-01-14 22:31 ` Jonathan Neuschäfer
2021-01-09 18:02 ` [PATCH v7 5/7] rtc: New driver for RTC in Netronix embedded controller Jonathan Neuschäfer
2021-01-09 18:02 ` [PATCH v7 6/7] MAINTAINERS: Add entry for " Jonathan Neuschäfer
2021-01-09 18:02 ` [PATCH v7 7/7] ARM: dts: imx50-kobo-aura: Add " Jonathan Neuschäfer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210111091310.ok47s7yvk5ngs4q7@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=allen.chen@ite.com.tw \
--cc=andreas@kemnade.info \
--cc=andy.shevchenko@gmail.com \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=daniel@0x0f.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=heiko.stuebner@theobroma-systems.com \
--cc=heiko@sntech.de \
--cc=j.neuschaefer@gmx.net \
--cc=josua.mayer@jm0.eu \
--cc=kernel@pengutronix.de \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=lkundrak@v3.sk \
--cc=mchehab+huawei@kernel.org \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=sam@ravnborg.org \
--cc=shawnguo@kernel.org \
--cc=stephan@gerhold.net \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).