From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5A81C43381 for ; Wed, 27 Jan 2021 13:20:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 909E0207A3 for ; Wed, 27 Jan 2021 13:20:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238193AbhA0NUf (ORCPT ); Wed, 27 Jan 2021 08:20:35 -0500 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:54043 "EHLO relay9-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233033AbhA0NTS (ORCPT ); Wed, 27 Jan 2021 08:19:18 -0500 X-Originating-IP: 86.202.109.140 Received: from localhost (lfbn-lyo-1-13-140.w86-202.abo.wanadoo.fr [86.202.109.140]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 3F273FF802; Wed, 27 Jan 2021 13:18:22 +0000 (UTC) Date: Wed, 27 Jan 2021 14:18:21 +0100 From: Alexandre Belloni To: Rasmus Villemoes Cc: Alessandro Zummo , Rob Herring , linux-rtc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] dt-bindings: rtc: pcf2127: update bindings Message-ID: <20210127131821.GH1196852@piout.net> References: <20201219013418.3474461-1-alexandre.belloni@bootlin.com> <20210126224835.GE1196852@piout.net> <0a8fd7f3-58c1-9e20-bcfa-9872b3dc3550@prevas.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0a8fd7f3-58c1-9e20-bcfa-9872b3dc3550@prevas.dk> Precedence: bulk List-ID: X-Mailing-List: linux-rtc@vger.kernel.org On 27/01/2021 14:07:59+0100, Rasmus Villemoes wrote: > On 26/01/2021 23.48, Alexandre Belloni wrote: > > On 21/12/2020 22:17:54+0100, Rasmus Villemoes wrote: > >> On 19/12/2020 02.34, Alexandre Belloni wrote: > >>> pcf2127, pcf2129 and pca2129 support start-year and reset-source. > >>> > >> > >> No, the 2129 variant doesn't even have a reset output pin. Not sure if > >> there's any way to reflect that, and it probably doesn't matter, since > >> nobody's going to add the reset-source property to a 2129 node. But the > >> commit message is a bit misleading. > >> > > > > Actually no, the INT pin can be used as a reset, the pcf/pca2129 > > can be used as a watchdog and so it may need the reset-source property. > > Unless I'm missing something, that would require some rather creative > extra circuitry: The interrupt pin is kept low until the appropriate bit > in the rtc is cleared, so if that is routed directly to a reset pin on > the SOC, the SOC would be kept in reset indefinitely. > You mean inverting the level of INT? I don't think this is creative or complicated... And anyway, INT# is active low, like RST# so if the SoC has an RST# input, this should just work. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com