From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC202C433E0 for ; Tue, 16 Mar 2021 12:13:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A406064EED for ; Tue, 16 Mar 2021 12:13:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230219AbhCPMNA (ORCPT ); Tue, 16 Mar 2021 08:13:00 -0400 Received: from gecko.sbs.de ([194.138.37.40]:35590 "EHLO gecko.sbs.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229524AbhCPMM1 (ORCPT ); Tue, 16 Mar 2021 08:12:27 -0400 X-Greylist: delayed 552 seconds by postgrey-1.27 at vger.kernel.org; Tue, 16 Mar 2021 08:12:27 EDT Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by gecko.sbs.de (8.15.2/8.15.2) with ESMTPS id 12GC2r5I026410 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 16 Mar 2021 13:02:53 +0100 Received: from md1za8fc.ad001.siemens.net ([139.25.68.191]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id 12GBqqrv026921; Tue, 16 Mar 2021 12:52:52 +0100 Date: Tue, 16 Mar 2021 12:52:51 +0100 From: Henning Schild To: Andy Shevchenko Cc: Claudius Heine , johannes hahn , Alessandro Zummo , Alexandre Belloni , "open list:REAL TIME CLOCK (RTC) SUBSYSTEM" , open list , werner zeh , "martin mantel" , val krutov Subject: Re: [PATCH v3 1/1] rtc: rx6110: add ACPI bindings to I2C Message-ID: <20210316125251.64484b3a@md1za8fc.ad001.siemens.net> In-Reply-To: References: <20210316100805.2630481-2-ch@denx.de> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-rtc@vger.kernel.org Am Tue, 16 Mar 2021 13:30:36 +0200 schrieb Andy Shevchenko : > On Tue, Mar 16, 2021 at 11:08:05AM +0100, Claudius Heine wrote: > > From: Johannes Hahn > > > > This allows the RX6110 driver to be automatically assigned to the > > right device on the I2C bus. > > Thanks for all effort! > Reviewed-by: Andy Shevchenko > after addressing the below comments. > > > Signed-off-by: Johannes Hahn > > Signed-off-by: Claudius Heine > > > Signed-off-by: Henning Schild Claudius, just remove that. I guess just add yours and mention authors in the code if they should receive some recognition. Henning > I think this is somehow confusing. Either you need to add > Co-developed-by of the corresponding people, or remove SoB (because > of From line), i.o.w seems like Co-dB tag is needed for Johannes or > you and something should be done with Henning's SoB. > > > --- > > drivers/rtc/rtc-rx6110.c | 12 ++++++++++++ > > 1 file changed, 12 insertions(+) > > > > diff --git a/drivers/rtc/rtc-rx6110.c b/drivers/rtc/rtc-rx6110.c > > index 79161d4c6ce4..29bd697f82cb 100644 > > --- a/drivers/rtc/rtc-rx6110.c > > +++ b/drivers/rtc/rtc-rx6110.c > > @@ -13,6 +13,7 @@ > > #include > > #include > > #include > > > +#include > > Usually it's not needed if you leave IDs always to be compiled. > Instead mod_devicetable.h is used. But it's all up to you and > maintainer. > > > #include > > #include > > #include > > @@ -447,6 +448,14 @@ static int rx6110_i2c_probe(struct i2c_client > > *client, return rx6110_probe(rx6110, &client->dev); > > } > > > > +#ifdef CONFIG_ACPI > > +static const struct acpi_device_id rx6110_i2c_acpi_match[] = { > > + { "SECC6110", }, > > + { }, > > +}; > > +MODULE_DEVICE_TABLE(acpi, rx6110_i2c_acpi_match); > > +#endif > > + > > static const struct i2c_device_id rx6110_i2c_id[] = { > > { "rx6110", 0 }, > > { } > > @@ -456,6 +465,9 @@ MODULE_DEVICE_TABLE(i2c, rx6110_i2c_id); > > static struct i2c_driver rx6110_i2c_driver = { > > .driver = { > > .name = RX6110_DRIVER_NAME, > > +#ifdef CONFIG_ACPI > > This is implied by the stub ACPI_PTR() macro for ACPI=n case. > I.o.w drop this ugly and redundant ifdeffery. > > > + .acpi_match_table = > > ACPI_PTR(rx6110_i2c_acpi_match), +#endif > > }, > > .probe = rx6110_i2c_probe, > > .id_table = rx6110_i2c_id, > > -- > > 2.30.1 > > >