linux-rtc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Liam Beguin <liambeguin@gmail.com>
To: liambeguin@gmail.com, a.zummo@towertech.it,
	alexandre.belloni@bootlin.com, panfilov.artyom@gmail.com
Cc: linux-rtc@vger.kernel.org
Subject: [PATCH v2 0/3] add alarm support for the rtc-ab-eoz9
Date: Wed,  7 Apr 2021 22:40:25 -0400	[thread overview]
Message-ID: <20210408024028.3526564-1-liambeguin@gmail.com> (raw)

From: Liam Beguin <lvb@xiphos.com>

Add alarm support for the rtc-ab-eoz9.

The board used to test this series has the interrupt line of the RTC
connected to a circuit controlling the power of the board.

An event on the interrupt line while the board is off will power it on.
Because of these hardware limitations, the irq handler added in this
patch wasn't fully tested.

The alarm functionality was tested, with:

	$ date "2010-10-10 10:10"
	Sun Oct 10 10:10:00 UTC 2010
	$ /usr/sbin/rtcwake -u -d /dev/rtc0  -s20 --mode off
	[ ... ]
	$ # power on after 20 seconds

Changes since v1:
- drop abeoz9_reset_validity in abeoz9_rtc_set_alarm since we don't know
  for sure the time is set properly at that time.
- keep the RTC_FEATURE_ALARM change in a separate patch for easy
  backport

Liam Beguin (3):
  rtc: ab-eoz9: set regmap max_register
  rtc: ab-eoz9: add alarm support
  rtc: ab-eoz9: make use of RTC_FEATURE_ALARM

 drivers/rtc/rtc-ab-eoz9.c | 135 +++++++++++++++++++++++++++++++++++++-
 1 file changed, 134 insertions(+), 1 deletion(-)

Range-diff against v1:
1:  7809a783807d < -:  ------------ rtc: ab-eoz9: make use of regmap local variable
2:  3b5d3fa74715 = 1:  d2c1ffa4007b rtc: ab-eoz9: set regmap max_register
3:  0a19ed90d4cc ! 2:  ac36be1f5f61 rtc: ab-eoz9: add alarm support
    @@ drivers/rtc/rtc-ab-eoz9.c: static int abeoz9_rtc_set_time(struct device *dev, st
     +	if (ret)
     +		return ret;
     +
    -+	ret = abeoz9_reset_validity(data->regmap);
    -+	if (ret)
    -+		return ret;
    -+
     +	return abeoz9_rtc_alarm_irq_enable(dev, alarm->enabled);
     +}
     +
4:  7004d40f2f36 = 3:  1987bef12ee8 rtc: ab-eoz9: make use of RTC_FEATURE_ALARM

base-commit: e49d033bddf5b565044e2abe4241353959bc9120
-- 
2.30.1.489.g328c10930387


             reply	other threads:[~2021-04-08  2:40 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-08  2:40 Liam Beguin [this message]
2021-04-08  2:40 ` [PATCH v2 1/3] rtc: ab-eoz9: set regmap max_register Liam Beguin
2021-04-08  2:40 ` [PATCH v2 2/3] rtc: ab-eoz9: add alarm support Liam Beguin
2021-04-08  2:40 ` [PATCH v2 3/3] rtc: ab-eoz9: make use of RTC_FEATURE_ALARM Liam Beguin
2021-04-16 22:09 ` [PATCH v2 0/3] add alarm support for the rtc-ab-eoz9 Alexandre Belloni
2021-04-16 22:29   ` Liam Beguin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210408024028.3526564-1-liambeguin@gmail.com \
    --to=liambeguin@gmail.com \
    --cc=a.zummo@towertech.it \
    --cc=alexandre.belloni@bootlin.com \
    --cc=linux-rtc@vger.kernel.org \
    --cc=panfilov.artyom@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).