From: Martin Fuzzey <martin.fuzzey@flowbird.group>
To: Biwen Li <biwen.li@nxp.com>,
a.zummo@towertech.it, alexandre.belloni@bootlin.com,
robh+dt@kernel.org, mark.rutland@arm.com, leoyang.li@nxp.com
Cc: linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, Martin Fuzzey <mfuzzey@parkeon.com>
Subject: Re: [v3,1/2] dt-bindings: rtc: pcf85263/pcf85363: add some properties
Date: Tue, 3 Sep 2019 11:37:01 +0200 [thread overview]
Message-ID: <2374870a-a728-b046-9ec6-bd7773411f50@flowbird.group> (raw)
In-Reply-To: <20190903061853.19793-1-biwen.li@nxp.com>
On 03/09/2019 08:18, Biwen Li wrote:
> diff --git a/Documentation/devicetree/bindings/rtc/pcf85363.txt b/Documentation/devicetree/bindings/rtc/pcf85363.txt
> index 94adc1cf93d9..588f688b30d1 100644
> --- a/Documentation/devicetree/bindings/rtc/pcf85363.txt
> +++ b/Documentation/devicetree/bindings/rtc/pcf85363.txt
> @@ -8,10 +8,39 @@ Required properties:
> Optional properties:
> - interrupts: IRQ line for the RTC (not implemented).
>
> +- interrupt-output-pin: The interrupt output pin must be
> + "INTA" or "INTB", default value is "INTA"
> +
The hardware has 2 interrupt pins which can be mapped to various
interrupt sources (alarm1, alarm2, periodic, ...)
Currently the driver only supports alarm1.
It is even possible to use both pins for the same interrupt (eg if INTA
were wired to the SoC, INTB to a PMIC and both used for alarm...)
So maybe it would be better to have
alarm1-interrupt-output-pin: The interrupt output pin used for the alarm
function. Must be "INTA", "INTB" or "BOTH"
Then, if and when other types of interrupts are supported by the driver
new properties could be added for them.
> +- quartz-load-femtofarads: The internal capacitor to select for the quartz:
> + PCF85263_QUARTZCAP_7pF [0]
> + PCF85263_QUARTZCAP_6pF [1]
> + PCF85263_QUARTZCAP_12p5pF [2] DEFAULT
> +
The standard DT property "quartz-load-femtofarads" takes the real
physical value in femto Farads ie values should be 7000, 6000, 12500
without defines.
> +- nxp,quartz-drive-strength: Drive strength for the quartz:
> + PCF85263_QUARTZDRIVE_100ko [0] DEFAULT
> + PCF85263_QUARTZDRIVE_60ko [1]
> + PCF85263_QUARTZDRIVE_500ko [2]
> +
Not sure about this.
Wouldn't it be better to either use a real impedence value in ohms (like
load property above, even though it is a vendor specific value) rather
than a define, or defines for "Low, Medium, High"?
Martin
next prev parent reply other threads:[~2019-09-03 9:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-03 6:18 [v3,1/2] dt-bindings: rtc: pcf85263/pcf85363: add some properties Biwen Li
2019-09-03 6:18 ` [v3,2/2] rtc: pcf85263/pcf85363: support PM, wakeup device, improve performance Biwen Li
2019-09-03 9:37 ` Martin Fuzzey [this message]
2019-09-03 17:36 ` [v3,1/2] dt-bindings: rtc: pcf85263/pcf85363: add some properties Rob Herring
2019-09-10 10:21 ` [EXT] " Biwen Li
2019-09-10 1:41 ` Biwen Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2374870a-a728-b046-9ec6-bd7773411f50@flowbird.group \
--to=martin.fuzzey@flowbird.group \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=biwen.li@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=leoyang.li@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mfuzzey@parkeon.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).