From: Randy Dunlap <rdunlap@infradead.org>
To: Alexandre Belloni <alexandre.belloni@bootlin.com>,
Alessandro Zummo <a.zummo@towertech.it>
Cc: linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] rtc: ds1374: fix RTC_DRV_DS1374_WDT dependencies
Date: Mon, 20 Jul 2020 19:39:46 -0700 [thread overview]
Message-ID: <2d322558-d60e-6da2-3434-389959d222b2@infradead.org> (raw)
In-Reply-To: <20200720075250.1019172-1-alexandre.belloni@bootlin.com>
On 7/20/20 12:52 AM, Alexandre Belloni wrote:
> It is not enough to select WATCHDOG_CORE, the watchdog part of the driver
> now also depends on WATCHDOG. This is currently the best we can do because
> alarm support and watchdog support are mutually exclusive.
>
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested
Thanks.
> ---
> drivers/rtc/Kconfig | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig
> index c25d51f35f0c..2753e0f54cc3 100644
> --- a/drivers/rtc/Kconfig
> +++ b/drivers/rtc/Kconfig
> @@ -281,8 +281,8 @@ config RTC_DRV_DS1374
>
> config RTC_DRV_DS1374_WDT
> bool "Dallas/Maxim DS1374 watchdog timer"
> - depends on RTC_DRV_DS1374
> - select WATCHDOG_CORE if WATCHDOG
> + depends on RTC_DRV_DS1374 && WATCHDOG
> + select WATCHDOG_CORE
> help
> If you say Y here you will get support for the
> watchdog timer in the Dallas Semiconductor DS1374
>
--
~Randy
prev parent reply other threads:[~2020-07-21 2:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-20 7:52 [PATCH 1/2] rtc: ds1374: fix RTC_DRV_DS1374_WDT dependencies Alexandre Belloni
2020-07-20 7:52 ` [PATCH 2/2] rtc: ds1374: remove unused define Alexandre Belloni
2020-07-21 2:39 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2d322558-d60e-6da2-3434-389959d222b2@infradead.org \
--to=rdunlap@infradead.org \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).