From: Randy Dunlap <rdunlap@infradead.org>
To: LKML <linux-kernel@vger.kernel.org>, linux-rtc@vger.kernel.org
Cc: Andrew Morton <akpm@linux-foundation.org>,
Lee Jones <lee.jones@linaro.org>,
Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
Subject: [PATCH] rtc: bd70528: add dependency to fix build errors
Date: Sun, 7 Jul 2019 09:12:46 -0700 [thread overview]
Message-ID: <420b921d-10ca-1d9a-ac46-5969a7f0e0b9@infradead.org> (raw)
From: Randy Dunlap <rdunlap@infradead.org>
Fix build errors when MFD_ROHM_BD70528=m, BD70528_WATCHDOG=m,
and RTC_DRV_BD70528=y. Fixes these build errors:
ld: drivers/rtc/rtc-bd70528.o: in function `bd70528_alm_enable':
rtc-bd70528.c:(.text+0x3a2): undefined reference to `bd70528_wdt_lock'
ld: rtc-bd70528.c:(.text+0x3f8): undefined reference to `bd70528_wdt_unlock'
ld: drivers/rtc/rtc-bd70528.o: in function `bd70528_set_rtc_based_timers':
rtc-bd70528.c:(.text+0x41c): undefined reference to `bd70528_wdt_set'
ld: drivers/rtc/rtc-bd70528.o: in function `bd70528_set_time':
rtc-bd70528.c:(.text+0x500): undefined reference to `bd70528_wdt_lock'
ld: rtc-bd70528.c:(.text+0x587): undefined reference to `bd70528_wdt_unlock'
Also add a blank line to separate the Kconfig entry from the one
above it.
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Lee Jones <lee.jones@linaro.org>
Cc: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
Cc: linux-rtc@vger.kernel.org
Cc: Andrew Morton <akpm@linux-foundation.org>
---
Found in mmotm but applies to linux-next.
drivers/rtc/Kconfig | 2 ++
1 file changed, 2 insertions(+)
--- mmotm-2019-0706-2200.orig/drivers/rtc/Kconfig
+++ mmotm-2019-0706-2200/drivers/rtc/Kconfig
@@ -498,8 +498,10 @@ config RTC_DRV_M41T80_WDT
help
If you say Y here you will get support for the
watchdog timer in the ST M41T60 and M41T80 RTC chips series.
+
config RTC_DRV_BD70528
tristate "ROHM BD70528 PMIC RTC"
+ depends on MFD_ROHM_BD70528
help
If you say Y here you will get support for the RTC
on ROHM BD70528 Power Management IC.
next reply other threads:[~2019-07-07 16:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-07 16:12 Randy Dunlap [this message]
2019-07-08 13:29 ` [PATCH] rtc: bd70528: add dependency to fix build errors Vaittinen, Matti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=420b921d-10ca-1d9a-ac46-5969a7f0e0b9@infradead.org \
--to=rdunlap@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=matti.vaittinen@fi.rohmeurope.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).