From: Marek Vasut <marex@denx.de>
To: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Cc: linux-rtc@vger.kernel.org
Subject: Re: [PATCH] rtc: abx80x: Implement procfs interface
Date: Sat, 29 Jun 2019 14:01:06 +0200 [thread overview]
Message-ID: <4fed45a0-5cd8-a57c-7b0a-217bcb13a4c7@denx.de> (raw)
In-Reply-To: <6b1b912c-4d43-dbaa-3566-c18cfac85fe3@denx.de>
On 6/23/19 3:20 PM, Marek Vasut wrote:
> On 6/23/19 2:38 PM, Alexandre Belloni wrote:
>> Hi Marek,
>>
>> On 23/06/2019 14:08:54+0200, Marek Vasut wrote:
>>> Implement procfs interface for polling battery status of the RTC
>>> via /proc/driver/rtc .
>>>
>>
>> Please don't, this interface is deprecated and doesn't work well. Use
>> RTC_VL_READ instead.
> That's already implemented, the procfs one isn't, but fine by me.
Oh, one more thing. The RTC_VL_READ only provides 1 bit of information,
the state of BLF bit (Battery low/failed IIRC). The procfs interface is
more verbose and provides explicit battery status (OK/low/exhausted). Is
there an ioctl for this too ?
--
Best regards,
Marek Vasut
prev parent reply other threads:[~2019-06-29 12:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-23 12:08 [PATCH] rtc: abx80x: Implement procfs interface Marek Vasut
2019-06-23 12:38 ` Alexandre Belloni
2019-06-23 13:20 ` Marek Vasut
2019-06-29 12:01 ` Marek Vasut [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4fed45a0-5cd8-a57c-7b0a-217bcb13a4c7@denx.de \
--to=marex@denx.de \
--cc=alexandre.belloni@free-electrons.com \
--cc=linux-rtc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).