From: "Vaittinen, Matti" <Matti.Vaittinen@fi.rohmeurope.com>
To: "bgolaszewski@baylibre.com" <bgolaszewski@baylibre.com>
Cc: "dmurphy@ti.com" <dmurphy@ti.com>,
"linux-leds@vger.kernel.org" <linux-leds@vger.kernel.org>,
"linux-rtc@vger.kernel.org" <linux-rtc@vger.kernel.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"alexandre.belloni@bootlin.com" <alexandre.belloni@bootlin.com>,
"mazziesaccount@gmail.com" <mazziesaccount@gmail.com>,
"mturquette@baylibre.com" <mturquette@baylibre.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"jacek.anaszewski@gmail.com" <jacek.anaszewski@gmail.com>,
"linus.walleij@linaro.org" <linus.walleij@linaro.org>,
"a.zummo@towertech.it" <a.zummo@towertech.it>,
"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
"pavel@ucw.cz" <pavel@ucw.cz>,
"sboyd@kernel.org" <sboyd@kernel.org>,
"broonie@kernel.org" <broonie@kernel.org>,
"lee.jones@linaro.org" <lee.jones@linaro.org>
Subject: Re: [RFC PATCH 10/13] gpio: bd71828: Initial support for ROHM BD71828 PMIC GPIOs
Date: Tue, 22 Oct 2019 13:19:37 +0000 [thread overview]
Message-ID: <5611c687e6fc86fefb750faf2f726472e22a7d57.camel@fi.rohmeurope.com> (raw)
In-Reply-To: <CAMpxmJVABg-UAzZtaQKu5ADBhi1P7CNArmstxHi5ZfdPiSKyYw@mail.gmail.com>
Hello Bartosz,
Just a short note at this point.
On Mon, 2019-10-21 at 16:36 +0200, Bartosz Golaszewski wrote:
> pon., 21 paź 2019 o 09:00 Vaittinen, Matti
> <Matti.Vaittinen@fi.rohmeurope.com> napisał(a):
> > On Thu, 2019-10-17 at 14:45 +0200, Bartosz Golaszewski wrote:
> > > czw., 17 paź 2019 o 11:53 Matti Vaittinen
> > >
> > > > +static struct platform_driver bd71828_gpio = {
> > > > + .driver = {
> > > > + .name = "bd71828-gpio"
> > > > + },
> > > > + .probe = bd71828_probe,
> > > > +};
> > > > +
> > > > +module_platform_driver(bd71828_gpio);
> > > > +
> > > > +MODULE_AUTHOR("Matti Vaittinen <
> > > > matti.vaittinen@fi.rohmeurope.com>
> > > > ");
> > > > +MODULE_DESCRIPTION("BD71828 voltage regulator driver");
> > > > +MODULE_LICENSE("GPL");
> > >
> > > Don't you need a MODULE_ALIAS() here since this is an MFD sub-
> > > module?
> >
> > I must admit I don't know the details of how module loading is
> > done. I
> > used system where modules are load by scripts. (I guess the module
> > alias could be used to allow automatic module loading [by udev?])
> >
> > Can you please educate me - If I add module aliases matching the
> > sub-
> > device name given in in MFD cell - should the sub module loading be
> > automatic when MFD driver gets probed? For some reason I didn't get
> > that working on my test bed. Or maybe I misunderstood something.
> >
>
> If the gpio module is a sub-node on the device tree than you may need
> to use a sub-compatible to get the module loaded by udev.
>
> Bart
>
> > Eg, this should be enough for GPIO sub-module to be also load:
> >
> > MFD:
> > static struct mfd_cell bd71828_mfd_cells[] = {
> > { .name = "bd71828-pmic", },
> > { .name = "bd71828-gpio", },
> > ...
> > ret = devm_mfd_add_devices(&i2c->dev, PLATFORM_DEVID_AUTO,
> > bd71828_mfd_cells,
> > ARRAY_SIZE(bd71828_mfd_cells), NULL, 0,
> > regmap_irq_get_domain(irq_data));
> >
> > GPIO driver:
> > MODULE_ALIAS("platform:bd71828-gpio");
> >
> > I had the sub-devices probed even without the MODULE_ALIAS - but
> > manual
> > loading is required. I will gladly add the alias if it should
> > enable
> > the automatic module loading.
I had some problems with my test setup. After I fixed those I was able
to test the automatic module loading. The sub-devices do not need own
compatible to be load - they only need the correct module_alias:
"platform:sub-device-name-used-in-mfd-cell". If this is added, the
module for sub-device is load when MFD cell with name matching the
alias is instantiated.
So to your original question - yes, MODULE_ALIAS() is needed for
automated loading. No compatible is required then :)
Thanks for pointing me to correct direction here! It's always nice to
learn something new!
Br,
Matti Vaittinen
next prev parent reply other threads:[~2019-10-22 13:19 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-17 9:40 [RFC PATCH 00/13] Support ROHM BD71828 PMIC Matti Vaittinen
2019-10-17 9:41 ` [RFC PATCH 01/13] mfd: bd71828: Support ROHM BD71828 PMIC - core Matti Vaittinen
2019-10-17 9:42 ` [RFC PATCH 02/13] mfd: input: bd71828: Add power-key support Matti Vaittinen
2019-10-17 9:43 ` [RFC PATCH 03/13] clk: bd718x7: Support ROHM BD71828 clk block Matti Vaittinen
2019-10-17 9:44 ` [RFC PATCH 04/13] regulator: bd718x7: Split driver to common and bd718x7 specific parts Matti Vaittinen
2019-10-17 9:44 ` [RFC PATCH 05/13] regulator: bd71828: Basic support for ROHM bd71828 PMIC regulators Matti Vaittinen
2019-10-17 9:48 ` [RFC PATCH 06/13] regulator: bd71828: Add GPIO based run-level control for regulators Matti Vaittinen
2019-10-17 9:50 ` [RFC PATCH 07/13] regulator: bd71828: enhanced run-level support Matti Vaittinen
2019-10-17 9:51 ` [RFC PATCH 08/13] regulator: bd71828: Support in-kernel APIs to change run-level Matti Vaittinen
2019-10-17 9:52 ` [RFC PATCH 09/13] mfd: rtc: support RTC on ROHM BD71828 with BD70528 driver Matti Vaittinen
2019-10-17 10:12 ` Alexandre Belloni
2019-10-17 10:36 ` Vaittinen, Matti
2019-10-17 10:48 ` Alexandre Belloni
2019-10-21 5:29 ` Vaittinen, Matti
2019-10-23 10:27 ` Vaittinen, Matti
2019-10-29 13:50 ` Alexandre Belloni
2019-10-29 14:08 ` Vaittinen, Matti
2019-10-17 9:53 ` [RFC PATCH 10/13] gpio: bd71828: Initial support for ROHM BD71828 PMIC GPIOs Matti Vaittinen
2019-10-17 12:45 ` Bartosz Golaszewski
2019-10-21 7:00 ` Vaittinen, Matti
2019-10-21 14:36 ` Bartosz Golaszewski
2019-10-21 14:56 ` Vaittinen, Matti
2019-10-22 13:19 ` Vaittinen, Matti [this message]
2019-10-17 9:53 ` [RFC PATCH 11/13] led: bd71828: Support LED outputs on ROHM BD71828 PMIC Matti Vaittinen
2019-10-17 14:04 ` Dan Murphy
2019-10-17 14:28 ` Alexandre Belloni
2019-10-21 8:00 ` Vaittinen, Matti
2019-10-21 19:09 ` Jacek Anaszewski
2019-10-22 12:40 ` Vaittinen, Matti
2019-10-22 17:40 ` Jacek Anaszewski
2019-10-23 8:37 ` Vaittinen, Matti
2019-10-23 21:59 ` Jacek Anaszewski
2019-10-24 8:15 ` Vaittinen, Matti
2019-10-24 22:04 ` Jacek Anaszewski
2019-10-25 7:07 ` Vaittinen, Matti
2019-10-25 13:24 ` Rob Herring
2019-10-25 14:37 ` Vaittinen, Matti
2019-10-25 15:47 ` Rob Herring
2019-10-29 13:29 ` Vaittinen, Matti
2019-10-17 9:55 ` [RFC PATCH 12/13] dt-bindings: mfd: Document ROHM BD71282 bindings Matti Vaittinen
2019-10-17 14:18 ` Dan Murphy
2019-10-21 8:03 ` Vaittinen, Matti
2019-10-17 9:57 ` [RFC PATCH 13/13] dt-bindings: regulator: Document ROHM BD71282 regulator bindings Matti Vaittinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5611c687e6fc86fefb750faf2f726472e22a7d57.camel@fi.rohmeurope.com \
--to=matti.vaittinen@fi.rohmeurope.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=bgolaszewski@baylibre.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=jacek.anaszewski@gmail.com \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mazziesaccount@gmail.com \
--cc=mturquette@baylibre.com \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).