From: Tiezhu Yang <yangtiezhu@loongson.cn>
To: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: Alessandro Zummo <a.zummo@towertech.it>,
linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org,
Xuefeng Li <lixuefeng@loongson.cn>
Subject: Re: [PATCH 1/2] rtc: goldfish: Fix return value of goldfish_rtc_probe()
Date: Mon, 25 May 2020 09:27:38 +0800 [thread overview]
Message-ID: <58568aec-d964-bae4-b837-106747a034a4@loongson.cn> (raw)
In-Reply-To: <20200523195006.GB3429@piout.net>
On 05/24/2020 03:50 AM, Alexandre Belloni wrote:
> Hi,
>
> On 23/05/2020 17:56:21+0800, Tiezhu Yang wrote:
>> When call function devm_platform_ioremap_resource(), we should use IS_ERR()
>> to check the return value and return PTR_ERR() if failed.
>>
>> Fixes: 89576bebbc17 ("rtc: Use devm_platform_ioremap_resource()")
> This doesn't fix an issue and it was anyway not introduced by that
> commit. Please correct your commit message and subject.
OK, thanks for your reply.
I will remove the fixes tag and use the following patch subjects:
"rtc: goldfish: Use correct return value for goldfish_rtc_probe()"
"rtc: mpc5121: Use correct return value for mpc5121_rtc_probe()"
Thanks,
Tiezhu Yang
>
>> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
>> ---
>> drivers/rtc/rtc-goldfish.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/rtc/rtc-goldfish.c b/drivers/rtc/rtc-goldfish.c
>> index cb6b0ad..2779715 100644
>> --- a/drivers/rtc/rtc-goldfish.c
>> +++ b/drivers/rtc/rtc-goldfish.c
>> @@ -174,7 +174,7 @@ static int goldfish_rtc_probe(struct platform_device *pdev)
>> platform_set_drvdata(pdev, rtcdrv);
>> rtcdrv->base = devm_platform_ioremap_resource(pdev, 0);
>> if (IS_ERR(rtcdrv->base))
>> - return -ENODEV;
>> + return PTR_ERR(rtcdrv->base);
>>
>> rtcdrv->irq = platform_get_irq(pdev, 0);
>> if (rtcdrv->irq < 0)
>> --
>> 2.1.0
>>
prev parent reply other threads:[~2020-05-25 1:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-23 9:56 [PATCH 1/2] rtc: goldfish: Fix return value of goldfish_rtc_probe() Tiezhu Yang
2020-05-23 9:56 ` [PATCH 2/2] rtc: mpc5121: Fix return value of mpc5121_rtc_probe() Tiezhu Yang
2020-05-23 19:51 ` Alexandre Belloni
2020-05-23 19:50 ` [PATCH 1/2] rtc: goldfish: Fix return value of goldfish_rtc_probe() Alexandre Belloni
2020-05-25 1:27 ` Tiezhu Yang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58568aec-d964-bae4-b837-106747a034a4@loongson.cn \
--to=yangtiezhu@loongson.cn \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=lixuefeng@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).