From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EED14C636D6 for ; Thu, 23 Feb 2023 15:22:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234296AbjBWPWt (ORCPT ); Thu, 23 Feb 2023 10:22:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33988 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234202AbjBWPWs (ORCPT ); Thu, 23 Feb 2023 10:22:48 -0500 Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [IPv6:2a00:1450:4864:20::32f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B967F57D38 for ; Thu, 23 Feb 2023 07:22:46 -0800 (PST) Received: by mail-wm1-x32f.google.com with SMTP id d41-20020a05600c4c2900b003e9e066550fso3118993wmp.4 for ; Thu, 23 Feb 2023 07:22:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=5Cwbrse9pZAxCvyGzfZ4RNvckcnZylA2fH9zi27S+QI=; b=NOruivWnthOebJDqC4gaJPdYD62QJ09c3qsdWWT1Bhwb1c4svUr8/bYY8ZmlqHVwst uXphoclV4DxL49Vu703Cpn82F0jT40Z73ayldO4wq1OA9AYkTQ0d/exfG7pZK33Oglon xG10fGCoFhKNeMEvggIC1YTE/i71GROkyL4kmxaVT0nlwRPOjfDS1PR9s+I8XZPiHTnV mHQaa+AZjdRvWf+Fa1C4A8r6tM9NKIZSMtUs9sygQou/pt8VIOlcsdb8dQ/9nFsJ8ncx aCFNzb5KOPija2h2uB1a3dgS0lqz0ef3WTlDWuAyv+6aUb0jcsjUejallakvNjDsHGuF Evfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5Cwbrse9pZAxCvyGzfZ4RNvckcnZylA2fH9zi27S+QI=; b=MSB8vky3snYwNPS0mNWgJilexyC/bjhx0PNUpyd1alyZqW8x1SMB5ue3qXx1rknJCD A+esNqWH6+7XhL89VC6fGRXmbM2rMJO9b07nCu2YYa0G/xBUJAT7rKVoJgpzag4HWS7V uPG1FkkmR/MNKVC54jvYxuUlGW8rg3yE7J4DmTIDOGnikA4k4gi5FQmwF/xG6M+/O/HT SR9XMt1bR+bl3MeFzmA9zW5s6yzxY2ITnRCXOtmxXLNo/UviYylpQ0SUSv0uozZZcug/ kkNv8x6uXHNpR99sxV45Y9NNJFxN1j1VViiswNDDAJNuq5gkTZFnZyaJaiCctdYMeeAD 2Bvw== X-Gm-Message-State: AO0yUKWDn0lJxsr8VNx27AQaQ11DJjpedk/DS8bEkIw9gqFfOPnhmqRe klDfZD82bQNd7rRN907hBG6DEQ== X-Google-Smtp-Source: AK7set++SQwiX6anztrdTaCyOV4SjeN7vFMHvuxS//fEFz98O8goJ7YLvAky+T/G+gUg5Pn95Q+aDA== X-Received: by 2002:a05:600c:2b46:b0:3e0:14a:697a with SMTP id e6-20020a05600c2b4600b003e0014a697amr10024326wmf.6.1677165765179; Thu, 23 Feb 2023 07:22:45 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id l3-20020a1ced03000000b003e0015c8618sm4984762wmh.6.2023.02.23.07.22.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Feb 2023 07:22:44 -0800 (PST) Message-ID: <6aa802c2-fe0d-f830-dc4d-3a139003e137@linaro.org> Date: Thu, 23 Feb 2023 16:22:43 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH 2/2] rtc: s5m: Drop S5M8763 support Content-Language: en-US To: David Virag , Alexandre Belloni , Lee Jones Cc: Alessandro Zummo , linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-rtc@vger.kernel.org References: <20230131183008.4451-1-virag.david003@gmail.com> <20230131183008.4451-3-virag.david003@gmail.com> <3a8e24921b9b47834199a7ca78af4d22ed370586.camel@gmail.com> From: Krzysztof Kozlowski In-Reply-To: <3a8e24921b9b47834199a7ca78af4d22ed370586.camel@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-rtc@vger.kernel.org On 23/02/2023 16:11, David Virag wrote: > On Thu, 2023-02-23 at 16:03 +0100, Alexandre Belloni wrote: >> On 23/02/2023 14:18:10+0000, Lee Jones wrote: >>> On Thu, 23 Feb 2023, Lee Jones wrote: >>> >>>> On Tue, 31 Jan 2023, David Virag wrote: >>>> >>>>> The S5M8763 MFD has no device tree compatible, and since board >>>>> file >>>>> support for it was removed, there's no way to use this MFD. >>>>> After >>>>> removing the remaining code for it from the MFD driver, also >>>>> remove >>>>> support for it in the s5m RTC driver, and all remaining >>>>> references to >>>>> it. >>>>> >>>>> Signed-off-by: David Virag >>>>> --- >>>>>  drivers/rtc/rtc-s5m.c            | 82 ++---------------------- >>>>> -------- >>>> >>>>>  include/linux/mfd/samsung/core.h |  1 - >>>>>  include/linux/mfd/samsung/irq.h  | 50 ------------------- >>>> >>>> Acked-by: Lee Jones >>> >>> Actually, looks like this should probably go in via MFD, so I need >>> an >>> RTC Ack. >> >> There were comments on 1/2 so I was expecting a v2. >> >> > > Krzysztof commented there about the removal of an enum value that's > actually removed in 2/2 since it would break the RTC driver if it was > removed in 1/2. He realised that and corrected himself. No need for v2 > AFAIK, unless something else is found. Yep. I also gave review tags for both of these. Best regards, Krzysztof