linux-rtc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2] dt-bindings: rtc: mcp795: move to trivial-rtc
@ 2023-09-06 12:48 Javier Carrasco
  2023-09-06 13:21 ` Krzysztof Kozlowski
  0 siblings, 1 reply; 2+ messages in thread
From: Javier Carrasco @ 2023-09-06 12:48 UTC (permalink / raw)
  To: Alessandro Zummo, Alexandre Belloni, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Emil Bartczak, Josef Gajdusek
  Cc: linux-rtc, devicetree, linux-kernel, Javier Carrasco

The current mcp795 bindings in text format do not support validation and
are missing the optional interrupt property that is currently supported.

Adding the missing property makes the bindings identical to the existing
trivial-rtc bindings.

Add maxim,mcp795 to the trivial-rtc bindings and delete current .txt
bindings

Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
---
The current mcp795 bindings in text format do not support validation and
are missing the optional interrupt property that is currently supported.

Adding the missing property makes the bindings identical to the existing
trivial-rtc bindings.

Add maxim,mcp795 to the trivial-rtc bindings and delete current .txt
bindings
---
Changes in v2:
- Move mcp795 to trivial-rtc
- Link to v1: https://lore.kernel.org/r/20230906-topic-rtc_mcp795_yaml-v1-1-de75c377b5b0@gmail.com
---
 Documentation/devicetree/bindings/rtc/maxim,mcp795.txt | 11 -----------
 Documentation/devicetree/bindings/rtc/trivial-rtc.yaml |  2 ++
 2 files changed, 2 insertions(+), 11 deletions(-)

diff --git a/Documentation/devicetree/bindings/rtc/maxim,mcp795.txt b/Documentation/devicetree/bindings/rtc/maxim,mcp795.txt
deleted file mode 100644
index a59fdd8c236d..000000000000
--- a/Documentation/devicetree/bindings/rtc/maxim,mcp795.txt
+++ /dev/null
@@ -1,11 +0,0 @@
-* Maxim MCP795		SPI Serial Real-Time Clock
-
-Required properties:
-- compatible: Should contain "maxim,mcp795".
-- reg: SPI address for chip
-
-Example:
-	mcp795: rtc@0 {
-		compatible = "maxim,mcp795";
-		reg = <0>;
-	};
diff --git a/Documentation/devicetree/bindings/rtc/trivial-rtc.yaml b/Documentation/devicetree/bindings/rtc/trivial-rtc.yaml
index 9af77f21bb7f..ae4792bbde92 100644
--- a/Documentation/devicetree/bindings/rtc/trivial-rtc.yaml
+++ b/Documentation/devicetree/bindings/rtc/trivial-rtc.yaml
@@ -49,6 +49,8 @@ properties:
       - isil,isl12022
       # Real Time Clock Module with I2C-Bus
       - microcrystal,rv3029
+      # SPI-BUS INTERFACE REAL TIME CLOCK MODULE
+      - maxim,mcp795
       # Real Time Clock
       - microcrystal,rv8523
       # Real-time Clock Module

---
base-commit: 2dde18cd1d8fac735875f2e4987f11817cc0bc2c
change-id: 20230906-topic-rtc_mcp795_yaml-11058e99ddad

Best regards,
-- 
Javier Carrasco <javier.carrasco.cruz@gmail.com>


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v2] dt-bindings: rtc: mcp795: move to trivial-rtc
  2023-09-06 12:48 [PATCH v2] dt-bindings: rtc: mcp795: move to trivial-rtc Javier Carrasco
@ 2023-09-06 13:21 ` Krzysztof Kozlowski
  0 siblings, 0 replies; 2+ messages in thread
From: Krzysztof Kozlowski @ 2023-09-06 13:21 UTC (permalink / raw)
  To: Javier Carrasco, Alessandro Zummo, Alexandre Belloni,
	Rob Herring, Krzysztof Kozlowski, Conor Dooley, Emil Bartczak,
	Josef Gajdusek
  Cc: linux-rtc, devicetree, linux-kernel

On 06/09/2023 14:48, Javier Carrasco wrote:
> The current mcp795 bindings in text format do not support validation and
> are missing the optional interrupt property that is currently supported.
> 
> Adding the missing property makes the bindings identical to the existing
> trivial-rtc bindings.
> 
> Add maxim,mcp795 to the trivial-rtc bindings and delete current .txt
> bindings
> 
> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
> ---
> The current mcp795 bindings in text format do not support validation and
> are missing the optional interrupt property that is currently supported.
> 
> Adding the missing property makes the bindings identical to the existing
> trivial-rtc bindings.
> 
> Add maxim,mcp795 to the trivial-rtc bindings and delete current .txt
> bindings
> ---
> Changes in v2:
> - Move mcp795 to trivial-rtc
> - Link to v1: https://lore.kernel.org/r/20230906-topic-rtc_mcp795_yaml-v1-1-de75c377b5b0@gmail.com
> ---
>  Documentation/devicetree/bindings/rtc/maxim,mcp795.txt | 11 -----------
>  Documentation/devicetree/bindings/rtc/trivial-rtc.yaml |  2 ++
>  2 files changed, 2 insertions(+), 11 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/rtc/maxim,mcp795.txt b/Documentation/devicetree/bindings/rtc/maxim,mcp795.txt
> deleted file mode 100644
> index a59fdd8c236d..000000000000
> --- a/Documentation/devicetree/bindings/rtc/maxim,mcp795.txt
> +++ /dev/null
> @@ -1,11 +0,0 @@
> -* Maxim MCP795		SPI Serial Real-Time Clock
> -
> -Required properties:
> -- compatible: Should contain "maxim,mcp795".
> -- reg: SPI address for chip
> -
> -Example:
> -	mcp795: rtc@0 {
> -		compatible = "maxim,mcp795";
> -		reg = <0>;
> -	};
> diff --git a/Documentation/devicetree/bindings/rtc/trivial-rtc.yaml b/Documentation/devicetree/bindings/rtc/trivial-rtc.yaml
> index 9af77f21bb7f..ae4792bbde92 100644
> --- a/Documentation/devicetree/bindings/rtc/trivial-rtc.yaml
> +++ b/Documentation/devicetree/bindings/rtc/trivial-rtc.yaml
> @@ -49,6 +49,8 @@ properties:
>        - isil,isl12022
>        # Real Time Clock Module with I2C-Bus
>        - microcrystal,rv3029
> +      # SPI-BUS INTERFACE REAL TIME CLOCK MODULE
> +      - maxim,mcp795

Does not look ordered by compatible.

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-09-06 13:21 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-09-06 12:48 [PATCH v2] dt-bindings: rtc: mcp795: move to trivial-rtc Javier Carrasco
2023-09-06 13:21 ` Krzysztof Kozlowski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).