From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5BD40C47404 for ; Fri, 11 Oct 2019 07:11:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 296552084C for ; Fri, 11 Oct 2019 07:11:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=xilinx.onmicrosoft.com header.i=@xilinx.onmicrosoft.com header.b="DRXxquEG" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726982AbfJKHK7 (ORCPT ); Fri, 11 Oct 2019 03:10:59 -0400 Received: from mail-eopbgr740088.outbound.protection.outlook.com ([40.107.74.88]:18441 "EHLO NAM01-BN3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726679AbfJKHK7 (ORCPT ); Fri, 11 Oct 2019 03:10:59 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HooJ6QOQrFToxxHPx/kVAdIHiCjPhztO1xBJUuaaBCTGLLj2lkRb3voIleOMfmIFo8RSWqk+hy+C2dYCmZREVT0Eh+9uUnuadi+k0Io7F1XcNU+dvateeJx5jHV7QpCpVnTHCMoS7JbNrLJRRlyy3eqCWnNtnbvu3+Cu9Da6nBNB7eJXm5FeXF77+QTLLmoqJwasXWBN+9GSFOkbBN8TYpj6iNxediWmrjcVXqh1MOWK50NzT+B5ceRQh8INPh66LPzog6qfI/BU6BYP/R5xVEDlPYg/g8pvTFAgqCer55l6R95KV3ENxwaTHC5JliX3o54UENAW0GCBUmo4SMD4ZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DHtnbO5/y6uxrzj/vDghbmPaTUnSC7YAq3PVgaE5y5o=; b=BWHFPJM5q5j+1dncC8xbBTFIX3HGhLi4If/XqYmBewScWLEXGl4yKFftWV8H0O7qdFJRowOPvGwnC8e885dI/SumTzCI0dbvFczRvUCYgzvgy9MyLgUOX6aLIwts/AYV2QC0tgS8oYIreLbHsB/Lt+HPX8vElvBirZ8H78ppWc0K5vBm7meGm9oQCEGiwEm+m7WUDUpu1MC25PVNAe6SGNQiJDweII/2vYxO+yOnFcUH+ElNw7ENvoKZK3bH5JysrB5p4YY8exMf3ZXwI4qTWnwRtZCU3pBgrfL0FQ5wqxCga5SpysXjNTnSldyjKW9+M64LGzSvpW0svDPFEVYYZA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.60.83) smtp.rcpttodomain=bootlin.com smtp.mailfrom=xilinx.com; dmarc=bestguesspass action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DHtnbO5/y6uxrzj/vDghbmPaTUnSC7YAq3PVgaE5y5o=; b=DRXxquEG3i/heJN0DlDzLbx3bsCbai84ekVNM04LjUrV3Y5IwjrePetG4NcquxxzZTH+guWq4qEXQHQqSY/RtanXLGEpIO/5fi7NP7tjtxPdyBN39+Jt9NlNf6VLdECvfLTEmhLEfJQdlrnP9HiWRJcbGEUNMOi7lXJm3sCQeMU= Received: from BN6PR02CA0085.namprd02.prod.outlook.com (2603:10b6:405:60::26) by BYAPR02MB5813.namprd02.prod.outlook.com (2603:10b6:a03:11d::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2347.21; Fri, 11 Oct 2019 07:10:41 +0000 Received: from CY1NAM02FT050.eop-nam02.prod.protection.outlook.com (2a01:111:f400:7e45::201) by BN6PR02CA0085.outlook.office365.com (2603:10b6:405:60::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.2347.16 via Frontend Transport; Fri, 11 Oct 2019 07:10:41 +0000 Authentication-Results: spf=pass (sender IP is 149.199.60.83) smtp.mailfrom=xilinx.com; bootlin.com; dkim=none (message not signed) header.d=none;bootlin.com; dmarc=bestguesspass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.60.83 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.60.83; helo=xsj-pvapsmtpgw01; Received: from xsj-pvapsmtpgw01 (149.199.60.83) by CY1NAM02FT050.mail.protection.outlook.com (10.152.75.65) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.2347.16 via Frontend Transport; Fri, 11 Oct 2019 07:10:40 +0000 Received: from unknown-38-66.xilinx.com ([149.199.38.66] helo=xsj-pvapsmtp01) by xsj-pvapsmtpgw01 with esmtp (Exim 4.63) (envelope-from ) id 1iIp4S-0003UL-14; Fri, 11 Oct 2019 00:10:40 -0700 Received: from [127.0.0.1] (helo=localhost) by xsj-pvapsmtp01 with smtp (Exim 4.63) (envelope-from ) id 1iIp4M-0004uC-UG; Fri, 11 Oct 2019 00:10:34 -0700 Received: from xsj-pvapsmtp01 (xsj-mail.xilinx.com [149.199.38.66]) by xsj-smtp-dlp1.xlnx.xilinx.com (8.13.8/8.13.1) with ESMTP id x9B7AMxt006862; Fri, 11 Oct 2019 00:10:22 -0700 Received: from [172.30.17.123] by xsj-pvapsmtp01 with esmtp (Exim 4.63) (envelope-from ) id 1iIp4A-0004dj-0i; Fri, 11 Oct 2019 00:10:22 -0700 Subject: Re: [PATCH] rtc: xilinx: Fix calibval variable type To: Alexandre Belloni , Michal Simek Cc: linux-kernel@vger.kernel.org, monstr@monstr.eu, git@xilinx.com, Srinivas Goud , Alessandro Zummo , linux-arm-kernel@lists.infradead.org, linux-rtc@vger.kernel.org References: <20765c4c27aa92c75426b82fd2815ebef6471492.1570544738.git.michal.simek@xilinx.com> <20191008143121.GX4254@piout.net> From: Michal Simek Message-ID: <7db2fe90-915e-8b6b-e43d-b16487937f5d@xilinx.com> Date: Fri, 11 Oct 2019 09:10:19 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20191008143121.GX4254@piout.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.2.0.1013-23620.005 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:149.199.60.83;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(4636009)(376002)(136003)(396003)(346002)(39860400002)(189003)(199004)(31696002)(230700001)(486006)(36386004)(14444005)(47776003)(44832011)(126002)(65956001)(65806001)(2486003)(23676004)(8676002)(426003)(9786002)(76176011)(81166006)(81156014)(186003)(336012)(6666004)(356004)(8936002)(305945005)(26005)(54906003)(110136005)(36756003)(4326008)(58126008)(106002)(316002)(5660300002)(478600001)(70586007)(31686004)(2906002)(446003)(11346002)(229853002)(2616005)(476003)(6246003)(50466002)(70206006);DIR:OUT;SFP:1101;SCL:1;SRVR:BYAPR02MB5813;H:xsj-pvapsmtpgw01;FPR:;SPF:Pass;LANG:en;PTR:unknown-60-83.xilinx.com;MX:1;A:1; X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b9006990-eefc-4723-c99a-08d74e1a1fd8 X-MS-TrafficTypeDiagnostic: BYAPR02MB5813: X-LD-Processed: 657af505-d5df-48d0-8300-c31994686c5c,ExtAddr X-Microsoft-Antispam-PRVS: X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-Oob-TLC-OOBClassifiers: OLM:7691; X-Forefront-PRVS: 0187F3EA14 X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: q5EmxbM273WuqMhUCJMeU3RtQ8JOTmCNaRXCWDkJA0kxzaW6nO4tkY11RQ+xbdAHipTz1HMZ8vdbxX95ssPCnXIU/gRR1dnYUeejOfkxBT2pmd0QrgOBCGuwGzMamb0IYaLagHs35R/BUyh38P6gWImvrNP6ZcciYZoSLxSpiXaPWO+PrxbecmEO6F4oq704kwl06+5qsn3ojfCsdDZ5VXcgBMZI6yKFHXaN8RH+l4/BPMQDQSwtHiz2jdh7FHEnA829MZ9hBtg1A8g+H3/Ty+3+nPLD2LD1Ywj4PpHJ90oEttQRlL3xD2GiXUFWo3/NWAiawBxRynr56ucwMPf4P3VcpOlTOvT3MLDdFqhdZ2CcQ6yHpfodSpJRisXq67rnv0vdSmP7QZCg92SjBwIyQwpT9hTRN/SKY78uRWqOGWg= X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2019 07:10:40.5232 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b9006990-eefc-4723-c99a-08d74e1a1fd8 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.60.83];Helo=[xsj-pvapsmtpgw01] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR02MB5813 Sender: linux-rtc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rtc@vger.kernel.org On 08. 10. 19 16:31, Alexandre Belloni wrote: > Hi, > > On 08/10/2019 16:25:41+0200, Michal Simek wrote: >> From: Srinivas Goud >> >> This patch fixes the warnings reported by static code analysis. >> Updated calibval variable type to unsigned type from signed. >> >> Signed-off-by: Srinivas Goud >> Signed-off-by: Michal Simek >> --- >> >> drivers/rtc/rtc-zynqmp.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/rtc/rtc-zynqmp.c b/drivers/rtc/rtc-zynqmp.c >> index 2c762757fb54..da0dbea8def3 100644 >> --- a/drivers/rtc/rtc-zynqmp.c >> +++ b/drivers/rtc/rtc-zynqmp.c >> @@ -44,7 +44,7 @@ struct xlnx_rtc_dev { >> void __iomem *reg_base; >> int alarm_irq; >> int sec_irq; >> - int calibval; >> + unsigned int calibval; > > Note that ideally, this varialbe should be removed and replaced by > .read_offset and .set_offset callbacks so userspace can properly > recalibrate the crystal instead of relying on a static value inside the > device tree. Thanks for letting me know. We will look at it. It should be patch on the top anyway. Thanks, Michal