From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE75FC07E85 for ; Tue, 11 Dec 2018 11:54:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B961F20811 for ; Tue, 11 Dec 2018 11:54:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B961F20811 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=rjwysocki.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-rtc-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726176AbeLKLyT (ORCPT ); Tue, 11 Dec 2018 06:54:19 -0500 Received: from cloudserver094114.home.pl ([79.96.170.134]:57264 "EHLO cloudserver094114.home.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726135AbeLKLyT (ORCPT ); Tue, 11 Dec 2018 06:54:19 -0500 Received: from 79.184.252.35.ipv4.supernova.orange.pl (79.184.252.35) (HELO aspire.rjw.lan) by serwer1319399.home.pl (79.96.170.134) with SMTP (IdeaSmtpServer 0.83.183) id 9631f92aeb1ab5ac; Tue, 11 Dec 2018 12:54:16 +0100 From: "Rafael J. Wysocki" To: Andy Shevchenko Cc: Alessandro Zummo , Alexandre Belloni , linux-rtc@vger.kernel.org, Arnd Bergmann , Joe Perches , Mark Salyzyn , Geert Uytterhoeven , linux-kernel@vger.kernel.org, Rasmus Villemoes , Greg Kroah-Hartman , linux-pm@vger.kernel.org Subject: Re: [PATCH v6 20/20] PM: Switch to use %ptR Date: Tue, 11 Dec 2018 12:53:59 +0100 Message-ID: <8224399.K2TIF5fxr2@aspire.rjw.lan> In-Reply-To: <20181204212330.69515-21-andriy.shevchenko@linux.intel.com> References: <20181204212330.69515-1-andriy.shevchenko@linux.intel.com> <20181204212330.69515-21-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-rtc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rtc@vger.kernel.org On Tuesday, December 4, 2018 10:23:30 PM CET Andy Shevchenko wrote: > Use %ptR instead of open coded variant to print content of > struct rtc_time in human readable format. > > Cc: linux-pm@vger.kernel.org > Acked-by: Rafael J. Wysocki > Signed-off-by: Andy Shevchenko Do you want me to take this patch? > --- > drivers/base/power/trace.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/base/power/trace.c b/drivers/base/power/trace.c > index 1cda505d6a85..b11f47a1e819 100644 > --- a/drivers/base/power/trace.c > +++ b/drivers/base/power/trace.c > @@ -118,9 +118,7 @@ static unsigned int read_magic_time(void) > unsigned int val; > > mc146818_get_time(&time); > - pr_info("RTC time: %2d:%02d:%02d, date: %02d/%02d/%02d\n", > - time.tm_hour, time.tm_min, time.tm_sec, > - time.tm_mon + 1, time.tm_mday, time.tm_year % 100); > + pr_info("RTC time: %ptRt, date: %ptRd\n", &time, &time); > val = time.tm_year; /* 100 years */ > if (val > 100) > val -= 100; >