From: Brandon Martin <martinbv@mothictech.com>
To: Alexandre Belloni <alexandre.belloni@bootlin.com>,
linux-rtc@vger.kernel.org
Subject: Re: [PATCH 5/5] rtc: pcf85363: convert to SPDX identifier
Date: Wed, 10 Apr 2019 17:01:42 -0400 [thread overview]
Message-ID: <8e70712a-c3d5-6101-f33c-8452559038f7@mothictech.com> (raw)
In-Reply-To: <20190410205604.25262-5-alexandre.belloni@bootlin.com>
On 4/10/19 4:56 PM, Alexandre Belloni wrote:
> Use SPDX-License-Identifier instead of a verbose license text.
>
> The original text refers to version 2 so also update MODULE_LICENSE() to
> "GPL v2" instead of "GPL".
>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
> ---
> drivers/rtc/rtc-pcf85363.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/drivers/rtc/rtc-pcf85363.c b/drivers/rtc/rtc-pcf85363.c
> index afb1baacdaa7..a075e77617dc 100644
> --- a/drivers/rtc/rtc-pcf85363.c
> +++ b/drivers/rtc/rtc-pcf85363.c
> @@ -1,15 +1,10 @@
> +// SPDX-License-Identifier: GPL-2.0
> /*
> * drivers/rtc/rtc-pcf85363.c
> *
> * Driver for NXP PCF85363 real-time clock.
> *
> * Copyright (C) 2017 Eric Nelson
> - *
> - * This program is free software; you can redistribute it and/or modify
> - * it under the terms of the GNU General Public License version 2 as
> - * published by the Free Software Foundation.
> - *
> - * Based loosely on rtc-8583 by Russell King, Wolfram Sang and Juergen Beisert
> */
> #include <linux/module.h>
> #include <linux/i2c.h>
>
Looks like you did not update MODULE_LICENSE as stated in the comment?
--
Brandon Martin
Mothic Technologies
317-565-1357 x7000
next prev parent reply other threads:[~2019-04-10 21:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-10 20:56 [PATCH 1/5] rtc: pcf85363: remove unused struct pcf85363 member Alexandre Belloni
2019-04-10 20:56 ` [PATCH 2/5] rtc: pcf85363: set range Alexandre Belloni
2019-04-10 20:56 ` [PATCH 3/5] rtc: pcf85363: remove bogus i2c functionality check Alexandre Belloni
2019-04-10 20:56 ` [PATCH 4/5] rtc: pcf85363: remove useless forward declaration Alexandre Belloni
2019-04-10 20:56 ` [PATCH 5/5] rtc: pcf85363: convert to SPDX identifier Alexandre Belloni
2019-04-10 21:01 ` Brandon Martin [this message]
2019-04-10 21:05 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e70712a-c3d5-6101-f33c-8452559038f7@mothictech.com \
--to=martinbv@mothictech.com \
--cc=alexandre.belloni@bootlin.com \
--cc=linux-rtc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).