Linux-RTC Archive on
 help / color / Atom feed
From: Joe Perches <>
To: Geert Uytterhoeven <>,
	Alessandro Zummo <>,
	Alexandre Belloni <>,
	Akinobu Mita <>
Subject: Re: [PATCH] rtc: i2c/spi: Avoid inclusion of REGMAP support when not needed
Date: Sun, 12 Jan 2020 22:36:00 -0800
Message-ID: <> (raw)
In-Reply-To: <>

On Sun, 2020-01-12 at 18:13 +0100, Geert Uytterhoeven wrote:
> Merely enabling I2C and RTC selects REGMAP_I2C and REGMAP_SPI, even when
> no driver needs it.  While the former can be moduler, the latter cannot,
> and thus becomes built-in.
> Fix this by moving the select statements for REGMAP_I2C and REGMAP_SPI
> from the RTC_I2C_AND_SPI helper to the individual drivers that depend on
> it.
> Note that the comment for RTC_I2C_AND_SPI refers to SND_SOC_I2C_AND_SPI
> for more information, but the latter does not select REGMAP_{I2C,SPI}
> itself, and defers that to the individual drivers, too.
> Fixes: 080481f54ef62121 ("rtc: merge ds3232 and ds3234")
> Signed-off-by: Geert Uytterhoeven <>
> ---
> Joe: When merging addresses, scripts/ replaces
>      Alexandre's authoritative email address from MAINTAINERS by the
>      obsolete address in the SoB-line of the commit referred to by the
>      Fixes-line.

Hi Geert

What are you doing to get this changed output?

I get the same get_maintainer address output either way
with only with the 'blamed_fixes:' content added.

Your email with 'Fixes:' line:

$ ./scripts/ ~/geert_1.mbox 
Alessandro Zummo <> (maintainer:REAL TIME CLOCK (RTC) SUBSYSTEM)
Alexandre Belloni <> (maintainer:REAL TIME CLOCK (RTC) SUBSYSTEM,blamed_fixes:1/1=100%)
Akinobu Mita <> (blamed_fixes:1/1=100%) (open list:REAL TIME CLOCK (RTC) SUBSYSTEM) (open list)

Your email without 'Fixes:' line:

$ ./scripts/ ~/geert_2.mbox 
Alessandro Zummo <> (maintainer:REAL TIME CLOCK (RTC) SUBSYSTEM)
Alexandre Belloni <> (maintainer:REAL TIME CLOCK (RTC) SUBSYSTEM) (open list:REAL TIME CLOCK (RTC) SUBSYSTEM) (open list)

  parent reply index

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-12 17:13 Geert Uytterhoeven
2020-01-12 21:45 ` kbuild test robot
2020-01-13  1:29 ` kbuild test robot
2020-01-13  6:36 ` Joe Perches [this message]
2020-01-13  7:25   ` Geert Uytterhoeven
2020-01-13  7:40     ` Joe Perches
2020-01-13  7:57       ` Geert Uytterhoeven
2020-01-13  8:12         ` Joe Perches
2020-01-14 10:13           ` Geert Uytterhoeven
2020-01-27 22:45 ` Alexandre Belloni
2020-01-28  8:33   ` Geert Uytterhoeven
2020-01-28  8:50     ` Alexandre Belloni
2020-01-28  8:59       ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-RTC Archive on

Archives are clonable:
	git clone --mirror linux-rtc/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-rtc linux-rtc/ \
	public-inbox-index linux-rtc

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone