From: Parthiban Nallathambi <pn@denx.de>
To: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: pn@denx.de, a.zummo@towertech.it, linux-rtc@vger.kernel.org,
linux-kernel@vger.kernel.org, parthitce@gmail.com
Subject: Re: [PATCH] rtc: rv3028: add clkout support
Date: Fri, 18 Oct 2019 12:02:28 +0200 [thread overview]
Message-ID: <942df087-0f61-f573-77a0-7b27582e25c8@denx.de> (raw)
In-Reply-To: <20191011091738.GC3125@piout.net>
Hi,
Thanks for the comments. Will send v2 with changes.
On 10/11/19 11:17 AM, Alexandre Belloni wrote:
> Hi,
>
> thanks for the patch, minor comments below.
>
> On 27/09/2019 16:15:05+0200, Parthiban Nallathambi wrote:
>> + ret = regmap_update_bits(rv3028->regmap, RV3028_STATUS,
>> + RV3028_STATUS_CLKF, 0);
>> + if (ret < 0)
>> + return ret;
>> +
>
> This is already done earlier and this will not be enabled again unless
> CLKIE is set which should not happen. So I don't think it is necessary
> to do it once again here.
Agree, removed in v2.
>
>> + for (i = 0; i < ARRAY_SIZE(clkout_rates); i++) {
>> + if (clkout_rates[i] == rate) {
>> + ret = regmap_update_bits(rv3028->regmap,
>> + RV3028_CLKOUT,
>> + RV3028_CLKOUT_FD_MASK, i);
>> + if (ret < 0)
>> + return ret;
>> +
>> + return regmap_write(rv3028->regmap, RV3028_CLKOUT,
>> + RV3028_CLKOUT_CLKSY | RV3028_CLKOUT_CLKOE);
>> + }
>> + }
>> +
>> + return -EINVAL;
>> +}
>
>
>> +static int rv3028_clkout_register_clk(struct rv3028_data *rv3028,
>> + struct i2c_client *client)
>> +{
>> + int ret;
>> + struct clk *clk;
>> + struct clk_init_data init;
>> + struct device_node *node = client->dev.of_node;
>> +
>> + /* disable the clkout output */
>> + ret = regmap_write(rv3028->regmap, RV3028_CLKOUT, 0x0);
>> + if (ret < 0)
>> + return ret;
>> +
>
> This is not what the user would expect and could introduce a glitch in
> the clock output every time the platform is booted. If there are no
> users of the clock, then you should probably let the core disable it
> once the boot has ended.
Thanks, removed in v2.
>
>
--
Thanks,
Parthiban N
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-22 Fax: (+49)-8142-66989-80 Email: pn@denx.de
prev parent reply other threads:[~2019-10-18 10:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-27 14:15 [PATCH] rtc: rv3028: add clkout support Parthiban Nallathambi
2019-10-11 9:17 ` Alexandre Belloni
2019-10-18 10:02 ` Parthiban Nallathambi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=942df087-0f61-f573-77a0-7b27582e25c8@denx.de \
--to=pn@denx.de \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=parthitce@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).