linux-rtc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2] rtc: da9052: convert to devm_rtc_allocate_device
@ 2020-03-29 22:42 Alexandre Belloni
  2020-04-01 10:28 ` Adam Thomson
  0 siblings, 1 reply; 2+ messages in thread
From: Alexandre Belloni @ 2020-03-29 22:42 UTC (permalink / raw)
  To: Support Opensource, Alessandro Zummo, Alexandre Belloni
  Cc: Adam Thomson, linux-rtc, linux-kernel

This allows further improvement of the driver.

Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
---

Changes in v2:
 - avoid reordering rtc registration and irq request.

 drivers/rtc/rtc-da9052.c | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/drivers/rtc/rtc-da9052.c b/drivers/rtc/rtc-da9052.c
index 204eb7cf1aa4..e76561b8ad4c 100644
--- a/drivers/rtc/rtc-da9052.c
+++ b/drivers/rtc/rtc-da9052.c
@@ -298,12 +298,16 @@ static int da9052_rtc_probe(struct platform_device *pdev)
 		rtc_err(rtc, "Failed to disable TICKS: %d\n", ret);
 
 	device_init_wakeup(&pdev->dev, true);
-	rtc->rtc = devm_rtc_device_register(&pdev->dev, pdev->name,
-				       &da9052_rtc_ops, THIS_MODULE);
-
+	rtc->rtc = devm_rtc_allocate_device(&pdev->dev);
 	if (IS_ERR(rtc->rtc))
 		return PTR_ERR(rtc->rtc);
 
+	rtc->rtc->ops = &da9052_rtc_ops;
+
+	ret = rtc_register_device(rtc->rtc);
+	if (ret)
+		return ret;
+
 	ret = da9052_request_irq(rtc->da9052, DA9052_IRQ_ALARM, "ALM",
 				da9052_rtc_irq, rtc);
 	if (ret != 0) {
-- 
2.25.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* RE: [PATCH v2] rtc: da9052: convert to devm_rtc_allocate_device
  2020-03-29 22:42 [PATCH v2] rtc: da9052: convert to devm_rtc_allocate_device Alexandre Belloni
@ 2020-04-01 10:28 ` Adam Thomson
  0 siblings, 0 replies; 2+ messages in thread
From: Adam Thomson @ 2020-04-01 10:28 UTC (permalink / raw)
  To: Alexandre Belloni, Support Opensource, Alessandro Zummo
  Cc: Adam Thomson, linux-rtc, linux-kernel

On 29 March 2020 23:43, Alexandre Belloni wrote:

> This allows further improvement of the driver.
> 
> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>

Acked-by: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>

> ---
> 
> Changes in v2:
>  - avoid reordering rtc registration and irq request.
> 
>  drivers/rtc/rtc-da9052.c | 10 +++++++---
>  1 file changed, 7 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/rtc/rtc-da9052.c b/drivers/rtc/rtc-da9052.c
> index 204eb7cf1aa4..e76561b8ad4c 100644
> --- a/drivers/rtc/rtc-da9052.c
> +++ b/drivers/rtc/rtc-da9052.c
> @@ -298,12 +298,16 @@ static int da9052_rtc_probe(struct platform_device
> *pdev)
>  		rtc_err(rtc, "Failed to disable TICKS: %d\n", ret);
> 
>  	device_init_wakeup(&pdev->dev, true);
> -	rtc->rtc = devm_rtc_device_register(&pdev->dev, pdev->name,
> -				       &da9052_rtc_ops, THIS_MODULE);
> -
> +	rtc->rtc = devm_rtc_allocate_device(&pdev->dev);
>  	if (IS_ERR(rtc->rtc))
>  		return PTR_ERR(rtc->rtc);
> 
> +	rtc->rtc->ops = &da9052_rtc_ops;
> +
> +	ret = rtc_register_device(rtc->rtc);
> +	if (ret)
> +		return ret;
> +
>  	ret = da9052_request_irq(rtc->da9052, DA9052_IRQ_ALARM, "ALM",
>  				da9052_rtc_irq, rtc);
>  	if (ret != 0) {
> --
> 2.25.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-04-01 10:28 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-29 22:42 [PATCH v2] rtc: da9052: convert to devm_rtc_allocate_device Alexandre Belloni
2020-04-01 10:28 ` Adam Thomson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).