From: Peng Ma <peng.ma@nxp.com>
To: YueHaibing <yuehaibing@huawei.com>,
"a.zummo@towertech.it" <a.zummo@towertech.it>,
"alexandre.belloni@bootlin.com" <alexandre.belloni@bootlin.com>
Cc: "linux-rtc@vger.kernel.org" <linux-rtc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH -next] rtc: fsl-ftm-alarm: remove set but not used variable 'np'
Date: Wed, 25 Mar 2020 01:50:35 +0000 [thread overview]
Message-ID: <AM7PR04MB70165A5F952E4A3FE3A4EF8BEDCE0@AM7PR04MB7016.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20200324070336.59972-1-yuehaibing@huawei.com>
>-----Original Message-----
>From: YueHaibing <yuehaibing@huawei.com>
>Sent: 2020年3月24日 15:04
>To: a.zummo@towertech.it; alexandre.belloni@bootlin.com
>Cc: linux-rtc@vger.kernel.org; linux-kernel@vger.kernel.org; Peng Ma
><peng.ma@nxp.com>; YueHaibing <yuehaibing@huawei.com>
>Subject: [PATCH -next] rtc: fsl-ftm-alarm: remove set but not used variable 'np'
>
>drivers/rtc/rtc-fsl-ftm-alarm.c: In function 'ftm_rtc_probe':
>drivers/rtc/rtc-fsl-ftm-alarm.c:246:22: warning: unused variable 'np'
>[-Wunused-variable]
> struct device_node *np = pdev->dev.of_node;
> ^~
>commit cd49b579e705 ("rtc: fsl-ftm-alarm: enable acpi support") left behind
>this, remove it.
>
>Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>---
> drivers/rtc/rtc-fsl-ftm-alarm.c | 1 -
> 1 file changed, 1 deletion(-)
>
>diff --git a/drivers/rtc/rtc-fsl-ftm-alarm.c b/drivers/rtc/rtc-fsl-ftm-alarm.c index
>c572044ff06e..0f4142b35f38 100644
>--- a/drivers/rtc/rtc-fsl-ftm-alarm.c
>+++ b/drivers/rtc/rtc-fsl-ftm-alarm.c
>@@ -243,7 +243,6 @@ static const struct rtc_class_ops ftm_rtc_ops = {
>
> static int ftm_rtc_probe(struct platform_device *pdev) {
>- struct device_node *np = pdev->dev.of_node;
[Peng Ma] Hi, HaiBing,
Thanks for your patch, this patch has already in upstream(https://lore.kernel.org/patchwork/patch/1214014/)
Best Regards,
Peng
> int irq;
> int ret;
> struct ftm_rtc *rtc;
>--
>2.17.1
>
prev parent reply other threads:[~2020-03-25 1:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-24 7:03 [PATCH -next] rtc: fsl-ftm-alarm: remove set but not used variable 'np' YueHaibing
2020-03-25 1:50 ` Peng Ma [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM7PR04MB70165A5F952E4A3FE3A4EF8BEDCE0@AM7PR04MB7016.eurprd04.prod.outlook.com \
--to=peng.ma@nxp.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).