From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E7BAC433DB for ; Tue, 2 Feb 2021 03:52:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B71CA64ECE for ; Tue, 2 Feb 2021 03:52:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231526AbhBBDwF (ORCPT ); Mon, 1 Feb 2021 22:52:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59996 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231518AbhBBDwD (ORCPT ); Mon, 1 Feb 2021 22:52:03 -0500 Received: from mail-il1-x134.google.com (mail-il1-x134.google.com [IPv6:2607:f8b0:4864:20::134]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 86360C06174A for ; Mon, 1 Feb 2021 19:51:23 -0800 (PST) Received: by mail-il1-x134.google.com with SMTP id l4so17800038ilo.11 for ; Mon, 01 Feb 2021 19:51:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=DUbVLJ+6EapSl5sVNLf8sgof9k3YF74Apn4NRNuZrBI=; b=G139zDlnZdSnzIKH7yG75Inkorodk6X7AjLca6dTCwnjSMyL1PTsMAWZbIzfthY3R/ l8oxeWNBoH7WS3B3ILFRsEFRguGNqVruEpnIW/oJuq9kukOrYVIY2fSXSvBptglZ0eM9 bb2hgs2LbjxiECmNi0TNOMF+lqm5YVN30AvK20Y18+IAq4YKOET0Vli6u3q9SXw68Mhj 6xYne4B8ydAADwTKwuzAnO6mKZ9F40RtN1M4C4i6N9Asa8uh/R9oJd5EL+sq5mg/hVpP iTohNwVMbv2/+j6wVhOL99ZY/Ng+qkog64cUg44UbFyz2AaHNfIDKKcZyE8pbPQV6gtM 0HVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=DUbVLJ+6EapSl5sVNLf8sgof9k3YF74Apn4NRNuZrBI=; b=DLHDTEBFyeomV08Cs4ztH/jG5C75kyJY7JgX8UHP8kzegeXyEnX6JLUZ8k52QxlJSw z6oJnenSwcXoyOOR2kRW9VE43OtmYtwFp1TQiRQiGHYyMZPUVjqda7Q21ID5Z8z3ywli GaPsnYylKbpad8gZlDiqqacUq7lzaYosZAtWraG3Cvdz8q0ETLoWHe2SqPMfMft52Rd2 3VvIed5MllM1TlWlTzhRlkPWqVokVvnXHnxGM2tTSTMNA5FCJ+3qKd9RIlRM6qRKIA4c XESBOdNHeclCFpuGYtgRviYvS9iVs3AXicZSLjw7AMhzDQZsrYWFErQjISSdMtoLosl2 yaRw== X-Gm-Message-State: AOAM5338oWjazvID768BBok37bkxxNqtMsmS64nT4A7MpLN4fuZqbqE9 Itygs5n3o0zVUu+P8QyRI3C+2XyYKLWEcn0rTz0AfQ== X-Google-Smtp-Source: ABdhPJxc3qlV1vDkvr6AKiJA6v8PIzxjnHjrC8AiVb4RHEO7WgoEnWmUihcs05hGWpDlchzD4tCKWKvEQhihhe0Ou5s= X-Received: by 2002:a05:6e02:d42:: with SMTP id h2mr17203540ilj.204.1612237882649; Mon, 01 Feb 2021 19:51:22 -0800 (PST) MIME-Version: 1.0 References: <1611913781-23460-1-git-send-email-hsin-hsiung.wang@mediatek.com> <1611913781-23460-9-git-send-email-hsin-hsiung.wang@mediatek.com> <1cbf58f1-376c-fa93-98a2-53a41fa24273@gmail.com> In-Reply-To: <1cbf58f1-376c-fa93-98a2-53a41fa24273@gmail.com> From: Tzung-Bi Shih Date: Tue, 2 Feb 2021 11:51:11 +0800 Message-ID: Subject: Re: [PATCH RESEND v5 8/8] arm64: dts: mt6359: add PMIC MT6359 related nodes To: Matthias Brugger Cc: Hsin-Hsiung Wang , Lee Jones , Rob Herring , Liam Girdwood , Mark Brown , Alessandro Zummo , Alexandre Belloni , Fei Shao , Eddie Huang , Sean Wang , Yuchen Huang , Ran Bi , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:ARM/Mediatek SoC support" , "moderated list:ARM/Mediatek SoC support" , Linux Kernel Mailing List , linux-rtc@vger.kernel.org, srv_heupstream@mediatek.com, Project_Global_Chrome_Upstream_Group@mediatek.com, Wen Su , Jiaxin Yu Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-rtc@vger.kernel.org On Sun, Jan 31, 2021 at 7:06 PM Matthias Brugger wrote: > On 29/01/2021 10:49, Hsin-Hsiung Wang wrote: > > + mt6359codec: mt6359codec { > > + }; > > I understand that the dmic-mode and mic-type-X depends on the actual board on > which it is used. In that case I think we should add mt6359codec node in the dts > instead of dtsi file. I'd advise to set these properties as well as otherwise we > get a (slightly misleading) warning in the driver. I feel it is better to include the node in dtsi to represent the whole MT6359 PMIC. We could either: - Set default values of these properties in the dtsi to avoid the warning message. - Or https://patchwork.kernel.org/project/alsa-devel/patch/20210202033557.1621029-1-tzungbi@google.com/