Linux-RTC Archive on lore.kernel.org
 help / color / Atom feed
From: Yizhuo Zhai <yzhai003@ucr.edu>
To: Alessandro Zummo <a.zummo@towertech.it>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org,
	Zhiyun Qian <zhiyunq@cs.ucr.edu>, Chengyu Song <csong@cs.ucr.edu>
Subject: Potential uninitialized variables in rtc: ds1343
Date: Wed, 9 Oct 2019 17:36:28 -0700
Message-ID: <CABvMjLRirOKZvCaknF6isxRPvOgMeij2YZe1ef83EEg0kFnUjg@mail.gmail.com> (raw)

Hi All:
drivers/rtc/rtc-ds1343.c:
Inside function ds1343_show_glitchfilter(), variable "data" could be
uninitialized if regmap_read() returns -EINVAL. However,"data"
is used later in the if statement, which is potentially unsafe. Patch
for this case is hard since the return value -EINVAL is unacceptable
for ds1343_show_glitchfilter().

-- 
Kind Regards,

Yizhuo Zhai

Computer Science, Graduate Student
University of California, Riverside

                 reply index

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CABvMjLRirOKZvCaknF6isxRPvOgMeij2YZe1ef83EEg0kFnUjg@mail.gmail.com \
    --to=yzhai003@ucr.edu \
    --cc=a.zummo@towertech.it \
    --cc=alexandre.belloni@bootlin.com \
    --cc=csong@cs.ucr.edu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rtc@vger.kernel.org \
    --cc=zhiyunq@cs.ucr.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-RTC Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-rtc/0 linux-rtc/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-rtc linux-rtc/ https://lore.kernel.org/linux-rtc \
		linux-rtc@vger.kernel.org linux-rtc@archiver.kernel.org
	public-inbox-index linux-rtc

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-rtc


AGPL code for this site: git clone https://public-inbox.org/ public-inbox