From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 392B0C35646 for ; Fri, 21 Feb 2020 15:34:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1128E24650 for ; Fri, 21 Feb 2020 15:34:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="v90zLbE5" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728344AbgBUPeN (ORCPT ); Fri, 21 Feb 2020 10:34:13 -0500 Received: from mail-lf1-f66.google.com ([209.85.167.66]:42112 "EHLO mail-lf1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728646AbgBUPeN (ORCPT ); Fri, 21 Feb 2020 10:34:13 -0500 Received: by mail-lf1-f66.google.com with SMTP id 83so1786272lfh.9 for ; Fri, 21 Feb 2020 07:34:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=hUVfMiXxCwbSjtH9BPcnP06NcLeQvKTFfCk+TkAB1ZQ=; b=v90zLbE5oSFF85/nmKa9caaE43xtNO2sg0peoa6K/LaorENVEkOf35lATcCgMyTbPW O69VCm2Xttmp1nfwqSxxxy9Z1qj2m0SM9sgeOCvFYl6ECFGp8Z49HGtUdDD7nDXZV52M 7mVPCdX9y3erbnBlOsk9iMOXmAKwPffElO75JsVMyUHRTzF0K94XzifctntrM7BCB0Ih fQWoyZ9Vw8c/u6cRD6ECP8tO3GWZezpVnii5ZYj2mp/KTrGI7hxBaziucNlZ/+MH44i7 oNQMfu6cTpDPUepThAKF9qA3+I22/r3p1UKcvLrsvEjQ5WzRxqInd4YIw+8dM1T1IxQa crrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hUVfMiXxCwbSjtH9BPcnP06NcLeQvKTFfCk+TkAB1ZQ=; b=Q0kpTsDsbzh9KKzH6mSiQ5O9oJ48Pxbd0m9uUyyPge0mO7Fuy0istYIDQ7uFwT9zFh oGpvg+xUsyI8m0hWkZaJc1TwMXCkbzcTn5maY+Uy8RbtYTzk5wlQo6Zlj4kwYyNvhQqO Hr+05PM8aYVnVwUUqD5mSRyyKOu9A7ffAGMUrgFqaC7Lv7OMWgmrOqO7XHJTc69bMQ9l 7rmnheNEXsbprRiRdCv4oLY8dvvcMYsJhYEBc1beY8YLxogKe1JfzVqhZxZN6balWSrL BdSI7f0UpkQneUFKU1sYNcxhioB+yt8BRUT41efwgT92+TTJ0kqWVfZ3XY8rbbeCjB8n LX9g== X-Gm-Message-State: APjAAAVvvjtSm5vdnMbxSIc/TzgThDxcPYsnvGce54/5sxOC0f1c6pc2 hO2OCl+WglNfkSFHEyRtY5m6LO3PfQxxIwbf+IRdfg== X-Google-Smtp-Source: APXvYqxFOhbB45zhwJACKnRWGrffnbDn/50wsrqM8zfRboGUcRtR/fIOZXVdUDsZuFjz9JDddI6CuEa9zN+Z1wPCOKA= X-Received: by 2002:ac2:5499:: with SMTP id t25mr19779301lfk.194.1582299251375; Fri, 21 Feb 2020 07:34:11 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Linus Walleij Date: Fri, 21 Feb 2020 16:34:00 +0100 Message-ID: Subject: Re: [PATCH v2 6/8] pinctrl: imx: scu: Align imx sc msg structs to 4 To: Leonard Crestez Cc: Shawn Guo , Dong Aisheng , Fabio Estevam , Michael Turquette , Stephen Boyd , Stefan Agner , Alessandro Zummo , Alexandre Belloni , Anson Huang , Abel Vesa , Franck LENORMAND , Sascha Hauer , NXP Linux Team , Linux ARM , linux-clk , "open list:GPIO SUBSYSTEM" , linux-rtc@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-rtc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rtc@vger.kernel.org On Thu, Feb 20, 2020 at 5:29 PM Leonard Crestez wrote: > The imx SC api strongly assumes that messages are composed out of > 4-bytes words but some of our message structs have odd sizeofs. > > This produces many oopses with CONFIG_KASAN=y. > > Fix by marking with __aligned(4). > > Fixes: b96eea718bf6 ("pinctrl: fsl: add scu based pinctrl support") > Signed-off-by: Leonard Crestez Patch applied for fixes. KASan needs to work. Thanks for fixing this! Yours, Linus Walleij