From: Li Yang <leoyang.li@nxp.com>
To: Biwen Li <biwen.li@nxp.com>, Rob Herring <robh+dt@kernel.org>
Cc: a.zummo@towertech.it, alexandre.belloni@bootlin.com,
linux-rtc@vger.kernel.org, lkml <linux-kernel@vger.kernel.org>,
Xiaobo Xie <xiaobo.xie@nxp.com>, Jiafei Pan <jiafei.pan@nxp.com>,
Ran Wang <ran.wang_1@nxp.com>
Subject: Re: [v2,2/2] Documentation: dt: binding: rtc: add binding for ftm alarm driver
Date: Wed, 10 Jul 2019 14:45:58 -0500 [thread overview]
Message-ID: <CADRPPNQ8nZQYq1ZXZ368LLeKnyrXpjB_X8XaHVhW890bw-tU6A@mail.gmail.com> (raw)
In-Reply-To: <20190710110424.4254-2-biwen.li@nxp.com>
On Wed, Jul 10, 2019 at 6:35 AM Biwen Li <biwen.li@nxp.com> wrote:
>
> The patch adds binding for ftm alarm driver
>
> Signed-off-by: Biwen Li <biwen.li@nxp.com>
Looks like I commented the older version just now. Adding Rob to this
version too.
> ---
> Change in v2:
> - replace ls1043a with ls1088a as example
> - add rcpm node and fsl,rcpm-wakeup property
>
> .../devicetree/bindings/rtc/rtc-fsl-ftm-alarm.txt | 40 ++++++++++++++++++++++
> 1 file changed, 40 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/rtc/rtc-fsl-ftm-alarm.txt
>
> diff --git a/Documentation/devicetree/bindings/rtc/rtc-fsl-ftm-alarm.txt b/Documentation/devicetree/bindings/rtc/rtc-fsl-ftm-alarm.txt
> new file mode 100644
> index 0000000..010984a
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/rtc/rtc-fsl-ftm-alarm.txt
> @@ -0,0 +1,40 @@
> +Freescale FlexTimer Module (FTM) Alarm
> +
> +Note: The driver need work with RCPM driver to wake up system in sleep.
> +
> +Required properties:
> +
> +- compatible : Should be "fsl,ftm-alarm" or "fsl,<chip>-ftm-alarm", the
> + supported chips include
> + "fsl,ls1012a-ftm-alarm"
> + "fsl,ls1021a-ftm-alarm"
> + "fsl,ls1028a-ftm-alarm"
> + "fsl,ls1043a-ftm-alarm"
> + "fsl,ls1046a-ftm-alarm"
> + "fsl,ls1088a-ftm-alarm"
> + "fsl,ls208xa-ftm-alarm"
> +- reg : Specifies base physical address and size of the register sets for the
> + FlexTimer Module and base physical address of IP Powerdown Exception Control
> + Register.
> +- reg-names: names of the mapped memory regions listed in regs property.
> + should include the following entries:
> + "ftm": Address of the register sets for FlexTimer Module
> +- interrupts : Should be the FlexTimer Module interrupt.
> +- fsl,rcpm-wakeup property and rcpm node : Please refer
> + Documentation/devicetree/bindings/soc/fsl/rcpm.txt
Looks better.
> +- big-endian: If the host controller is big-endian mode, specify this property.
> + The default endian mode is little-endian.
Same comment about optional property.
> +
> +Example:
> +rcpm: rcpm@1e34050 {
> + compatible = "fsl,ls1088a-rcpm", "fsl,qoriq-rcpm-2.1+";
> + reg = <0x0 0x1e34050 0x0 0x4>;
> + fsl,#rcpm-wakeup-cells = <1>;
> +}
> +
> +ftm_alarm0: timer@2800000 {
> + compatible = "fsl,ftm-alarm";
> + reg = <0x0 0x2800000 0x0 0x10000>;
> + fsl,rcpm-wakeup = <&rcpm 0x0 0x4000>;
> + interrupts = <0 44 4>;
> +}
> --
> 2.7.4
>
next prev parent reply other threads:[~2019-07-10 19:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-10 11:04 [v2,1/2] rtc/fsl: add FTM alarm driver as the wakeup source Biwen Li
2019-07-10 11:04 ` [v2,2/2] Documentation: dt: binding: rtc: add binding for ftm alarm driver Biwen Li
2019-07-10 19:45 ` Li Yang [this message]
2019-07-10 20:26 ` Rob Herring
2019-07-11 11:04 ` [EXT] " Biwen Li
2019-07-10 21:11 ` [v2,1/2] rtc/fsl: add FTM alarm driver as the wakeup source Li Yang
2019-07-11 14:12 ` Biwen Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADRPPNQ8nZQYq1ZXZ368LLeKnyrXpjB_X8XaHVhW890bw-tU6A@mail.gmail.com \
--to=leoyang.li@nxp.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=biwen.li@nxp.com \
--cc=jiafei.pan@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=ran.wang_1@nxp.com \
--cc=robh+dt@kernel.org \
--cc=xiaobo.xie@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).