Linux-RTC Archive on lore.kernel.org
 help / color / Atom feed
From: Li Yang <leoyang.li@nxp.com>
To: Biwen Li <biwen.li@nxp.com>, Rob Herring <robh+dt@kernel.org>
Cc: a.zummo@towertech.it, alexandre.belloni@bootlin.com,
	linux-rtc@vger.kernel.org, lkml <linux-kernel@vger.kernel.org>,
	Xiaobo Xie <xiaobo.xie@nxp.com>, Jiafei Pan <jiafei.pan@nxp.com>,
	Ran Wang <ran.wang_1@nxp.com>
Subject: Re: [PATCH 2/2] Documentation: dt: binding: rtc: add binding for ftm alarm driver
Date: Wed, 10 Jul 2019 14:43:24 -0500
Message-ID: <CADRPPNTg52BNx6bN1P9+WQnf+gG8p2hnLuxWEUXoy1CSt55Npw@mail.gmail.com> (raw)
In-Reply-To: <20190705101800.44561-2-biwen.li@nxp.com>

On Fri, Jul 5, 2019 at 6:26 AM Biwen Li <biwen.li@nxp.com> wrote:
>
> The patch adds binding for ftm alarm driver
>
> Signed-off-by: Biwen Li <biwen.li@nxp.com>

Please add dts maintainer for binding patches.  I have added Rob.

> ---
>  .../devicetree/bindings/rtc/rtc-fsl-ftm-alarm.txt  | 33 ++++++++++++++++++++++
>  1 file changed, 33 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/rtc/rtc-fsl-ftm-alarm.txt
>
> diff --git a/Documentation/devicetree/bindings/rtc/rtc-fsl-ftm-alarm.txt b/Documentation/devicetree/bindings/rtc/rtc-fsl-ftm-alarm.txt
> new file mode 100644
> index 0000000..0f330b4
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/rtc/rtc-fsl-ftm-alarm.txt
> @@ -0,0 +1,33 @@
> +Freescale FlexTimer Module (FTM) Alarm
> +
> +Required properties:
> +
> +- compatible : Should be "fsl,ftm-alarm" or "fsl,<chip>-ftm-alarm", the
> +              supported chips include
> +              "fsl,ls1012a-ftm-alarm"
> +              "fsl,ls1021a-ftm-alarm"
> +              "fsl,ls1028a-ftm-alarm"
> +              "fsl,ls1043a-ftm-alarm"
> +              "fsl,ls1046a-ftm-alarm"
> +              "fsl,ls1088a-ftm-alarm"
> +              "fsl,ls208xa-ftm-alarm"
> +- reg : Specifies base physical address and size of the register sets for the
> +  FlexTimer Module and base physical address of IP Powerdown Exception Control
> +  Register.
> +- reg-names: names of the mapped memory regions listed in regs property.
> +  should include the following entries:
> +  "ftm":    Address of the register sets for FlexTimer Module
> +  "pmctrl": Address of IP Powerdown Exception Control register

I assume we don't need this after we let the rcpm driver to deal with this.

> +- interrupts : Should be the FlexTimer Module interrupt.
> +- big-endian: If the host controller is big-endian mode, specify this property.
> +  The default endian mode is little-endian.

If it is optional as suggested by the description, put it in the
optinal property section.

> +
> +Example:
> +ftm_alarm0: timer@29d0000 {
> +       compatible = "fsl,ls1043a-ftm-alarm";
> +       reg = <0x0 0x29d0000 0x0 0x10000>,
> +             <0x0 0x1ee2140 0x0 0x4>;
> +       reg-names = "ftm", "pmctrl";
> +       interrupts = <0 86 0x4>;
> +       big-endian;
> +};
> --
> 2.7.4
>

  reply index

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-05 10:17 [PATCH 1/2] rtc/fsl: add FTM alarm driver as the wakeup source Biwen Li
2019-07-05 10:18 ` [PATCH 2/2] Documentation: dt: binding: rtc: add binding for ftm alarm driver Biwen Li
2019-07-10 19:43   ` Li Yang [this message]
2019-07-08 19:41 ` [PATCH 1/2] rtc/fsl: add FTM alarm driver as the wakeup source Leo Li
2019-07-09  5:27   ` Biwen Li

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CADRPPNTg52BNx6bN1P9+WQnf+gG8p2hnLuxWEUXoy1CSt55Npw@mail.gmail.com \
    --to=leoyang.li@nxp.com \
    --cc=a.zummo@towertech.it \
    --cc=alexandre.belloni@bootlin.com \
    --cc=biwen.li@nxp.com \
    --cc=jiafei.pan@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rtc@vger.kernel.org \
    --cc=ran.wang_1@nxp.com \
    --cc=robh+dt@kernel.org \
    --cc=xiaobo.xie@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-RTC Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-rtc/0 linux-rtc/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-rtc linux-rtc/ https://lore.kernel.org/linux-rtc \
		linux-rtc@vger.kernel.org linux-rtc@archiver.kernel.org
	public-inbox-index linux-rtc


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-rtc


AGPL code for this site: git clone https://public-inbox.org/ public-inbox