From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1125C4360F for ; Thu, 4 Apr 2019 19:05:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 87BED2082E for ; Thu, 4 Apr 2019 19:05:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="J4/GFTF6" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730041AbfDDTFy (ORCPT ); Thu, 4 Apr 2019 15:05:54 -0400 Received: from mail-lf1-f65.google.com ([209.85.167.65]:44304 "EHLO mail-lf1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730024AbfDDTFy (ORCPT ); Thu, 4 Apr 2019 15:05:54 -0400 Received: by mail-lf1-f65.google.com with SMTP id v71so2567432lfa.11 for ; Thu, 04 Apr 2019 12:05:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=wKp1rToFdUGex172LVCX0S/Lj/+9JfBGYyB2ooa9bw8=; b=J4/GFTF6WiD2eqrOe/qDLL+4K0u79+9aUDktAtydDNX5hWx0OHDh2X7kJpjzwPpchV SiWfee8aMiHpq1J5aSp3kZ1IibqcozEXsT200sZ+Nk5JL9PCRCZlYxeAex1+8/9ZCfmG YyCpUc/8lROQ7J9Nregwatwr7R5QYLZhkUZ4U0Q8v+cXVqTkzhVTmXe8b2/kyw6qfDca Cf3gEs97AG5NYPWLQQaxwyCju/kBzaOjRhp4ngkT51sPzd6tIl1CjXiC3RTccZvoB72z d89G8uVn8unlC4TLC3lMJJF8DKuKdc/aRrJ9nSa2PQbx7JoRjvmoteEyeJ2LL8YaL8qb zARg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wKp1rToFdUGex172LVCX0S/Lj/+9JfBGYyB2ooa9bw8=; b=JNfldiprumzSB7C6t0NUJARSrKqHMwhhs1PKAD0eKX8zI54QAq4sS365lkfOekY+W0 JDzui2tUR85UNqsq35lc/5YKYjxWZRdNEg7DxDXnYgfxw1sj5wjAKXff/ffCXRsyn1OT h8jZGFREC3pQi6CTmYbrB9l1uKyaUuavrQ8Rj5o8I9Olo2dsOOaC57pxXcBNgjl3hwNK HExVQF6NXEo0xjqhPCy8XAs8msCXMrpNa9Egj1iPxG5sVw/3v0KW0xQ4UO/GjCHpgdgY SGm2qaBtTlz9XoOPEGUENOEiPlCKOE9ewIIkj5oATg4DB60oAAah8MiWub3pNjG/8l9y Wfsg== X-Gm-Message-State: APjAAAV7Ga2un3jP7CTMtFp1HklxuCWjpMGuMV4Bba5TD/LTLpXzQKD1 T4guBXqv75pJRmy1ypEftA2xhVe24GwAH2XfivEcKA== X-Google-Smtp-Source: APXvYqy0gbMNmAyjyQz0nO3CKzDALY2qplhIL0ptFdNPIDI/FCG2gdRKxASq06bVTpt4VNdECbYRa36LsUMUHP6KtjQ= X-Received: by 2002:ac2:42c8:: with SMTP id n8mr4302514lfl.28.1554404751351; Thu, 04 Apr 2019 12:05:51 -0700 (PDT) MIME-Version: 1.0 References: <20190404171007.160878-1-ncrews@chromium.org> <20190404171007.160878-3-ncrews@chromium.org> <20190404185919.GB27340@amd> In-Reply-To: <20190404185919.GB27340@amd> From: Dmitry Torokhov Date: Thu, 4 Apr 2019 12:05:39 -0700 Message-ID: Subject: Re: [PATCH v5 3/3] platform/chrome: Standardize Chrome OS keyboard backlight name To: Pavel Machek Cc: Nick Crews , Guenter Roeck , Enric Balletbo i Serra , Benson Leung , linux-leds@vger.kernel.org, Jacek Anaszewski , Alexandre Belloni , Alessandro Zummo , linux-rtc@vger.kernel.org, linux-kernel , Duncan Laurie , Simon Glass Content-Type: text/plain; charset="UTF-8" Sender: linux-rtc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rtc@vger.kernel.org On Thu, Apr 4, 2019 at 11:59 AM Pavel Machek wrote: > > On Thu 2019-04-04 11:55:27, Dmitry Torokhov wrote: > > On Thu, Apr 4, 2019 at 11:41 AM Nick Crews wrote: > > > > > > On Thu, Apr 4, 2019 at 11:43 AM Dmitry Torokhov wrote: > > > > > > > > On Thu, Apr 4, 2019 at 10:36 AM Guenter Roeck wrote: > > > > > > > > > > On Thu, Apr 4, 2019 at 10:11 AM Nick Crews wrote: > > > > > > > > > > > > We want all backlights for the system keyboard to > > > > > > use a common name, so the name "platform::kbd_backlight" > > > > > > would be better than the current "chromeos::kbd_backlight" > > > > > > name. Normally this wouldn't be worth changing, but the new > > > > > > Wilco keyboard backlight driver uses the "platform" name. > > > > > > We want to make it so all Chrome OS devices are consistent, > > > > > > so we'll change the name here too. > > > > > > > > > > > > > > > > Wondering - who is the "we" you are talking about ? > > > > > > You're right, I should have been more precise. > > > I was referring to Pavel, Enric, and myself. Pavel had this opinion here: > > > https://lkml.org/lkml/2019/4/4/1040. I don't know what Pavel meant by "we" > > > in that comment, but I would guess that could mean the other LED maintainers > > > as well? I talked with Enric 1:1 and he didn't see the problem with changing it, > > > though perhaps he was only considering our use of the LED via powerd, > > > and not users in general. I'm guessing Pavel's and Enric's meanings though, > > > excuse me if I am misinterpreting. > > > > > > > > > > > This also has a potential of breaking existing setups if somebody did > > > > happen to match on entire name instead of suffix. Such changes have to > > > > be considered very carefully; at this point I am against of doing > > > > this. > > > > > > Would it make sense to keep the old name as is, and only make the new > > > Wilco name begin with "platform:"? What would you think is best? > > > > Given that we do not have a single instance of platform::kbd_backlight > > in kernel at this time I have no idea why Pavel is trying to push this > > for Wilco driver. > > See the documentation in the email I sent few seconds ago. I hope it > explains my reasoning, if not, I'll explain it. Yes, I see the doc and I do not think I agree with it. If you look at the LED docs you will see: LED Device Naming ================= Is currently of the form: "devicename:colour:function" It is *function* and maybe color that userspace is interested in, and here we have proper standardization in form of "kbd_backlight". Device name is, well, device name. It should uniquely identify the device led is attached to, but otherwise is rarely interesting. If userspace is really concerned what kind of keyboard backlight it is it should investigate parent device(s) and see what they end up with. Thanks. -- Dmitry